Page MenuHomePhabricator

[Regression] "[dismiss]" button shows up on all pages for no apparent reason
Closed, ResolvedPublicPRODUCTION ERROR

Description

Seen on mediawiki.org today.

The MediaWiki:Sitenotice page is empty, but yet [dismiss] shows up everywhere.

Steps to reproduce

  1. Go to any article on a production wiki (ex: https://ca.wikipedia.org/wiki/Tuc_de_la_Llan%C3%A7a)

Expected:

  • If no banner is running, no dismiss link is displayed

Observed:

  • Dismissed link is displayed

QA Results - Beta|Prod

ACStatusDetails
1T271365#6740642

Event Timeline

Krinkle created this task.Wed, Jan 6, 9:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Jan 6, 9:26 PM
Krinkle triaged this task as Unbreak Now! priority.EditedWed, Jan 6, 9:27 PM
Krinkle added a project: Readers-Web-Backlog.

This seems likely caused by the surprise work on merging the feature (along wit its known tech debt) into MW core, ref T259903, T262118.

I've lef some post-merge code review at https://gerrit.wikimedia.org/r/c/mediawiki/core/+/631177. The change was high-risk and made major changes to the logic that are unexplained, likely unintended, and were not noticed during the original code review.

I'd recommend revert for now so that it can be properly reviewed, tested, and documented in a core patch for next week.

Change 654460 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] Revert "Provide native support to dismiss sitenotice in core."

https://gerrit.wikimedia.org/r/654460

Jdlrobson moved this task from Incoming to Needs Prioritization on the Readers-Web-Backlog board.

Change 654461 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@wmf/1.36.0-wmf.25] Revert "Provide native support to dismiss sitenotice in core."

https://gerrit.wikimedia.org/r/654461

@Jdlrobson Can you confirm that VERSION_MAJOR is safe to revert at this time? Afaik things should fall into place, but want to make sure train conductors don't roll forward without your input on that.

Change 654460 merged by jenkins-bot:
[mediawiki/core@master] Revert "Provide native support to dismiss sitenotice in core."

https://gerrit.wikimedia.org/r/654460

@Jdlrobson Can you confirm that VERSION_MAJOR is safe to revert at this time? Afaik things should fall into place, but want to make sure train conductors don't roll forward without your input on that.

Ftr, there's a comment about that in the wmf.25 patch with a CR+1 from Jon.

ovasileva updated the task description. (Show Details)Thu, Jan 7, 6:00 PM

Change 654461 merged by jenkins-bot:
[mediawiki/core@wmf/1.36.0-wmf.25] Revert "Provide native support to dismiss sitenotice in core."

https://gerrit.wikimedia.org/r/654461

Mentioned in SAL (#wikimedia-operations) [2021-01-07T19:53:42Z] <urbanecm@deploy1001> Synchronized php-1.36.0-wmf.25/includes/skins/: 59866730ea7534db9e47ea308ba2a3c1807d5f11: Revert "Provide native support to dismiss sitenotice in core." (T271365; T259903; 1/3) (duration: 01m 04s)

Mentioned in SAL (#wikimedia-operations) [2021-01-07T19:55:01Z] <urbanecm@deploy1001> Synchronized php-1.36.0-wmf.25/resources/: 59866730ea7534db9e47ea308ba2a3c1807d5f11: Revert "Provide native support to dismiss sitenotice in core." (T271365; T259903; 2/3) (duration: 01m 05s)

Mentioned in SAL (#wikimedia-operations) [2021-01-07T19:56:27Z] <urbanecm@deploy1001> Synchronized php-1.36.0-wmf.25/includes/DefaultSettings.php: 59866730ea7534db9e47ea308ba2a3c1807d5f11: Revert "Provide native support to dismiss sitenotice in core." (T271365; T259903; 3/3) (duration: 01m 03s)

Jdlrobson lowered the priority of this task from Unbreak Now! to Medium.Thu, Jan 7, 8:16 PM

Let's verify the dismiss link is gone before resolving.

The footer comment of DefaultSettings.php was incorrectly reverted. It should be restored.

hashar added a subscriber: hashar.Fri, Jan 8, 8:47 AM

We have pushed 1.36.0-wmf.25 everywhere, I have removed this task from the list of blockers.

Change 655192 had a related patch set uploaded (by Shirayuki; owner: Shirayuki):
[mediawiki/core@master] DefaultSettings: Improve custom folding and grouping

https://gerrit.wikimedia.org/r/655192

Change 655192 merged by jenkins-bot:
[mediawiki/core@master] DefaultSettings: Improve custom folding and grouping

https://gerrit.wikimedia.org/r/655192

ovasileva reassigned this task from ovasileva to Edtadros.Mon, Jan 11, 4:09 PM
ovasileva added a subscriber: ovasileva.

Edtadros reassigned this task from Edtadros to ovasileva.Tue, Jan 12, 5:53 PM
Edtadros added a subscriber: Edtadros.

Test Result - Prod

Status: ✅ PASS
Environment: cawiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Go to any article on a production wiki (ex: https://ca.wikipedia.org/wiki/Tuc_de_la_Llan%C3%A7a)
Expected:

✅ AC1: [dismiss] link is NOT displayed

Edtadros updated the task description. (Show Details)Tue, Jan 12, 5:54 PM
ovasileva closed this task as Resolved.Tue, Jan 12, 6:00 PM