| Krinkle | |
| Jan 6 2021, 9:26 PM |
| F33996852: Screen Shot 2021-01-12 at 9.52.30 AM.png | |
| Jan 12 2021, 5:53 PM |
| F33995851: Screen Shot 2021-01-11 at 10.07.10 AM.png | |
| Jan 11 2021, 4:09 PM |
| F33989749: Screen Shot 2021-01-07 at 11.59.37 AM.png | |
| Jan 7 2021, 6:00 PM |
Seen on mediawiki.org today.
The MediaWiki:Sitenotice page is empty, but yet [dismiss] shows up everywhere.
Expected:
Observed:
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T271365#6740642 |
This seems likely caused by the surprise work on merging the feature (along wit its known tech debt) into MW core, ref T259903, T262118.
I've lef some post-merge code review at https://gerrit.wikimedia.org/r/c/mediawiki/core/+/631177. The change was high-risk and made major changes to the logic that are unexplained, likely unintended, and were not noticed during the original code review.
I'd recommend revert for now so that it can be properly reviewed, tested, and documented in a core patch for next week.
Change 654460 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] Revert "Provide native support to dismiss sitenotice in core."
Change 654461 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@wmf/1.36.0-wmf.25] Revert "Provide native support to dismiss sitenotice in core."
@Jdlrobson Can you confirm that VERSION_MAJOR is safe to revert at this time? Afaik things should fall into place, but want to make sure train conductors don't roll forward without your input on that.
Change 654460 merged by jenkins-bot:
[mediawiki/core@master] Revert "Provide native support to dismiss sitenotice in core."
Change 654461 merged by jenkins-bot:
[mediawiki/core@wmf/1.36.0-wmf.25] Revert "Provide native support to dismiss sitenotice in core."
Mentioned in SAL (#wikimedia-operations) [2021-01-07T19:53:42Z] <urbanecm@deploy1001> Synchronized php-1.36.0-wmf.25/includes/skins/: rMW59866730ea75: Revert "Provide native support to dismiss sitenotice in core." (T271365; T259903; 1/3) (duration: 01m 04s)
Mentioned in SAL (#wikimedia-operations) [2021-01-07T19:55:01Z] <urbanecm@deploy1001> Synchronized php-1.36.0-wmf.25/resources/: rMW59866730ea75: Revert "Provide native support to dismiss sitenotice in core." (T271365; T259903; 2/3) (duration: 01m 05s)
Mentioned in SAL (#wikimedia-operations) [2021-01-07T19:56:27Z] <urbanecm@deploy1001> Synchronized php-1.36.0-wmf.25/includes/DefaultSettings.php: rMW59866730ea75: Revert "Provide native support to dismiss sitenotice in core." (T271365; T259903; 3/3) (duration: 01m 03s)
The footer comment of DefaultSettings.php was incorrectly reverted. It should be restored.
We have pushed 1.36.0-wmf.25 everywhere, I have removed this task from the list of blockers.
Change 655192 had a related patch set uploaded (by Shirayuki; owner: Shirayuki):
[mediawiki/core@master] DefaultSettings: Improve custom folding and grouping
Change 655192 merged by jenkins-bot:
[mediawiki/core@master] DefaultSettings: Improve custom folding and grouping
Status: ✅ PASS
Environment: cawiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA
Test Artifact(s):
Go to any article on a production wiki (ex: https://ca.wikipedia.org/wiki/Tuc_de_la_Llan%C3%A7a)
Expected:
✅ AC1: [dismiss] link is NOT displayed
