Page MenuHomePhabricator
Create Task
Maniphest T271385

[Regression] Reply links are not working on a specific page on Dutch wiki
Closed, ResolvedPublic
Actions

Description

It seems that the reply links are not working on this page: https://nl.wikipedia.org/wiki/Overleg_gebruiker:RYasmeen_(WMF)

There is an error in the console while loading the page:
TypeError: Cannot set property 'parent' of undefined

I have looked into the following document but it seems none of the cases mentioned there matches with the page mentioned above, but I could be wrong. All of the them at-least shows a prompt mentioning the reason why it's not possible to reply, but in my case it just does not do anything after clicking on the "Reply" links.

https://www.mediawiki.org/wiki/Help:DiscussionTools/Why_can%27t_I_reply_to_this_comment%3F

Details

SubjectRepoBranchLines +/-
Fix skipping to the end of paragraph, now it considers nested tagsmediawiki/extensions/DiscussionToolsmaster+360 -45
Broken test cases for a big mess of <font> tagsmediawiki/extensions/DiscussionToolsmaster+508 -0
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Jan 7 2021, 1:00 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 7 2021, 1:00 AM
• ppelberg added a project: Editing-team (Kanban Board).Jan 7 2021, 3:02 AM
matmarex claimed this task.Jan 7 2021, 4:21 PM
matmarex removed matmarex as the assignee of this task.Jan 7 2021, 7:15 PM
matmarex subscribed.

Near the end of the page, the [reply] link for several comments appears in the wrong place, after the next comment. This indicates that the range of that comment is detected incorrectly, as if the next comment was inside those comments. This breaks various assumptions in the code and causes this exception.

These are the wrongly placed reply links, and the arrows point to where they should be:

image.png (941×2 px, 359 KB)

It seems that the code added in rEDTOd0ae6c4e445e: Skip end marker "forward" until a block tag is reached skips over entire <font>…</font> tags, ignoring the fact that they can contain block tags. This might be a more general problem with "transparent" tags.

matmarex claimed this task.Jan 8 2021, 7:41 PM
gerritbot added a comment.Jan 8 2021, 7:59 PM

Change 655122 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Broken test cases for a big mess of <font> tags

https://gerrit.wikimedia.org/r/655122

gerritbot added a project: Patch-For-Review.Jan 8 2021, 7:59 PM

Change 655123 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] [WIP] Fix skipping to the end of paragraph, now it considers nested tags

https://gerrit.wikimedia.org/r/655123

matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.Jan 8 2021, 8:04 PM
gerritbot added a comment.Jan 18 2021, 6:26 PM

Change 655122 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Broken test cases for a big mess of <font> tags

https://gerrit.wikimedia.org/r/655122

gerritbot added a comment.Jan 18 2021, 6:27 PM

Change 655123 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Fix skipping to the end of paragraph, now it considers nested tags

https://gerrit.wikimedia.org/r/655123

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Jan 18 2021, 6:50 PM
matmarex edited projects, added Editing QA; removed Patch-For-Review.
matmarex mentioned this in rEDTO0da00d44bec8: Broken test cases for a big mess of <font> tags.Jan 18 2021, 6:51 PM
matmarex mentioned this in rEDTO8f42c74985fb: Fix skipping to the end of paragraph, now it considers nested tags.
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.27; 2021-01-19).Jan 18 2021, 7:00 PM
Ryasmeen edited projects, added Verified; removed Editing QA.Jan 22 2021, 2:57 AM
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
• ppelberg closed this task as Resolved.Jan 23 2021, 2:44 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJan 23 2021, 2:44 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL