Uncaught FilterNotFoundException for non-existing filters
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Daimona
	Jan 7 2021, 3:46 PM

Description

Error message

[X-XwSgpAAEYAAEAM-lgAAAAQ] /w/index.php?title=Special:AbuseLog&wpSearchFilter=8032121121121212.1   MediaWiki\Extension\AbuseFilter\Filter\FilterNotFoundException from line 109 of /srv/mediawiki/php-1.36.0-wmf.22/extensions/AbuseFilter/includes/FilterLookup.php: Filter 8032121121121212 does not exist

Stack Trace

	#0 /srv/mediawiki/php-1.36.0-wmf.22/extensions/AbuseFilter/includes/special/SpecialAbuseLog.php(436): MediaWiki\Extension\AbuseFilter\FilterLookup->getFilter(integer, boolean)
#1 /srv/mediawiki/php-1.36.0-wmf.22/extensions/AbuseFilter/includes/special/SpecialAbuseLog.php(165): SpecialAbuseLog->showList()
#2 /srv/mediawiki/php-1.36.0-wmf.22/includes/specialpage/SpecialPage.php(645): SpecialAbuseLog->execute(NULL)
#3 /srv/mediawiki/php-1.36.0-wmf.22/includes/specialpage/SpecialPageFactory.php(1404): SpecialPage->run(NULL)
#4 /srv/mediawiki/php-1.36.0-wmf.22/includes/MediaWiki.php(310): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#5 /srv/mediawiki/php-1.36.0-wmf.22/includes/MediaWiki.php(945): MediaWiki->performRequest()
#6 /srv/mediawiki/php-1.36.0-wmf.22/includes/MediaWiki.php(548): MediaWiki->main()
#7 /srv/mediawiki/php-1.36.0-wmf.22/index.php(53): MediaWiki->run()
#8 /srv/mediawiki/php-1.36.0-wmf.22/index.php(46): wfIndexMain()
#9 /srv/mediawiki/w/index.php(3): require(string)
#10 {main}

Impact

Fatal error

Notes

Can happen for bad user input, although some hits on logstash seem kinda malicious

Details

Request ID: X-XwSgpAAEYAAEAM-lgAAAAQ
Request URL: /w/index.php?title=Special:AbuseLog&wpSearchFilter=8032121121121212.1

	Subject	Repo	Branch	Lines +/-
	Fix a bunch of fatal errors seen in production	mediawiki/extensions/AbuseFilter	wmf/1.36.0-wmf.25	+49 -24
	Fix a bunch of fatal errors seen in production	mediawiki/extensions/AbuseFilter	master	+49 -24

Customize query in gerrit

Related Objects

Mentioned In: T271433: Fatal error due to null being passed to SpecsFormatter::nameGroup
T271432: Uncaught CentralDBNotAvailableException on Special:AbuseLog
T271431: Uncaught FilterNotFoundException for non-existing filters on ViewHistory
Mentioned Here: T271431: Uncaught FilterNotFoundException for non-existing filters on ViewHistory
T271432: Uncaught CentralDBNotAvailableException on Special:AbuseLog
T271433: Fatal error due to null being passed to SpecsFormatter::nameGroup

Event Timeline

Daimona created this task.Jan 7 2021, 3:46 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 7 2021, 3:46 PM

Daimona claimed this task.Jan 7 2021, 3:46 PM

Daimona added a project: AbuseFilter.

Daimona mentioned this in T271431: Uncaught FilterNotFoundException for non-existing filters on ViewHistory.

Change 654895 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Fix a bunch of fatal errors seen in production

https://gerrit.wikimedia.org/r/654895

gerritbot added a project: Patch-For-Review.Jan 7 2021, 4:19 PM

Change 654895 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Fix a bunch of fatal errors seen in production

https://gerrit.wikimedia.org/r/654895

Daimona closed this task as Resolved.Jan 7 2021, 6:19 PM

Daimona removed a project: Patch-For-Review.

Change 654860 had a related patch set uploaded (by Reedy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@wmf/1.36.0-wmf.25] Fix a bunch of fatal errors seen in production

https://gerrit.wikimedia.org/r/654860

gerritbot added a project: Patch-For-Review.Jan 8 2021, 3:33 AM

Change 654860 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@wmf/1.36.0-wmf.25] Fix a bunch of fatal errors seen in production

https://gerrit.wikimedia.org/r/654860

Mentioned in SAL (#wikimedia-operations) [2021-01-08T15:39:52Z] <reedy@deploy1001> Synchronized php-1.36.0-wmf.25/extensions/AbuseFilter/: T271430 T271431 T271432 T271433 (duration: 01m 00s)

Stashbot mentioned this in T271433: Fatal error due to null being passed to SpecsFormatter::nameGroup.Jan 8 2021, 3:39 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 8 2021, 4:11 PM

Krinkle moved this task from Untriaged to Jan 2021 on the Wikimedia-production-error board.Jan 27 2021, 8:42 PM

Uncaught FilterNotFoundException for non-existing filtersClosed, ResolvedPublicPRODUCTION ERRORActions