Page MenuHomePhabricator
Create Task
Maniphest T271437

rename pagegenerators.GeneratorFactory.handleArg
Closed, ResolvedPublic
Actions

Description

Introduction

rename pagegenerators.GeneratorFactory.handleArg() method to handle_arg() due to PEP8 naming convention

What to do:

  • rename handleArg() method of pagegenerators.GeneratorFactory to handle_arg()
  • deprecate the old method with deprecated Decorator (from pywikibot.tools)
  • replace all occurences of this GeneratorFactory.handleArg() with the new identifier. They can be found here

Important hints

  • be aware: GeneratorFactory method is handleArg() not handleArgs() because it processes one option only
  • a similar deprecating solution can be found for handle_args()/handleArgs() function in pywikibot.bot module
  • refer our Coding Convention Guidlines

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
[cleanup] Use GeneratorFactory.handle_argpywikibot/coremaster+10 -10
Rename handleArg to handle_argpywikibot/coremaster+30 -30
Rename handleArg to handle_argpywikibot/coremaster+30 -30
[cleanup] Replace handleArg with handle_arg in pagegenerators_tests.pypywikibot/coremaster+130 -130
Renamed handleArg() method to handle_arg() in certain scriptspywikibot/coremaster+43 -38
Customize query in gerrit

Related Objects

Event Timeline

Xqt created this task.Jan 7 2021, 4:43 PM
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptJan 7 2021, 4:43 PM
Xqt triaged this task as Low priority.Jan 7 2021, 4:43 PM
Xqt updated the task description. (Show Details)
Bharatkhatri351 claimed this task.Jan 12 2021, 11:58 AM
Bharatkhatri351 added a comment.Jan 12 2021, 12:00 PM

I want to work in this issue please help me to clone repository.I cloned Pywikibot repository from gerrit and i found only these two files

image.png (768×1 px, 114 KB)

what next.
Or i have any mistake please clear

gerritbot added a comment.Jan 13 2021, 2:06 PM

Change 655900 had a related patch set uploaded (by Homeboy 445; owner: Homeboy 445):
[pywikibot/core@master] Renamed handleArg() method to handle_arg() in certain scripts

https://gerrit.wikimedia.org/r/655900

gerritbot added a project: Patch-For-Review.Jan 13 2021, 2:06 PM
gerritbot added a comment.Jan 14 2021, 4:24 PM

Change 655900 merged by jenkins-bot:
[pywikibot/core@master] Renamed handleArg() method to handle_arg() in certain scripts

https://gerrit.wikimedia.org/r/655900

Xqt mentioned this in rPWBC397dde2937c2: Renamed handleArg() method to handle_arg() in certain scripts.Jan 14 2021, 4:27 PM
Xqt closed this task as Resolved.Jan 14 2021, 5:14 PM
Xqt reassigned this task from Bharatkhatri351 to Homeboy_445.
Xqt added a subscriber: Bharatkhatri351.

Thanks Homeboy_445!

Maintenance_bot removed a project: Patch-For-Review.Jan 14 2021, 6:11 PM
Xqt reopened this task as Open.Jan 15 2021, 4:20 PM

Reopened. There are still some scripts using the deprecated handleArg() method: https://codesearch.wmcloud.org/pywikibot/?q=handleArg%5C(&i=nope&files=&excludeFiles=&repos=

Xqt removed Homeboy_445 as the assignee of this task.Jan 15 2021, 4:20 PM
Xqt updated the task description. (Show Details)
Xqt added a subscriber: Homeboy_445.
gerritbot added a comment.Jan 15 2021, 4:26 PM

Change 656445 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [cleanup] Replace handleArg with handle_arg in pagegenerators_tests.py

https://gerrit.wikimedia.org/r/656445

gerritbot added a project: Patch-For-Review.Jan 15 2021, 4:26 PM
Bharatkhatri351 claimed this task.Jan 16 2021, 9:10 AM

i have uploaded the patch please check this out
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/656537

gerritbot added a comment.Jan 16 2021, 9:15 AM

Change 656445 merged by jenkins-bot:
[pywikibot/core@master] [cleanup] Replace handleArg with handle_arg in pagegenerators_tests.py

https://gerrit.wikimedia.org/r/656445

Xqt mentioned this in rPWBC1f6d4b32aa35: [cleanup] Replace handleArg with handle_arg in pagegenerators_tests.py.Jan 16 2021, 9:34 AM
gerritbot added a comment.Jan 16 2021, 9:43 AM

Change 656537 had a related patch set uploaded (by Aklapper; owner: Bharatkhatri):
[pywikibot/core@master] Rename handleArg to handle_arg

https://gerrit.wikimedia.org/r/656537

gerritbot added a comment.Jan 16 2021, 1:18 PM

Change 656558 had a related patch set uploaded (by Bharatkhatri; owner: Bharatkhatri):
[pywikibot/core@master] Rename handleArg to handle_arg

https://gerrit.wikimedia.org/r/656558

gerritbot added a comment.Jan 16 2021, 4:51 PM

Change 656575 had a related patch set uploaded (by Bharatkhatri; owner: Bharatkhatri):
[pywikibot/core@master] Rename handleArg to handle_arg

https://gerrit.wikimedia.org/r/656575

Xqt closed this task as Resolved.Jan 16 2021, 5:15 PM
Xqt removed Bharatkhatri351 as the assignee of this task.
Xqt updated the task description. (Show Details)
gerritbot added a comment.Jan 16 2021, 5:17 PM

Change 656558 merged by jenkins-bot:
[pywikibot/core@master] Rename handleArg to handle_arg

https://gerrit.wikimedia.org/r/656558

gerritbot added a comment.Jan 16 2021, 5:17 PM

Change 656575 abandoned by Xqt:
[pywikibot/core@master] Rename handleArg to handle_arg

Reason:
Duplicate

https://gerrit.wikimedia.org/r/656575

Bharatkhatri351 mentioned this in rPWBCfd1bebfee9e3: Rename handleArg to handle_arg.Jan 16 2021, 5:27 PM
Xqt reopened this task as Open.Feb 4 2021, 10:31 AM

There are few remaining issues, See https://codesearch.wmcloud.org/pywikibot/?q=gf%5C.handleArg&i=nope&files=&excludeFiles=&repos=

Xqt updated the task description. (Show Details)Feb 4 2021, 10:32 AM
Xqt removed a project: Patch-For-Review.Feb 4 2021, 8:02 PM
Paucabot subscribed.Feb 5 2021, 6:36 AM
Kemsguy subscribed.Feb 9 2021, 2:33 PM
Kemsguy unsubscribed.
Uditdesai2206 claimed this task.Feb 11 2021, 5:00 AM
Uditdesai2206 removed Uditdesai2206 as the assignee of this task.Feb 17 2021, 7:53 PM
Uditdesai2206 subscribed.
gerritbot added a comment.Mar 1 2021, 9:38 AM

Change 667542 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [cleanup] Use GeneratorFactory.handle_arg

https://gerrit.wikimedia.org/r/667542

gerritbot added a project: Patch-For-Review.Mar 1 2021, 9:38 AM
Xqt closed this task as Resolved.Mar 1 2021, 9:41 AM
Xqt claimed this task.
Xqt removed Xqt as the assignee of this task.
gerritbot added a comment.Mar 1 2021, 9:43 AM

Change 667542 merged by jenkins-bot:
[pywikibot/core@master] [cleanup] Use GeneratorFactory.handle_arg

https://gerrit.wikimedia.org/r/667542

Xqt mentioned this in rPWBC3eeaa7fac643: [cleanup] Use GeneratorFactory.handle_arg.Mar 1 2021, 10:05 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits