Page MenuHomePhabricator
Create Task
Maniphest T271458

RevisionRecord should use Authority for permission checks
Closed, ResolvedPublic
Actions

Description

RevisionRecord::getSlot, RevisionRecord::getUser and RevisionRecord::getComment should accept Authority as $performer argument

Details

SubjectRepoBranchLines +/-
Convert RevisionRecord to Authority and PageIdentitymediawiki/coremaster+379 -300
Do not mock User in TextExtractorTest.mediawiki/extensions/AbuseFiltermaster+1 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Pchelolo created this task.Jan 7 2021, 8:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 7 2021, 8:23 PM
• Pchelolo moved this task from Unsorted pile to Authority pile on the Platform Team Workboards (MW Expedition) board.Jan 7 2021, 8:33 PM
JJMC89 moved this task from Backlog to Other on the MediaWiki-User-management board.Jan 7 2021, 8:37 PM
daniel mentioned this in T271300: Stop using the global service locator in RevisionRecord::userCanBitfield.Jan 7 2021, 10:00 PM
daniel added a subtask: T271300: Stop using the global service locator in RevisionRecord::userCanBitfield.
• Pchelolo claimed this task.Jan 15 2021, 4:03 PM
• Pchelolo moved this task from Authority pile to Blocked on the Platform Team Workboards (MW Expedition) board.
• Pchelolo triaged this task as High priority.Jan 19 2021, 6:17 PM
gerritbot added a comment.Jan 20 2021, 3:32 PM

Change 657361 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/AbuseFilter@master] Do not mock User in TextExtractorTest.

https://gerrit.wikimedia.org/r/657361

gerritbot added a project: Patch-For-Review.Jan 20 2021, 3:32 PM

Change 654511 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] Make RevisionRecord take Authority as actor

https://gerrit.wikimedia.org/r/654511

gerritbot added a comment.Jan 20 2021, 5:06 PM

Change 657361 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Do not mock User in TextExtractorTest.

https://gerrit.wikimedia.org/r/657361

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.28; 2021-01-26).Jan 20 2021, 6:00 PM
• Pchelolo moved this task from Blocked to Waiting for Review on the Platform Team Workboards (MW Expedition) board.Jan 21 2021, 8:49 PM
gerritbot added a comment.Jan 21 2021, 9:46 PM

Change 654511 merged by jenkins-bot:
[mediawiki/core@master] Convert RevisionRecord to Authority and PageIdentity

https://gerrit.wikimedia.org/r/654511

• Pchelolo moved this task from Waiting for Review to On the train on the Platform Team Workboards (MW Expedition) board.Jan 21 2021, 10:30 PM
• Pchelolo closed this task as Resolved.Feb 1 2021, 6:36 PM
Daimona closed subtask T271300: Stop using the global service locator in RevisionRecord::userCanBitfield as Resolved.Feb 1 2021, 6:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits