User should implement Authority
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Pchelolo
	Jan 7 2021, 8:26 PM

Project Tags

Referenced Files

None

Subscribers

• Aklapper

• Pchelolo

Description

User class should implement Authority.

In order to construct WebRequestAuthority we can WebRequest and PermissionManager (or AuthorityFactory) from global state. The Authority methods on User should be marked @unstable for now.

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Make User implement Authority	Ppchelko	mediawiki/core	master	+169 -87
	Don't pass empty permissions to Authority::isAllowed	Ppchelko	mediawiki/extensions/Gadgets	master	+4 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T218674 User::getRights() applies session rights restrictions to non-session users
Resolved	None	T180888 All permission checks should be able to return a custom error message
Open	None	T231930 Introduce Authority objects to represent the user performing a given action
Invalid	None	T262296 Authority [high effort]
Resolved	• Pchelolo	T261963 Spike to explore Authority concept, implementation, and migration
Resolved	• Pchelolo	T271459 User should implement Authority

Event Timeline

• Pchelolo created this task.Jan 7 2021, 8:26 PM

Restricted Application added a subscriber: • Aklapper. · View Herald TranscriptJan 7 2021, 8:26 PM

• Pchelolo moved this task from Unsorted pile to Authority pile on the Platform Team Workboards (MW Expedition) board.Jan 7 2021, 8:33 PM

JJMC89 moved this task from Backlog to Other on the MediaWiki-User-management board.Jan 7 2021, 8:35 PM

Change 654926 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] Make User implement Authority

https://gerrit.wikimedia.org/r/654926

gerritbot added a project: Patch-For-Review.Jan 7 2021, 8:58 PM

• Pchelolo claimed this task.Jan 15 2021, 4:02 PM

• Pchelolo moved this task from Authority pile to Waiting for Review on the Platform Team Workboards (MW Expedition) board.

• Pchelolo moved this task from Waiting for Review to Doing on the Platform Team Workboards (MW Expedition) board.Jan 19 2021, 6:14 PM

• Pchelolo triaged this task as High priority.Jan 19 2021, 6:16 PM

Change 657192 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/Gadgets@master] Don't pass empty permissions to Authority::isAllowed

https://gerrit.wikimedia.org/r/657192

Change 657192 merged by jenkins-bot:
[mediawiki/extensions/Gadgets@master] Don't pass empty permissions to Authority::isAllowed

https://gerrit.wikimedia.org/r/657192

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.28; 2021-01-26).Jan 19 2021, 11:00 PM

• Pchelolo moved this task from Doing to Waiting for Review on the Platform Team Workboards (MW Expedition) board.Jan 20 2021, 12:02 AM

Change 654926 merged by jenkins-bot:
[mediawiki/core@master] Make User implement Authority

https://gerrit.wikimedia.org/r/654926

Maintenance_bot removed a project: Patch-For-Review.Jan 20 2021, 2:10 PM

• Pchelolo moved this task from Waiting for Review to On the train on the Platform Team Workboards (MW Expedition) board.Jan 20 2021, 2:29 PM

• Pchelolo closed this task as Resolved.Feb 1 2021, 6:37 PM