PermissionsError should be instantiatable with PermissionStatus returned by Authority
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Pchelolo
	Jan 8 2021, 4:43 AM

Description

PermissionError constructor now takes an array of permission errors. Instead it should be able to take the PermissionStatus from Authority directly.

Might want to base it on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/666239/4/includes/Permissions/PermissionStatus.php for PermissionStatus::toLegacyErrorArray

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+56 -2	Allow PermissionError to be constructed with a PermissionStatus

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T218674 User::getRights() applies session rights restrictions to non-session users
Open	None	T180888 All permission checks should be able to return a custom error message
Open	None	T231930 Introduce Authority objects to represent the user performing a given action
Resolved	CCicalese_WMF	T271504 PermissionsError should be instantiatable with PermissionStatus returned by Authority

Event Timeline

• Pchelolo created this task.Jan 8 2021, 4:43 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 8 2021, 4:43 AM

JJMC89 moved this task from Backlog to Other on the MediaWiki-User-management board.Jan 8 2021, 9:29 PM

• Pchelolo moved this task from Unsorted pile to Authority pile on the Platform Team Workboards (MW Expedition) board.Jan 11 2021, 5:52 PM

This will depend on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/654306

• Pchelolo triaged this task as Low priority.Jan 19 2021, 6:28 PM

We need this to convert special pages to Authority.

• Pchelolo assigned this task to CCicalese_WMF.Feb 23 2021, 6:06 PM

• Pchelolo updated the task description. (Show Details)

CCicalese_WMF updated the task description. (Show Details)Feb 25 2021, 4:51 AM

Change 667693 had a related patch set uploaded (by Cicalese; owner: Cicalese):
[mediawiki/core@master] Allow PermissionError to be constructed with a PermissionStatus

https://gerrit.wikimedia.org/r/667693

gerritbot added a project: Patch-For-Review.Mar 1 2021, 7:25 PM

Change 667693 merged by jenkins-bot:
[mediawiki/core@master] Allow PermissionError to be constructed with a PermissionStatus

https://gerrit.wikimedia.org/r/667693

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.33; 2021-03-02).Mar 1 2021, 11:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 1 2021, 11:10 PM

CCicalese_WMF moved this task from Authority pile to On the train on the Platform Team Workboards (MW Expedition) board.Mar 2 2021, 6:39 PM

• Pchelolo closed this task as Resolved.Mar 5 2021, 6:33 PM

• Pchelolo reopened this task as Open.

• Pchelolo closed this task as Resolved.