Page MenuHomePhabricator

Wrong headline levels on Special:Gadgets
Closed, ResolvedPublic

Description

Author: a.d.bergi

Description:
Hello, when there is a headline defined in MediaWiki:Gadgets-definition ([[de:MediaWiki:Gadgets-definition|de]]) supposed to be of level 2 (==), it shows up as a level 1 headline at Special:Preferences.
If it is not meant to be enabled choose the level, it anyway should be of level 2 as the first-level-headline is "Preferences".


Version: unspecified
Severity: normal

Details

Reference
bz25152

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:18 PM
bzimport set Reference to bz25152.
bzimport added a subscriber: Unknown Object (MLST).

Caused by http://git.wikimedia.org/blob/mediawiki%2Fcore.git/099d9cf764d81fe4c0890201e77d978a762564b1/includes%2Fhtmlform%2FHTMLMultiSelectField.php#L44

Would anyone be able to comment on whether it's ok to simply change to h2? It's so buried, I have no clue what it's used for, but in reality there should only ever be a single h1 on the page anyway.

Caused by http://git.wikimedia.org/blob/mediawiki%2Fcore.git/099d9cf764d81fe4c0890201e77d978a762564b1/includes%2Fhtmlform%2FHTMLMultiSelectField.php#L44

Would anyone be able to comment on whether it's ok to simply change to h2? It's so buried, I have no clue what it's used for, but in reality there should only ever be a single h1 on the page anyway.

That is code in Core, adding that project.

Krinkle claimed this task.
Krinkle subscribed.

It now uses an HTML fieldset legend for each section.

https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-gadgets

Krinkle renamed this task from wrong headline levels to Wrong headline levels on Special:Gadgets.Apr 18 2021, 8:50 PM