Page MenuHomePhabricator

Excessive queries from vscode-phabricator
Closed, ResolvedPublic

Description

We have noticed that a vscode plugin which has a agent header of vscode-phabricator makes multiple requests per second to phabricator when boot strapping the user database. The issues has been reported upstream however no fix is currently available. As this has caused noticeable user issues to other phabiracator users we have taken the decision to implement rate limiting for this plugin.

This task is a public tracking tasks to provide more information to users who may hit this rate limit.

Related Objects

StatusSubtypeAssignedTask
Resolvedjbond

Event Timeline

jbond created this task.Fri, Jan 8, 11:03 AM

Change 650494 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] varnish: ratelimit vscode-phabricator plugin

https://gerrit.wikimedia.org/r/650494

jbond renamed this task from Excessive queries ffrom vscode-phabricator to Excessive queries from vscode-phabricator.Fri, Jan 8, 12:11 PM
jbond triaged this task as Medium priority.
jbond added a project: Traffic.

Mentioned in SAL (#wikimedia-operations) [2021-01-11T11:10:19Z] <jbond42> push change to ratelimit vscode-phabricator - T271528

Change 650494 merged by Jbond:
[operations/puppet@production] varnish: ratelimit vscode-phabricator plugin

https://gerrit.wikimedia.org/r/650494

Patch has been merged. Is there more to do or can this task be resolved?

Patch has been merged. Is there more to do or can this task be resolved?

@Aklapper This task is here for users who may hit the rate limit. An error message will be displayed pointing them to this task to et more information or ask questions. im not sure if it makes senses to close this or put it into some other state. I don't have a strong opinion as to which state as long as it remains public and users can sign up and ask questions , thx

Aklapper closed this task as Resolved.EditedThu, Jan 14, 12:56 PM

:-/ Well, Phab is not a support desk for general questions; it's a task tracking system to plan work (and tasks have a status field, so neverending tasks should not be created). Closing.