Page MenuHomePhabricator
Create Task
Maniphest T271541

Remove dependency on Maven for CI for Java projects and align Jenkins job configuration.
Closed, ResolvedPublic
Actions

Description

As a developer, I want a consistent way to build projects to reduce the cognitive load and to reduce the risk of having CI behave in different way than dev environment.

Most or our Java projects already use Maven Wrapper. Adding it to the few projects which don't have it yet would allow to remove the dependency on Maven in Jenkins and ensure that the same version of Maven is used for all phases of the project development.

This would also allow simplification of the "maven-java8-docker" Jenkins job, by removing the need to have a custom shell wrapper and have a more explicit Maven CLI.

Details

SubjectRepoBranchLines +/-
jjb: do mount src directory in maven jobsintegration/configmaster+1 -1
jjb: do create src directory in maven jobsintegration/configmaster+1 -0
Remove dependency on Maven binaries and wrapper script.integration/configmaster+26 -5
Adding Maven wrapper to conform to how other projects are built.analytics/wmde/toolkit-analyzermaster+613 -2
Adding Maven wrapper to conform to how other projects are built.search/xgboostmaster+611 -0
Adding Maven wrapper to conform to how other projects are built.search/MjoLniRmaster+612 -1
Customize query in gerrit

Event Timeline

Gehel created this task.Jan 8 2021, 1:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 8 2021, 1:34 PM
Gehel moved this task from Incoming to In Progress on the Discovery-Search (Current work) board.Jan 8 2021, 1:34 PM
gerritbot added a comment.Jan 8 2021, 1:34 PM

Change 655052 had a related patch set uploaded (by Gehel; owner: Gehel):
[analytics/wmde/toolkit-analyzer@master] Adding Maven wrapper to conform to how other projects are built.

https://gerrit.wikimedia.org/r/655052

gerritbot added a project: Patch-For-Review.Jan 8 2021, 1:34 PM

Change 651791 had a related patch set uploaded (by Gehel; owner: Gehel):
[integration/config@master] Remove dependency on Maven binaries and wrapper script.

https://gerrit.wikimedia.org/r/651791

gerritbot added a comment.Jan 8 2021, 1:38 PM

Change 655055 had a related patch set uploaded (by Gehel; owner: Gehel):
[search/MjoLniR@master] Adding Maven wrapper to conform to how other projects are built.

https://gerrit.wikimedia.org/r/655055

gerritbot added a comment.Jan 8 2021, 2:01 PM

Change 655062 had a related patch set uploaded (by Gehel; owner: Gehel):
[search/xgboost@master] Adding Maven wrapper to conform to how other projects are built.

https://gerrit.wikimedia.org/r/655062

Gehel added a subscriber: Addshore.Jan 8 2021, 2:13 PM
gerritbot added a comment.Jan 11 2021, 9:50 AM

Change 655055 merged by jenkins-bot:
[search/MjoLniR@master] Adding Maven wrapper to conform to how other projects are built.

https://gerrit.wikimedia.org/r/655055

gerritbot added a comment.Jan 25 2021, 3:52 PM

Change 655062 merged by Gehel:
[search/xgboost@master] Adding Maven wrapper to conform to how other projects are built.

https://gerrit.wikimedia.org/r/655062

thcipriani edited projects, added Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO; removed Release-Engineering-Team.Jan 26 2021, 5:09 PM
thcipriani moved this task from Should be empty (use Release-Engineering-Team) to Watching/External on the Release-Engineering-Team-TODO board.
gerritbot added a comment.Jan 29 2021, 3:32 PM

Change 655052 merged by jenkins-bot:
[analytics/wmde/toolkit-analyzer@master] Adding Maven wrapper to conform to how other projects are built.

https://gerrit.wikimedia.org/r/655052

gerritbot added a comment.Feb 19 2021, 1:50 PM

Change 651791 merged by jenkins-bot:
[integration/config@master] Remove dependency on Maven binaries and wrapper script.

https://gerrit.wikimedia.org/r/651791

gerritbot added a comment.Feb 19 2021, 1:59 PM

Change 665327 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] jjb: do create src directory in maven jobs

https://gerrit.wikimedia.org/r/665327

gerritbot added a comment.Feb 19 2021, 2:04 PM

Change 665329 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] jjb: do mount src directory in maven jobs

https://gerrit.wikimedia.org/r/665329

Gehel moved this task from In Progress to Needs Reporting on the Discovery-Search (Current work) board.Feb 19 2021, 3:05 PM
Gehel added a subscriber: hashar.

Configuration change has been deployed, including adding maven wrapper to most java projects.

Gearman CI is now probably broken, but after discussion with @hashar, we don't care too much since it is unlikely that we will ever build it again. If that happens, we'll fix it then.

gerritbot added a comment.Feb 19 2021, 3:48 PM

Change 665327 merged by jenkins-bot:
[integration/config@master] jjb: do create src directory in maven jobs

https://gerrit.wikimedia.org/r/665327

gerritbot added a comment.Feb 19 2021, 3:48 PM

Change 665329 merged by jenkins-bot:
[integration/config@master] jjb: do mount src directory in maven jobs

https://gerrit.wikimedia.org/r/665329

Gehel closed this task as Resolved.Feb 24 2021, 1:27 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL