Page MenuHomePhabricator

Test, pass, release, and upgrade all home-grown PHP libraries for MediaWiki on PHP 8.0
Closed, ResolvedPublic

Description

Outstanding, as of 2021-01-11:

Details

ProjectBranchLines +/-Subject
mediawiki/libs/Equivsetmaster+16 -4
mediawiki/vendormaster+62 -41
mediawiki/coremaster+2 -1
mediawiki/coremaster+2 -1
mediawiki/coremaster+2 -1
mediawiki/coremaster+2 -2
mediawiki/vendormaster+34 -33
mediawiki/vendormaster+35 -33
mediawiki/vendormaster+22 -30
mediawiki/vendormaster+19 -19
mediawiki/coremaster+2 -2
mediawiki/libs/IPUtilsmaster+1 -1
mediawiki/vendormaster+24 -23
mediawiki/vendormaster+63 -43
php-session-serializermaster+1 -1
mediawiki/libs/XMPReadermaster+1 -1
IPSetmaster+1 -1
css-sanitizermaster+1 -1
at-easemaster+14 -0
mediawiki/coremaster+2 -1
mediawiki/vendormaster+192 -92
mediawiki/coremaster+2 -2
mediawiki/vendormaster+37 -20
mediawiki/coremaster+2 -1
mediawiki/vendormaster+45 -51
mediawiki/libs/RemexHtmlmaster+3 -1
mediawiki/vendormaster+36 -33
integration/configmaster+1 -1
integration/configmaster+1 -1
mediawiki/libs/Zestmaster+2 -2
integration/configmaster+1 -1
mediawiki/libs/RemexHtmlmaster+59 -26
integration/configmaster+1 -1
integration/configmaster+1 -1
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 655379 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[integration/config@master] Make PHP 8 tests voting for mediawiki/libs/alea

https://gerrit.wikimedia.org/r/655379

Change 655379 merged by jenkins-bot:
[integration/config@master] Make PHP 8 tests voting for mediawiki/libs/alea

https://gerrit.wikimedia.org/r/655379

Notes on skipped libraries:

  • Alea's last release, 0.9.2, was from April 2020. Although the last part of passing on PHP 8.0 was only merged a few days ago, none of those changes should impact the actually running code. Hopefully.
  • Shellbox isn't used yet, so by definition it'll be fine when they finally work out how. :-)

Change 655535 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/libs/RemexHtml@master] Release 2.2.1

https://gerrit.wikimedia.org/r/655535

Change 655536 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/vendor@master] Upgrade wikimedia/equivset from 1.4.0 to 1.4.1

https://gerrit.wikimedia.org/r/655536

Change 655536 merged by jenkins-bot:
[mediawiki/vendor@master] Upgrade wikimedia/equivset from 1.4.0 to 1.4.1

https://gerrit.wikimedia.org/r/655536

Change 655535 merged by jenkins-bot:
[mediawiki/libs/RemexHtml@master] Release 2.2.1

https://gerrit.wikimedia.org/r/655535

Change 655701 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/vendor@master] Upgrade wikimedia/remex-html from 2.2.0 to 2.2.1

https://gerrit.wikimedia.org/r/655701

Change 655702 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Upgrade wikimedia/remex-html from 2.2.0 to 2.2.1

https://gerrit.wikimedia.org/r/655702

Change 655701 merged by jenkins-bot:
[mediawiki/vendor@master] Upgrade wikimedia/remex-html from 2.2.0 to 2.2.1

https://gerrit.wikimedia.org/r/655701

Change 655702 merged by jenkins-bot:
[mediawiki/core@master] Upgrade wikimedia/remex-html from 2.2.0 to 2.2.1

https://gerrit.wikimedia.org/r/655702

Change 657896 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/vendor@master] Upgrade wikimedia/html-formatter from 2.0.0 to 2.0.1

https://gerrit.wikimedia.org/r/657896

Change 657897 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Upgrade wikimedia/html-formatter from 2.0.0 to 2.0.1

https://gerrit.wikimedia.org/r/657897

Change 657896 merged by jenkins-bot:
[mediawiki/vendor@master] Upgrade wikimedia/html-formatter from 2.0.0 to 2.0.1

https://gerrit.wikimedia.org/r/657896

Change 657897 merged by jenkins-bot:
[mediawiki/core@master] Upgrade wikimedia/html-formatter from 2.0.0 to 2.0.1

https://gerrit.wikimedia.org/r/657897

Once https://gerrit.wikimedia.org/r/c/mediawiki/libs/Zest/+/655699 is merged I can tag it as 1.1.4, make a set of pull throughs, and this task will be Resolved.

A new release of AtEase is necessary to include https://gerrit.wikimedia.org/r/c/at-ease/+/598169 which helps on getting away the "Failed asserting that exception of type "PHPUnit\Framework\Error\Deprecated" errors from experimental run

I have created a patch set to repair the one test case in core which throws on php8 - you can test with https://gerrit.wikimedia.org/r/c/mediawiki/core/+/662089 - no one of the errors seeing on other experimental runs - https://integration.wikimedia.org/ci/job/mediawiki-quibble-composer-mysql-php80-docker/12/console

Change 658740 had a related patch set uploaded (by Jforrester; owner: Reedy):
[mediawiki/vendor@master] Updating wikimedia/xmp-reader (0.7.0 => 0.8.0)

https://gerrit.wikimedia.org/r/658740

Change 658741 had a related patch set uploaded (by Jforrester; owner: Reedy):
[mediawiki/core@master] Updating wikimedia/xmp-reader (0.7.0 => 0.8.0)

https://gerrit.wikimedia.org/r/658741

Just a note: When all the listed packages are backported to REL1_35 (T266583), than also wikimedia/less.php needs backport - https://gerrit.wikimedia.org/r/c/mediawiki/core/+/648331/

Change 658740 merged by jenkins-bot:
[mediawiki/vendor@master] Updating wikimedia/xmp-reader (0.7.0 => 0.8.0)

https://gerrit.wikimedia.org/r/658740

Change 658741 merged by jenkins-bot:
[mediawiki/core@master] Updating wikimedia/xmp-reader (0.7.0 => 0.8.0)

https://gerrit.wikimedia.org/r/658741

Change 667352 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[at-ease@master] Write changelog for 2.1.0 release

https://gerrit.wikimedia.org/r/667352

Change 667352 merged by jenkins-bot:
[at-ease@master] Write changelog for 2.1.0 release

https://gerrit.wikimedia.org/r/667352

Change 673727 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/vendor@master] Updating wikimedia/zest-css (1.1.3 => 1.1.4)

https://gerrit.wikimedia.org/r/673727

Change 673746 had a related patch set uploaded (by Reedy; owner: Reedy):
[css-sanitizer@master] Relax wikimedia/at-ease

https://gerrit.wikimedia.org/r/673746

Change 673746 had a related patch set uploaded (by Reedy; owner: Reedy):
[css-sanitizer@master] Relax wikimedia/at-ease

https://gerrit.wikimedia.org/r/673746

Going to need this (and a release) to upgrade at-ease...

Change 673747 had a related patch set uploaded (by Reedy; owner: Reedy):
[IPSet@master] Relax wikimedia/at-ease

https://gerrit.wikimedia.org/r/673747

Change 673748 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/libs/XMPReader@master] Relax wikimedia/at-ease

https://gerrit.wikimedia.org/r/673748

Change 673749 had a related patch set uploaded (by Reedy; owner: Reedy):
[php-session-serializer@master] Relax wikimedia/at-ease

https://gerrit.wikimedia.org/r/673749

Change 673746 merged by jenkins-bot:
[css-sanitizer@master] Relax wikimedia/at-ease to ^2.0.0

https://gerrit.wikimedia.org/r/673746

Change 673747 merged by jenkins-bot:
[IPSet@master] Relax wikimedia/at-ease to ^2.0.0

https://gerrit.wikimedia.org/r/673747

Change 673748 merged by jenkins-bot:
[mediawiki/libs/XMPReader@master] Relax wikimedia/at-ease to ^2.0.0

https://gerrit.wikimedia.org/r/673748

Change 673749 merged by jenkins-bot:
[php-session-serializer@master] Relax wikimedia/at-ease to ^2.0.0

https://gerrit.wikimedia.org/r/673749

Change 673727 merged by jenkins-bot:
[mediawiki/vendor@master] Updating wikimedia/zest-css (1.1.3 => 1.1.4)

https://gerrit.wikimedia.org/r/673727

Change 673780 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/vendor@master] Updating wikimedia/xmp-reader (0.8.0 => 0.8.1)

https://gerrit.wikimedia.org/r/673780

Change 673781 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/vendor@master] Updating wikimedia/css-sanitizer (v3.0.1 => v3.0.2

https://gerrit.wikimedia.org/r/673781

Change 673782 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Updating wikimedia/xmp-reader (0.8.0 => 0.8.1)

https://gerrit.wikimedia.org/r/673782

Change 673789 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/libs/IPUtils@master] Allow wikimedia/ip-set 3.0.0

https://gerrit.wikimedia.org/r/673789

Change 673789 merged by jenkins-bot:
[mediawiki/libs/IPUtils@master] Allow wikimedia/ip-set ^3.0.0

https://gerrit.wikimedia.org/r/673789

Change 673780 merged by jenkins-bot:
[mediawiki/vendor@master] Updating wikimedia/xmp-reader (0.8.0 => 0.8.1)

https://gerrit.wikimedia.org/r/673780

Change 673782 merged by jenkins-bot:
[mediawiki/core@master] Updating wikimedia/xmp-reader (0.8.0 => 0.8.1)

https://gerrit.wikimedia.org/r/673782

Change 673817 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/vendor@master] Updating wikimedia/ip-utils (3.0.1 => 3.0.2)

https://gerrit.wikimedia.org/r/673817

Change 673818 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/vendor@master] Updating wikimedia/ip-set (2.1.0 => 3.0.0)

https://gerrit.wikimedia.org/r/673818

Change 673819 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Updating wikimedia/ip-utils (3.0.1 => 3.0.2)

https://gerrit.wikimedia.org/r/673819

Change 673820 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Updating wikimedia/ip-set (2.1.0 => 3.0.0)

https://gerrit.wikimedia.org/r/673820

Change 673821 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/vendor@master] Updating wikimedia/php-session-serializer (v1.0.7 => v2.0.0)

https://gerrit.wikimedia.org/r/673821

Change 673822 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Updating wikimedia/php-session-serializer (v1.0.7 => v2.0.0)

https://gerrit.wikimedia.org/r/673822

Change 673823 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/vendor@master] Updating wikimedia/at-ease (v2.0.0 => v2.1.0)

https://gerrit.wikimedia.org/r/673823

Change 673824 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Updating wikimedia/at-ease (v2.0.0 => v2.1.0)

https://gerrit.wikimedia.org/r/673824

Change 673781 merged by jenkins-bot:
[mediawiki/vendor@master] Updating wikimedia/css-sanitizer (v3.0.1 => v3.0.2)

https://gerrit.wikimedia.org/r/673781

Change 673817 merged by jenkins-bot:
[mediawiki/vendor@master] Updating wikimedia/ip-utils (3.0.1 => 3.0.2)

https://gerrit.wikimedia.org/r/673817

Change 673819 merged by jenkins-bot:
[mediawiki/core@master] Updating wikimedia/ip-utils (3.0.1 => 3.0.2)

https://gerrit.wikimedia.org/r/673819

Change 673818 merged by jenkins-bot:
[mediawiki/vendor@master] Updating wikimedia/ip-set (2.1.0 => 3.0.0)

https://gerrit.wikimedia.org/r/673818

Change 673820 merged by jenkins-bot:
[mediawiki/core@master] Updating wikimedia/ip-set (2.1.0 => 3.0.0)

https://gerrit.wikimedia.org/r/673820

Change 673821 merged by jenkins-bot:
[mediawiki/vendor@master] Updating wikimedia/php-session-serializer (v1.0.7 => v2.0.0)

https://gerrit.wikimedia.org/r/673821

Change 673823 merged by jenkins-bot:
[mediawiki/vendor@master] Updating wikimedia/at-ease (v2.0.0 => v2.1.0)

https://gerrit.wikimedia.org/r/673823

Change 673822 merged by jenkins-bot:
[mediawiki/core@master] Updating wikimedia/php-session-serializer (v1.0.7 => v2.0.0)

https://gerrit.wikimedia.org/r/673822

Change 673824 merged by jenkins-bot:
[mediawiki/core@master] Updating wikimedia/at-ease (v2.0.0 => v2.1.0)

https://gerrit.wikimedia.org/r/673824

Jdforrester-WMF assigned this task to Reedy.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF updated the task description. (Show Details)

Do we know if we need any MW-1.35-release backports? I know, it'd be a different task, but I'm guessing a few might be needed...

Do we know if we need any MW-1.35-release backports? I know, it'd be a different task, but I'm guessing a few might be needed...

That's T274971: Confirm all composer dependencies have PHP 8.0 support in the REL1_35 branch and enforce so we don't regress, yeah. Not sure which we need for the tarball.