Page MenuHomePhabricator

Plain external links are now very purple in Timeless
Closed, ResolvedPublic

Description

On enwiki, and probably a bunch of others, the plainlinks class is used to make external links look similar to internal links, such as for presenting links to a redirect page using redirect=no in the url, or other url parameters such as section=new. Something changed recently, because today I noticed they were being presented in a purple colour in Timeless instead of blue, check out the difference in the shortcut links at the top of the page for WP:VPT with what Timeless is currently showing, compared to that page with Vector and with monobook and with minerva. (I also think the external interwiki links were also somewhat blueish before... don't quite remember)

According to my browser's DOM inspector, there's a css rule

.mw-parser-output a.extiw, .mw-parser-output a.extiw:active,
.mw-parser-output a.external {
    color: #7766bb;
}

that's overriding another rule

.mw-parser-output a.external {
    color: #36b;
}

(both coming from load.php)
Disabling that first rule gives the expected result, that Timeless used to show until recently (as far as I recall).

Event Timeline

Here's the diff where @Isarra introduced the purple https://gerrit.wikimedia.org/r/c/mediawiki/skins/Timeless/+/649727/2/resources/screen-common.less (patch set), deployed as part of MediaWiki 1.36.0-wmf.25 a few days ago.

This was really starting to annoy me, so I added this code to my global.css on meta to restore the blues.

I really thought for days that all those links had been clicked by me, so they are appearing purple.

Change 670600 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/Timeless@master] Unpurplify external links

https://gerrit.wikimedia.org/r/670600

Sorry, guys, this was really throwing me off too, but I was just too tired to do anything about it...

Hopefully this new colour will, er, work better. For all of us.

Change 670600 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Unpurplify external links

https://gerrit.wikimedia.org/r/670600

Izno assigned this task to Isarra.