Page MenuHomePhabricator

Example Skin: Your skin is incompatible with VisualEditor.
Closed, InvalidPublicBUG REPORT

Description

Steps to Reproduce:
  1. Install MediaWiki 1.35.1
  2. Download Example Skin from Github (https://github.com/wikimedia/mediawiki-skins-Example)
  3. Install the skin and set as default
  4. visit Main page of the Wiki
  5. Check the browser console and you will see the following error
Your skin is incompatible with VisualEditor. See <https://www.mediawiki.org/wiki/VisualEditor/Skin_requirements> for the requirements. 
load.php?lang=en&modules=ext.visualEditor.core.utils.parsing|ext.visualEditor.desktopArticleTarget.init|ext.visualEditor.progressBarWidget%2CsupportCheck%2CtargetLoader%2CtempWikitextEditorWidget%2Ctrack%2Cve&skin=example&version=3gs2u:27
Actual Results:

I assume the search box should not be located near footer area.

Screenshot_2021-01-11 Editing Main Page - MediaWikiBootstrap.png (937×1 px, 46 KB)

Expected Results:

Visually decent looking skin. But if the attached screenshot is the way it is then I am wrong and there is no bug. As I could not find any demo/ screenshot of this skin so I could not compare.

Event Timeline

Jdlrobson added a subscriber: Jdlrobson.

I'm not sure what the call to skins is inthis situation, but it's not a problem with the Example skin. My understanding is VisualEditor is only officially supporting Vector.

ppelberg added a subscriber: ppelberg.

I'm not sure what the call to skins is inthis situation, but it's not a problem with the Example skin. My understanding is VisualEditor is only officially supporting Vector.

Thank you for commenting, @Jdlrobson. Adding a bit more detail, the visual editor will technically support any skin that meets the requirements listed here: https://www.mediawiki.org/wiki/Extension:VisualEditor/Skin_requirements.

As for this particular issue, we do not have the capacity right now to investigate this issue.

Jdlrobson claimed this task.

Install MediaWiki 1.35.1

Sorry I hadn't noticed this part of the steps.

The master/1.36 candidate version of the Example skin meets the criteria of VE and is compatible with the master/1.36 candidate of VisualEditor. If you want to use Example skin you need to check out the origin/REL1_35 branch.

Jdlrobson changed the task status from Resolved to Invalid.Jan 12 2021, 4:12 PM

@Jdlrobson thank you for looking into the issue.

From the other bugs and conversations from the mediawiki support now i know that MW 1.35.1 stable is not usable for skin development. I will try to use 1.36 from now on.

During development, it's a lot easier if you use the development branch (master) for everything. It's possible to add compatibility to 1.35 in new skins, and we do so in many skins, but that requires a little additional work.

Using 1.36 helps us tease out problems and improve everyone's experience with the next release by using the most up to date APIs and code.

Thanks. As it was not mentioned at the time i started the skin development I started to use a stable release.

My 1.36 installation failed as well ( T271734), then I came to know about T270027 and it is a low priority task I assume it will not be solved soon. Already one month gone and it still exists.