No longer able to change visibility of hits from details view
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	DannyS712
	Jan 11 2021, 12:12 AM

Description

Steps to Reproduce:
As an oversighter
When I visit the details view for an abuse filter log entry

Actual Results:
A checkbox is shown on the left side of the abusefilter-log-detailedentry-meta line, but no button is available to change the visibility of the entry if the checkbox is toggled

Expected Results:
Some way to hide the entry, from the details view

Likely caused by work associated with T144096: AbuseLog: add checkboxes for multiple hidding and unhidding of log entries

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Restore hide link when viewing single AbuseLog entries	mediawiki/extensions/AbuseFilter	wmf/1.36.0-wmf.26	+15 -0
	Restore hide link when viewing single AbuseLog entries	mediawiki/extensions/AbuseFilter	master	+15 -0

Customize query in gerrit

Related Objects

Mentioned Here: T144096: AbuseLog: add checkboxes for multiple hidding and unhidding of log entries

Event Timeline

DannyS712 created this task.Jan 11 2021, 12:12 AM

Restricted Application added a project: User-DannyS712. · View Herald TranscriptJan 11 2021, 12:12 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

DannyS712 moved this task from Unsorted to Abuse Filter on the User-DannyS712 board.Jan 11 2021, 12:13 AM

The checkbox isn't mean to be shown in there, https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/654897. Unsure if there's a point in adding an oversight button there.

There used to be a "change visibility" link where we could OS it, and yeah, there is a point in having it. It's similar to the "change visibility" links on diffs, when you can also OS them by going to the history page.

DannyS712 triaged this task as High priority.Jan 11 2021, 4:51 AM

DannyS712 added a project: Regression.

Yeah, on second thought, it makes sense.

Change 655417 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Restore hide link when viewing single AbuseLog entries

https://gerrit.wikimedia.org/r/655417

gerritbot added a project: Patch-For-Review.Jan 11 2021, 11:29 AM

Going to be fixed with the patch above. The translations for that message still exist on translatewiki, luckily.

Change 655417 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Restore hide link when viewing single AbuseLog entries

https://gerrit.wikimedia.org/r/655417

Daimona closed this task as Resolved.Jan 14 2021, 8:56 PM

Daimona removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.27; 2021-01-19).Jan 14 2021, 9:00 PM

Change 655943 had a related patch set uploaded (by DannyS712; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@wmf/1.36.0-wmf.26] Restore hide link when viewing single AbuseLog entries

https://gerrit.wikimedia.org/r/655943

gerritbot added a project: Patch-For-Review.Jan 15 2021, 12:36 AM

Change 655943 abandoned by Jforrester:
[mediawiki/extensions/AbuseFilter@wmf/1.36.0-wmf.26] Restore hide link when viewing single AbuseLog entries

Reason:
wmf.27 is everywhere, and wmf.28 is now being deployed.