Page MenuHomePhabricator

No longer able to change visibility of hits from details view
Closed, ResolvedPublicBUG REPORT

Description

Steps to Reproduce:
As an oversighter
When I visit the details view for an abuse filter log entry

Actual Results:
A checkbox is shown on the left side of the abusefilter-log-detailedentry-meta line, but no button is available to change the visibility of the entry if the checkbox is toggled

Expected Results:
Some way to hide the entry, from the details view

Likely caused by work associated with T144096: AbuseLog: add checkboxes for multiple hidding and unhidding of log entries

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

The checkbox isn't mean to be shown in there, https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/654897. Unsure if there's a point in adding an oversight button there.

There used to be a "change visibility" link where we could OS it, and yeah, there is a point in having it. It's similar to the "change visibility" links on diffs, when you can also OS them by going to the history page.

DannyS712 added a project: Regression.

Yeah, on second thought, it makes sense.

Change 655417 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Restore hide link when viewing single AbuseLog entries

https://gerrit.wikimedia.org/r/655417

Going to be fixed with the patch above. The translations for that message still exist on translatewiki, luckily.

Change 655417 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Restore hide link when viewing single AbuseLog entries

https://gerrit.wikimedia.org/r/655417

Change 655943 had a related patch set uploaded (by DannyS712; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@wmf/1.36.0-wmf.26] Restore hide link when viewing single AbuseLog entries

https://gerrit.wikimedia.org/r/655943

Change 655943 abandoned by Jforrester:
[mediawiki/extensions/AbuseFilter@wmf/1.36.0-wmf.26] Restore hide link when viewing single AbuseLog entries

Reason:
wmf.27 is everywhere, and wmf.28 is now being deployed.

https://gerrit.wikimedia.org/r/655943