Page MenuHomePhabricator

Figure out what the IP info box should show when some information is not available
Closed, DuplicatePublic

Description

Specifically when on-wiki info is available and IP info isn't. Possible options:

  • Show an error
  • Show Not available
  • Hide unavailable fields
  • Collapse the entire box

(related: T271675)

Event Timeline

Personally, I would prefer showing Not available for any unavailable field. This keeps the layout consistent regardless of the data points available.

Thanks for your input, @JJMC89! I mostly agree, and that is what the current design does too. But, I have two thoughts around this:

  1. When a lot of things are unavailable we might be taking up a lot of space without adding value
  2. Not available and Errors are different things and might need different treatments (also see T263442). For eg, if we think refreshing the page could help show a value we should surface that.

When you look at something like this regularly, you learn where the information that you want is. If unavailable fields cause it to shift around, then you have to search for what you want, slowing you down.

image.png (1,022×499 px, 48 KB)
If everything were in a single column, then hiding might be a good option.

The errors in T263442 seem like they would result in no data being available instead of partial data. In that case, replacing the entire output with the error would be good.

Yep, exactly!

The errors in T263442 seem like they would result in no data being available instead of partial data. In that case, replacing the entire output with the error would be good.

I see, thanks. Given that they we're getting information from two different sources I suspect there is a case where we get on-wiki info only, and no IP info. @Tchanders could you confirm that that could be a case?

I see, thanks. Given that they we're getting information from two different sources I suspect there is a case where we get on-wiki info only, and no IP info. @Tchanders could you confirm that that could be a case?

Yes this could happen, e.g. if no MaxMind information is returned for some reason, the on-wiki information could still be present.