Add help text for Connection Method and Connection Owner in IPInfo infobox [M]
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Prtksxna
	Jan 11 2021, 3:21 AM

Description

Field	Help text
Connection method	The technology through which they’re connecting to the internet.
Connection owner	The kind of entity that owns the internet connection.

Full design spec on Figma

Currently we generate a <dl> to display the data (see mw.IpInfo.IpInfoWidget#generateMarkup). We could instead use OOUI fieldlayouts, where the fieldWidget would be a LabelWidget containing the data, so something like:

new OO.ui.FieldLayout( labelWidgetContainingData, {
    label: 'ipinfo-property-label-thisproperty', 
    align: 'top',
    help: 'ipinfo-help-label-thisproperty', // Message key for the text in the table above
    helpInline: false
} );

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/IPInfo	master	+50 -4	Add tooltips for Connection Method and Connection Owner
	mediawiki/extensions/IPInfo	master	+63 -19	[WIP] Add info text icons and text where required in IP Info

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T285977 IP Info
Open	None	T287647 IP Information accordion on Special:Contribs
Open	Niharika	T292803 IP Info: Explore Instrumentation
Resolved	AGueyte	T296428 Log when a user interacts with the inline help in the infobox
Resolved	STran	T271672 Add help text for Connection Method and Connection Owner in IPInfo infobox [M]

Event Timeline

• Prtksxna created this task.Jan 11 2021, 3:21 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 11 2021, 3:21 AM

See T269268#6675315

• Prtksxna updated the task description. (Show Details)Jan 11 2021, 5:00 AM

• Prtksxna updated the task description. (Show Details)Jan 12 2021, 5:04 AM

Niharika triaged this task as Medium priority.Jan 19 2021, 4:21 AM

Niharika moved this task from Design to Triage/To be Estimated on the Anti-Harassment board.

Tchanders updated the task description. (Show Details)Jan 21 2021, 2:13 PM

AdhamKhatean claimed this task.Feb 13 2021, 7:57 PM

Change 666197 had a related patch set uploaded (by AdhamKhatean; owner: AdhamKhatean):
[mediawiki/extensions/IPInfo@master] [WIP] Add info text icons and text where required in IP Info

https://gerrit.wikimedia.org/r/666197

gerritbot added a project: Patch-For-Review.Feb 22 2021, 7:04 PM

Tchanders moved this task from Triage/To be Estimated to The Letter Song on the Anti-Harassment board.Apr 1 2021, 5:36 PM

Tchanders edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.

Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.

Here's how this looks with the patch as it is:

The spacing has been greatly increased when using OOUI as-is. @Prtksxna should we re-adjust the spacing? Also I'm not sure how great a pop-up in a pop-up is, which it also seems like the library doesn't support out of the box either. Do you think we should consider any alternatives? fwiw I do think it can be fixed w/some CSS and it's not the worst since it's a click activated, not hover activated pop-up.

And the original:

STran moved this task from Code Review 🔍 to Needs Design/Product 🎨 on the Anti-Harassment (The Letter Song) board.Apr 6 2021, 6:26 AM

Hey @STran the help popups are only meant for the box that shows up on Special:Contributions. This popup is eventually meant to have only on-wiki information and won't need any help text (T268657).

Niharika edited projects, added Anti-Harassment; removed Anti-Harassment (The Letter Song).Apr 8 2021, 3:46 PM

Niharika moved this task from Untriaged to Tracking work by others on the Anti-Harassment board.

Niharika added a parent task: T285977: IP Info.Jul 14 2021, 3:43 PM

Niharika added a parent task: T287647: IP Information accordion on Special:Contribs.Jul 28 2021, 11:13 PM

Niharika removed a parent task: T285977: IP Info.

Niharika mentioned this in T287647: IP Information accordion on Special:Contribs.Jul 28 2021, 11:18 PM

Niharika renamed this task from Add info text icons and text where required in IP Info to Add info text icons and text in IP Information box on Special:Contribs.Jul 28 2021, 11:25 PM

Niharika removed a project: Patch-For-Review.

• Prtksxna updated the task description. (Show Details)Jul 29 2021, 4:25 AM

Niharika moved this task from Tracking work by others to Triage/To be Estimated on the Anti-Harassment board.Jul 30 2021, 6:39 PM

Niharika removed AdhamKhatean as the assignee of this task.Aug 4 2021, 3:48 PM

Niharika added a subscriber: AdhamKhatean.

• Prtksxna updated the task description. (Show Details)Aug 6 2021, 5:16 AM

Niharika updated the task description. (Show Details)Aug 25 2021, 4:53 PM

ARamirez_WMF renamed this task from Add info text icons and text in IP Information box on Special:Contribs to Add info text icons and text in IP Information box on Special:Contribs [M].Aug 25 2021, 4:57 PM

ARamirez_WMF moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.

Niharika moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.Aug 26 2021, 6:28 PM

Niharika edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.

Niharika moved this task from Backlog to Up Next on the IP Info board.Sep 1 2021, 4:48 AM

• Prtksxna moved this task from Needs Design/Product 🎨 to Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) on the Anti-Harassment (The Letter Song) board.Sep 8 2021, 3:18 AM

TThoabala claimed this task.Sep 16 2021, 7:42 PM

TThoabala moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.Sep 20 2021, 2:41 PM

TThoabala removed TThoabala as the assignee of this task.Sep 23 2021, 2:08 PM

TThoabala moved this task from In Progress 💪 to Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) on the Anti-Harassment (The Letter Song) board.

TThoabala added a subscriber: TThoabala.

TThoabala claimed this task.Sep 24 2021, 7:47 PM

ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.Sep 28 2021, 4:19 PM

ARamirez_WMF moved this task from In Progress 💪 to Blocked/Stalled 🚧 on the Anti-Harassment (The Letter Song) board.Oct 4 2021, 6:20 PM

ARamirez_WMF moved this task from The Letter Song to Design on the Anti-Harassment board.Oct 19 2021, 4:24 PM

ARamirez_WMF edited projects, added Anti-Harassment; removed Anti-Harassment (The Letter Song).

ARamirez_WMF moved this task from Design to Product/Tech backlog on the Anti-Harassment board.

TThoabala removed TThoabala as the assignee of this task.Oct 19 2021, 5:55 PM

phuedx moved this task from Product/Tech backlog to Pre-estimation/Triage on the Anti-Harassment board.Nov 23 2021, 11:58 AM

ARamirez_WMF moved this task from Pre-estimation/Triage to Cards ready for development on the Anti-Harassment board.Nov 24 2021, 5:09 PM

phuedx mentioned this in T296428: Log when a user interacts with the inline help in the infobox.Nov 24 2021, 6:41 PM

phuedx added a parent task: T296428: Log when a user interacts with the inline help in the infobox.

phuedx edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.Dec 8 2021, 2:32 PM

phuedx moved this task from Blocked/Stalled 🚧 to Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) on the Anti-Harassment (The Letter Song) board.Dec 8 2021, 4:32 PM

I noticed this was moved into the ready column but shouldn't it remain blocked on account of none of the fields that need information existing yet? Connection type/owner is still going through code review, the proxy information is not currently rendered on the front-end (but is passed in the api), and we cannot get static/dynamic ip info.

Going to claim this anyway and look into any necessary pre-reqs

STran moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.Dec 17 2021, 2:19 PM

Confirmed there were blockers for T269763: Add Static / Dynamic value to the IP Information box [M] and T297961: Add Proxy Information to infobox [L] so I've moved adding the tooltips for those properties to their associated tickets. This ticket can be for Connection Method/Owner, which has been merged and can act as the template for the future properties.

STran renamed this task from Add info text icons and text in IP Information box on Special:Contribs [M] to Add help text for Connection Method and Connection Owner in IPInfo infobox [M].Dec 17 2021, 4:59 PM

Change 748164 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/IPInfo@master] Add tooltips for Connection Method and Connection Owner

https://gerrit.wikimedia.org/r/748164

gerritbot added a project: Patch-For-Review.Dec 17 2021, 5:08 PM

STran moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Dec 17 2021, 5:41 PM

@STran & @Prtksxna I've looked at the patch and it appears to work well on the IPInfobox but these aren't displaying in the popup. Just to clarify from the previous comments, we are NOT doing these in the popup? If that's the case, I'm good to +2.

In T271672#7587453, @wikitrent wrote:

Just to clarify from the previous comments, we are NOT doing these in the popup?

That is correct the popup wont have the information icon and help text.

Tchanders moved this task from Code Review 🔍 to Design Review 🔬 on the Anti-Harassment (The Letter Song) board.Jan 6 2022, 4:27 PM

Change 748164 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Add tooltips for Connection Method and Connection Owner

https://gerrit.wikimedia.org/r/748164

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.17; 2022-01-10).Jan 6 2022, 5:00 PM

STran moved this task from Design Review 🔬 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Jan 7 2022, 1:45 AM

Looking at this on the Special:Contributions, the (i) is quite far to the right and it is unclear whether it is for the Connection Method and Connection Owner or the Active Blocks and Contributions.

@Prtksxna What do you think?

Thanks for bringing this up Dom. @STran had mentioned this too and we captured it in T297957: IPInfo: Help popup position makes it unclear what its attached to.
Also noting that after the desktop refresh the width of the content will be capped at 960px (I think). This might be confusing at that width too, though.

dom_walden added a project: QTE-TestingOverview.Jan 7 2022, 3:59 PM

dom_walden moved this task from Inbox to Dom on the QTE-TestingOverview board.

I tested the two new help popups on:

Browsers:

Firefox 78
Chromium 87
Safari 14

Skins:

Vector (new and old)
Minerva
MonoBook
Timeless

In LTR (enwiki) and RTL (hewiki).

Test environment: https://en.wikipedia.beta.wmflabs.org IP Info 0.0.0 (f689abd) 07:25, 7 January 2022.

Niharika closed this task as Resolved.Feb 17 2022, 1:48 AM

Niharika moved this task from Up Next to Closed on the IP Info board.Aug 4 2022, 3:51 PM

	F34619819: image.png
	Aug 25 2021, 4:53 PM

	F34259074: image.png
	Apr 6 2021, 6:26 AM

	F34259076: image.png
	Apr 6 2021, 6:26 AM

Add help text for Connection Method and Connection Owner in IPInfo infobox [M]Closed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Add help text for Connection Method and Connection Owner in IPInfo infobox [M]
Closed, ResolvedPublic
Actions

Related Objects
Search...