Page MenuHomePhabricator

Fix padding and typography issues in the IP info box [M]
Closed, ResolvedPublic

Description

  • Remove font-size definitions. Use OOUI defaults (mocks)
  • Match left alignment of box heading and first column of information
  • Match the padding of the IP info box same to the Search for contributions box
  • Match the heading font size of the IP info box to the Search for contributions box
  • Match the icon and heading spacing of the IP info box to the Search for contributions box

Event Timeline

Niharika triaged this task as Medium priority.Jan 19 2021, 4:24 AM
Niharika moved this task from Design to Triage/To be Estimated on the Anti-Harassment board.
ARamirez_WMF renamed this task from Fix padding and typography issues in the IP info box to Fix padding and typography issues in the IP info box [M].Jul 14 2021, 4:34 PM

Change 708310 had a related patch set uploaded (by Wikitrent; author: Wikitrent):

[mediawiki/extensions/IPInfo@master] WIP: Fix styling of IPinfobox

https://gerrit.wikimedia.org/r/708310

Change 708310 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Fix styling of IPinfobox

https://gerrit.wikimedia.org/r/708310

@Prtksxna Below are some screen shot I captured testing on supported browser and mobile.
Test url: https://meta.wikimedia.beta.wmflabs.org/wiki/Special:Contributions
Version: IP Info 0.0.0 (e924e77) 06:24, 9 August 2021
Screen shot:

Screen Shot 2021-08-10 at 5.50.00 PM.png (1×2 px, 481 KB)

Screen Shot 2021-08-10 at 10.21.14 PM.png (1×2 px, 521 KB)

Screen Shot 2021-08-10 at 10.30.43 PM.png (1×1 px, 503 KB)

Screen Shot 2021-08-10 at 10.53.21 PM.png (1×1 px, 351 KB)

@Prtksxna FYI, In testing, I saw on Safari browser only there is the blue highlight that persist as you click on the IP information and Search for Contribution links. Let me know if this is okay.

Screen Shot 2021-08-10 at 5.50.00 PM.png (1×2 px, 453 KB)

@Prtksxna FYI, In testing, I saw on Safari browser only there is the blue highlight that persist as you click on the IP information and Search for Contribution links. Let me know if this is okay.

Thanks @imaigwilo! Yup this is fine, Safari shows focus state differently 🤷🏾‍♂️