Page MenuHomePhabricator

Add organization field in the IP Info box
Closed, ResolvedPublic2 Estimated Story PointsFeb 9 2021

Description

image.png (499ร—1 px, 48 KB)

Add organization to the first column of the IP Info box.

Details

Due Date
Feb 9 2021, 5:00 AM

Event Timeline

Restricted Application added a subscriber: Aklapper. ยท View Herald TranscriptJan 11 2021, 3:23 AM
Niharika triaged this task as Medium priority.Jan 19 2021, 4:19 AM
Niharika moved this task from Design to Cards ready to be estimated on the Anti-Harassment board.
Niharika renamed this task from Consider adding organization field in the IP Info box to Add organization field in the IP Info box.Jan 20 2021, 5:42 PM
ARamirez_WMF set the point value for this task to 2.Jan 27 2021, 5:41 PM
ARamirez_WMF changed the subtype of this task from "Task" to "Deadline".

Change 663898 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/IPInfo@master] Add organization field in the infobox

https://gerrit.wikimedia.org/r/663898

Change 663898 merged by jenkins-bot:
[mediawiki/extensions/IPInfo@master] Add organization field in the infobox

https://gerrit.wikimedia.org/r/663898

@Tchanders Are we supposed to see the "Location" in the popup, or is this work only for the API?

nolocation.png (302ร—323 px, 18 KB)

@dom_walden I assume the Organization is only needed in the infobox as per the task description, but @Prtksxna could confirm?

@dom_walden I assume the Organization is only needed in the infobox as per the task description, but @Prtksxna could confirm?

Ooh, that makes sense now. I forgot that they were different.

I scraped data from the IPInfo box on Special:Contributions for ~1000 IP addresses and compared them to what I get from a local copy of the GeoLite2 database. They all matched.

vagrant_myip_whole.png (410ร—1 px, 25 KB)

I'm moving this into Design Review in case Prateek wants to answer the above question. @Prtksxna Feel free to move this along.

Note: I am seeing weird results on beta. So far, I have not seen ASN or Organisation info for any IP on https://en.wikipedia.beta.wmflabs.org, which might be an environment issue.

Test environment: local vagrant IP Info 0.0.0 (00fe315).

@dom_walden I assume the Organization is only needed in the infobox as per the task description, but @Prtksxna could confirm?

That is correct. Eventually the popup will have only on-wiki information, so no need to add organization there.