Page MenuHomePhabricator
Create Task
Maniphest T271715

Deprecate and remove BeforeResetNotificationTimestamp hook
Closed, ResolvedPublic
Actions

Description

This hook was introduced with r473958 roughly 2 years ago, and it takes a User and a Title as parameters. This is common with legacy hooks, but since we're migrating away from these two classes in favour of UserIdentity and LinkTarget, hooks should also be updated.

However, since this specific hook has no usages shown on codesearch, we are just going to remove it - deprecated in 1.37 for removal in 1.38

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Drop deprecated BeforeResetNotificationTimestamp hookmediawiki/coremaster+12 -121
Hard deprecate BeforeResetNotificationTimestamp hookmediawiki/coremaster+3 -1
Customize query in gerrit

Event Timeline

Daimona created this task.Jan 11 2021, 1:42 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJan 11 2021, 1:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Jan 12 2021, 12:19 AM

Change 655399 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate BeforeResetNotificationTimestamp hook

https://gerrit.wikimedia.org/r/655399

gerritbot added a project: Patch-For-Review.Jan 12 2021, 12:19 AM
DannyS712 subscribed.Jan 12 2021, 12:21 AM
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:47 PM
gerritbot added a comment.Jun 7 2021, 1:47 PM

Change 655399 merged by jenkins-bot:

[mediawiki/core@master] Hard deprecate BeforeResetNotificationTimestamp hook

https://gerrit.wikimedia.org/r/655399

DannyS712 changed the task status from Open to Stalled.Jun 7 2021, 1:48 PM
DannyS712 claimed this task.
DannyS712 added a project: Technical-Debt (Deprecation process).

Instead of widening, just deprecating in 1.37 for removal in 1.38 - stalling until we can remove it

Restricted Application added a project: User-DannyS712. · View Herald TranscriptJun 7 2021, 1:48 PM
DannyS712 renamed this task from Widen User to UserIdentity and Title to LinkTarget in BeforeResetNotificationTimestamp hook to Deprecate and remove BeforeResetNotificationTimestamp hook.Jun 7 2021, 1:48 PM
DannyS712 moved this task from Untriaged to 2021 | MW 1.36 / 1.37 on the Technical-Debt (Deprecation process) board.
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.
DannyS712 updated the task description. (Show Details)
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.9; 2021-06-07).Jun 7 2021, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 7 2021, 2:10 PM
DannyS712 changed the task status from Stalled to In Progress.Sep 21 2021, 10:51 PM
gerritbot added a comment.Sep 21 2021, 10:52 PM

Change 722707 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@master] Drop deprecated BeforeResetNotificationTimestamp hook

https://gerrit.wikimedia.org/r/722707

gerritbot added a project: Patch-For-Review.Sep 21 2021, 10:52 PM
DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.Sep 21 2021, 11:54 PM
gerritbot added a comment.Sep 22 2021, 1:29 AM

Change 722707 merged by jenkins-bot:

[mediawiki/core@master] Drop deprecated BeforeResetNotificationTimestamp hook

https://gerrit.wikimedia.org/r/722707

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.2; 2021-09-28).Sep 22 2021, 2:00 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 22 2021, 2:10 AM
DannyS712 closed this task as Resolved.Sep 22 2021, 2:13 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits