Page MenuHomePhabricator

Deprecate and remove BeforeResetNotificationTimestamp hook
Open, Stalled, Needs TriagePublic


This hook was introduced with r473958 roughly 2 years ago, and it takes a User and a Title as parameters. This is common with legacy hooks, but since we're migrating away from these two classes in favour of UserIdentity and LinkTarget, hooks should also be updated.

However, since this specific hook has no usages shown on codesearch, we are just going to remove it - deprecated in 1.37 for removal in 1.38

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 655399 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate BeforeResetNotificationTimestamp hook

Change 655399 merged by jenkins-bot:

[mediawiki/core@master] Hard deprecate BeforeResetNotificationTimestamp hook

DannyS712 changed the task status from Open to Stalled.Jun 7 2021, 1:48 PM
DannyS712 claimed this task.

Instead of widening, just deprecating in 1.37 for removal in 1.38 - stalling until we can remove it

DannyS712 renamed this task from Widen User to UserIdentity and Title to LinkTarget in BeforeResetNotificationTimestamp hook to Deprecate and remove BeforeResetNotificationTimestamp hook.Jun 7 2021, 1:48 PM
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.
DannyS712 updated the task description. (Show Details)