Page MenuHomePhabricator

Create security-related project tags secteam-reviewed and wikimedia-project-event
Closed, ResolvedPublic

Description

Hello-

I thought I might have permissions to create projects/tags within Phabricator, but apparently I do not. I'd like to create two simple ones that I and other members of the Security-Team will have access to edit:

  • name: secteam-reviewed
    • description: Tasks that have been reviewed by the Security-Team, likely during our weekly clinic meeting. This implies that the task has been accepted into one of our backlogs or assigned to a team member for completion or has been placed within our "watching" column for future follow-up or has had the Security-Team tag removed if the work is not relevant for our team or we do not have capacity to work on a given task. Note that the Security-Team tag is different from the general Security tag, the latter simply implying that a task is "security-related" in some way.
  • name: wikimedia-project-event
    • description: Used by the Security-Team to track and report on certain on-wiki events which have corresponding Phabricator tasks. These events are often security-related but likely do not qualify as a security event or security incident, as the Security-Team typically views those two descriptive terms.

These will primarily be used internally by the Security-Team. I also understand that the second tag is named somewhat vaguely, although there are some internal intentions behind that.

Event Timeline

I also understand that the second tag is named somewhat vaguely, although there are some internal intentions behind that.

What if a wikimedia project wanted to host an event?

It sounds too vague to me. Is there a guideline on when it should be used?

Hi, please see https://www.mediawiki.org/wiki/Phabricator/Creating_and_renaming_projects for required information (e.g. a description).
Also, secteam-reviewed sounds like a status (e.g. workboard column) and not like a project tag to me? Thanks!

It sounds too vague to me. Is there a guideline on when it should be used?

It's primarily internal to the Security-Team as a means of tracking certain on-wiki events which have corresponding Phab tasks. But we'd really prefer to NOT be alarmist in the naming, thus wanting to avoid names like on-wiki-security-event or on-wiki-security-incident, which mean different things to our team.

Hi, please see https://www.mediawiki.org/wiki/Phabricator/Creating_and_renaming_projects for required information (e.g. a description).

Thanks - I didn't really have descriptions ready when I created this task as I had wanted to work through those after the project tags had been created. But I can work on them now and update the description if that's the best practice. Now updated.

Also, secteam-reviewed sounds like a status (e.g. workboard column) and not like a project tag to me? Thanks!

The Security-Team primarily wants this tag to be able to effectively track and run quarterly reports on items we triage in our clinic (or as individuals). Via the standard maniphest search query form, I am not aware of a way to select tasks based upon their current workboard column.

It sounds too vague to me. Is there a guideline on when it should be used?

It's primarily internal to the Security-Team as a means of tracking certain on-wiki events which have corresponding Phab tasks. But we'd really prefer to NOT be alarmist in the naming, thus wanting to avoid names like on-wiki-security-event or on-wiki-security-incident, which mean different things to our team.

Thanks for the explanation. Noting a quick discussion about naming in -releng I had with you that also suggested #wikimedia-cyber-event but I fully understand the desire to avoid the terms "security" and "incident"

Ping @Aklapper, @Reedy - are we ok to create these tags now? The Security-Team would like to start using these soon, if possible. Thanks.

The description of wikimedia-project-event implies that it should be a subproject of Security-Team if it's only ever relevant to the security team to have it on their (sub)board?

If SecTeam-Processed implies that it has been accepted to a backlog of some existing project tag or some column of some existing project tag's workboard, and if it's not in scope so the Security-Team tag has removed anyway, why is that tag needed at all?

"Reviewed" seems to be meaningless. Either it's "accepted" (ends up in a workboard column) or "nothing to do for us" (tag gets removed)?

The description of wikimedia-project-event implies that it should be a subproject of Security-Team if it's only ever relevant to the security team to have it on their (sub)board?

Sure, that's fine.

If SecTeam-Processed implies that it has been accepted to a backlog of some existing project tag or some column of some existing project tag's workboard, and if it's not in scope so the Security-Team tag has removed anyway, why is that tag needed at all?

"Reviewed" seems to be meaningless. Either it's "accepted" (ends up in a workboard column) or "nothing to do for us" (tag gets removed)?

Given the Security-Team's unique mandate of triaging tasks that come in tagged with either Security / Privacy and/or are submitted as protected tasks, we need some way to track and statistically report upon these tasks on a quarterly basis and to visually indicate to anyone who cares that, yes, our team did actually review a given task. This is a little more challenging in our team's case since a large majority of these tasks do not end up in our backlog and/or are easily forgotten once we untag our team or even place a task within our team's watching column. Creating a new Phab tag, which would allow us to easily track and report upon these tasks, seemed like the most sane approach. If there's a better available option, which satisfies all of these requirements, I'm certainly willing to evaluate it. Tracking these tasks manually (in a Google sheet or something) or within another system seems like a far more irritating and work-intensive approach for our team. And there would be some conflicts and workflow breakage if we simply tried to add another column to the Security-Team's workboard.

<tl;dr>: Big thanks for providing the additional background here. I'm still not fully convinced but let's try and feel free to create those.

Longer version / thoughts:

I do see how some kind of project tag to mark tasks as "Security looked at this; nothing to do for us" makes sense, but in that case "reviewed" would be a vague term compared to e.g. secteam-nothing-to-do (for some context: I've seen patch review systems with status entries like rejected, accepted, needs-rework but also reviewed and the latter term left everyone baffled what that's supposed to mean for who, so things were often just left lingering due to ambiguity).

I'm still not convinced that secteam-reviewed makes sense if it e.g. "implies that the task has been accepted into one of our backlogs", because that's already expressed by a workboard column move or by adding some Security related project tag.
If you intend to tag every task ever looked at by the Security Team, then this feels like a work-intense and error-prone way to gather statistics.
For those folks who want to know that the Security team reviewed a given task, I'd have expected folks to look at the task and spot a comment or an action by the Security Team in there, e.g. removing the Security Team project tag. But people might not even open tasks and only look at workboards, so you might have a point.

(PS: I shortened the beginning of the descriptions a bit ("This project tag indicates that a task has been..." 🡒 "Tasks that have been..."), as space is precious in the description preview.)

Aklapper renamed this task from Create two new security-related project tags to Create security-related project tags secteam-reviewed and wikimedia-project-event.Jan 25 2021, 10:31 PM

The description of wikimedia-project-event implies that it should be a subproject of Security-Team

Have to correct myself: No, subproject is a bad idea as there are no subprojects yet, so all its members would be moved. Sigh, not so great Phabricator limitations.

I created SecTeam-wikimedia-project-event and SecTeam-Processed; please review.
Thanks (also for the patience)!

What about SecTeam-Seen or SecTeam-Processed as alternatives to SecTeam-Reviewed?

I created SecTeam-wikimedia-project-event and SecTeam-Processed; please review.
Thanks (also for the patience)!

Thanks, these should work great.

What about SecTeam-Seen or SecTeam-Processed as alternatives to SecTeam-Reviewed?

Those would likely be fine as well. Since @Aklapper just created SecTeam-Processed, maybe we can try that for a while and if it's too confusing, we can rename it.

sbassett assigned this task to Aklapper.
sbassett triaged this task as Low priority.
sbassett moved this task from Waiting to Done on the user-sbassett board.

I favor processed"(thanks for finding better words!) as it implies a process has finished in contrast to reviewed's "we took an initial first look", so I renamed.

@sbassett: Hmm, why were Edit Policy and Join Policy of SecTeam-Processed and SecTeam-wikimedia-project-event changed to acl*security ? Which problem does that solve, apart from blocking interested people to join/follow that project?

@sbassett: Hmm, why were Edit Policy and Join Policy of SecTeam-Processed and SecTeam-wikimedia-project-event changed to acl*security ? Which problem does that solve, apart from blocking interested people to join/follow that project?

Paranoia on my part if those tags are applied to protected Phabricator tasks and thus allow lower-privileged members/watchers to view sensitive or PermanentlyPrivate tasks. These tags should really only ever be used or cared about by Security-Team members, but if there is a desire to have them as open as possible, I'd want to confirm that some random Phabricator user couldn't join them and then view protected tasks to which they may be applied.