Page MenuHomePhabricator
Create Task
Maniphest T271756

Address various issues around exception-handling within StopForumSpam
Closed, ResolvedPublic
Actions

Description

Per T271740#6737317:

  1. doUpdate() should throw an exception here, rather than logging and silently returning false.
  2. The extension should use SPL exceptions, which are more specific, within DenyListManager.php (1) and DenyListUpdate.php (6).

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Address issues around exception-handling within StopForumSpammediawiki/extensions/StopForumSpammaster+15 -12
Customize query in gerrit

Related Objects

Event Timeline

sbassett created this task.Jan 11 2021, 10:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 11 2021, 10:17 PM
sbassett triaged this task as Low priority.Jan 11 2021, 10:17 PM
sbassett updated the task description. (Show Details)
sbassett mentioned this in T271757: Fix issues with StopForumSpam's doUpdate function.Jan 11 2021, 10:24 PM
sbassett updated the task description. (Show Details)Jan 12 2021, 2:53 AM
sbassett moved this task from Backlog to In Progress on the MediaWiki-extensions-StopForumSpam board.Jan 12 2021, 7:15 PM
sbassett mentioned this in T181217: Deploy StopForumSpam to the Beta Cluster.
sbassett moved this task from Backlog to In Progress on the user-sbassett board.Jan 12 2021, 7:21 PM
sbassett mentioned this in T266904: Performance review of ext:StopForumSpam.Jan 13 2021, 3:38 PM
gerritbot added a comment.Jan 14 2021, 5:44 PM

Change 656219 had a related patch set uploaded (by SBassett; owner: SBassett):
[mediawiki/extensions/StopForumSpam@master] Address issues around exception-handling within StopForumSpam

https://gerrit.wikimedia.org/r/656219

gerritbot added a project: Patch-For-Review.Jan 14 2021, 5:44 PM
gerritbot added a comment.Jan 28 2021, 5:22 PM

Change 656219 merged by jenkins-bot:
[mediawiki/extensions/StopForumSpam@master] Address issues around exception-handling within StopForumSpam

https://gerrit.wikimedia.org/r/656219

sbassett closed this task as Resolved.Jan 28 2021, 5:46 PM
sbassett moved this task from In Progress to Done on the MediaWiki-extensions-StopForumSpam board.
sbassett moved this task from In Progress to Done on the user-sbassett board.
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.29; 2021-02-02).Jan 28 2021, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 28 2021, 6:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits