Page MenuHomePhabricator

Address various issues around exception-handling within StopForumSpam
Closed, ResolvedPublic

Description

Per T271740#6737317:

  1. doUpdate() should throw an exception here, rather than logging and silently returning false.
  2. The extension should use SPL exceptions, which are more specific, within DenyListManager.php (1) and DenyListUpdate.php (6).

Event Timeline

sbassett updated the task description. (Show Details)

Change 656219 had a related patch set uploaded (by SBassett; owner: SBassett):
[mediawiki/extensions/StopForumSpam@master] Address issues around exception-handling within StopForumSpam

https://gerrit.wikimedia.org/r/656219

Change 656219 merged by jenkins-bot:
[mediawiki/extensions/StopForumSpam@master] Address issues around exception-handling within StopForumSpam

https://gerrit.wikimedia.org/r/656219

sbassett moved this task from In Progress to Done on the MediaWiki-extensions-StopForumSpam board.
sbassett moved this task from In Progress to Done on the user-sbassett board.