Page MenuHomePhabricator

Give Popups storybook instance some love
Closed, ResolvedPublic3 Estimated Story Points

Description

This is a timeboxed task to update the Popups storybook instance limited to 2 weeks.
Not looking after it, makes it harder for us to review patches against the repo with confidence, so it is in our interest to do these changes sooner rather than later.

Acceptance criteria

page_previews_storybook_1.png (1×2 px, 419 KB)

  • The spacing of the previews is still a little… off. Fix.

page_previews_storybook_2.png (1×2 px, 340 KB)

  • @Jdrewniak's CSS resource (which gives everything a red border) isn't shown. Fix:

page_previews_storybook_3.png (1×2 px, 242 KB)

Event Timeline

ovasileva triaged this task as Medium priority.Jan 18 2021, 10:22 PM
ovasileva moved this task from Incoming to Triaged but Future on the Readers-Web-Backlog board.

Change 701508 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/extensions/Popups@master] [Storybook] Add relative positioning to .mwe-popups-container

https://gerrit.wikimedia.org/r/701508

Change 701509 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/extensions/Popups@master] [Storybook] Remove unused Less file in Storybook folder.

https://gerrit.wikimedia.org/r/701509

Change 701510 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/extensions/Popups@master] [Storybook] Removing custom CSS grid and knobs addon from Storybook

https://gerrit.wikimedia.org/r/701510

Change 702359 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/extensions/Popups@master] [Storybook] Adding missing images

https://gerrit.wikimedia.org/r/702359

Change 702363 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/extensions/Popups@master] [Storybook] Upgrade Storybook to v6.2.9

https://gerrit.wikimedia.org/r/702363

Change 701508 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Add relative positioning to .mwe-popups-container

https://gerrit.wikimedia.org/r/701508

Change 701509 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] [Storybook] Remove unused Less file in Storybook folder.

https://gerrit.wikimedia.org/r/701509

bwang removed bwang as the assignee of this task.Jul 13 2021, 4:26 PM
bwang added a subscriber: bwang.
Jdlrobson updated Other Assignee, added: Jdrewniak.

Change 701510 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] [Storybook] Removing custom CSS grid and addons from Storybook

https://gerrit.wikimedia.org/r/701510

Change 702359 merged by Jdrewniak:

[mediawiki/extensions/Popups@master] [Storybook] Fixing missing images

https://gerrit.wikimedia.org/r/702359

Change 702363 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] [Storybook] Upgrade Storybook to v6.2.9

https://gerrit.wikimedia.org/r/702363

Change 705007 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/extensions/Popups@master] Use relative positioning with zero top,left,bottom,right properties in storybook

https://gerrit.wikimedia.org/r/705007

nray added a subscriber: nray.

Moving this back to code review per the above patch ^^

Change 705007 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Use relative positioning with zero top,left,bottom,right properties in storybook

https://gerrit.wikimedia.org/r/705007

Storybook previews are looking good -- there are some fixes in flight to adjust some styles but all in all they're much better than they were. Clicked around and all links are working.

Screen Shot 2021-07-26 at 7.34.13 PM.png (756×1 px, 711 KB)

Screen Shot 2021-07-26 at 7.33.51 PM.png (718×1 px, 396 KB)

Screen Shot 2021-07-26 at 7.33.38 PM.png (721×1 px, 285 KB)