Give Popups storybook instance some love
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Jan 11 2021, 11:18 PM

Description

This is a timeboxed task to update the Popups storybook instance limited to 2 weeks.
Not looking after it, makes it harder for us to review patches against the repo with confidence, so it is in our interest to do these changes sooner rather than later.

Acceptance criteria

Upgrade. We're using Storybook@5.1.10. The current version is 6.1.11
We disabled the Storybook knobs addon in T236589: Page Previews Storybook not available on doc.wikimedia.org and documentation a bit broken, which limited our ability to test layout/extract handling changes. We should get these restored.
Some of the previews have broken image links (see T266797#6726401):

page_previews_storybook_1.png (1×2 px, 419 KB)

The spacing of the previews is still a little… off. Fix.

page_previews_storybook_2.png (1×2 px, 340 KB)

@Jdrewniak's CSS resource (which gives everything a red border) isn't shown. Fix:

page_previews_storybook_3.png (1×2 px, 242 KB)

Details

Other Assignee: Jdrewniak

Subject	Repo	Branch	Lines +/-
Use relative positioning with zero top,left,bottom,right properties in storybook	mediawiki/extensions/Popups	master	+13 -15
[Storybook] Upgrade Storybook to v6.2.9	mediawiki/extensions/Popups	master	+5 K -4 K
[Storybook] Fixing missing images	mediawiki/extensions/Popups	master	+1 -1
[Storybook] Removing custom CSS grid and addons from Storybook	mediawiki/extensions/Popups	master	+95 -718
[Storybook] Remove unused Less file in Storybook folder.	mediawiki/extensions/Popups	master	+0 -36
Add relative positioning to .mwe-popups-container	mediawiki/extensions/Popups	master	+1 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• alexhollender_WMF	T284095 [GOAL] Fix page previews visual bugs and remove unnecessary code before end of quarter
		Resolved		cjming	T271763 Give Popups storybook instance some love

Event Timeline

Jdlrobson created this task.Jan 11 2021, 11:18 PM

Restricted Application added subscribers: Enterprisey, Aklapper. · View Herald TranscriptJan 11 2021, 11:18 PM

Jdlrobson mentioned this in T266797: Fix page preview renderings in storybook?.Jan 11 2021, 11:18 PM

ovasileva triaged this task as Medium priority.Jan 18 2021, 10:22 PM

ovasileva moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.

wrong project..

Jdlrobson added a parent task: T284095: [GOAL] Fix page previews visual bugs and remove unnecessary code before end of quarter.Jun 11 2021, 5:26 PM

ovasileva edited projects, added Web-Team-Backlog (Kanbanana-FY-2020-21); removed Web-Team-Backlog.Jun 22 2021, 5:14 PM

Jdlrobson mentioned this in T281170: Regression: Inconsistent inner top padding in all popup types.Jun 22 2021, 5:14 PM

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Jdlrobson updated the task description. (Show Details)Jun 22 2021, 5:23 PM

LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jun 22 2021, 5:27 PM

LGoto set the point value for this task to 3.

Jdlrobson assigned this task to Jdrewniak.Jun 23 2021, 2:53 PM

Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Change 701508 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/extensions/Popups@master] [Storybook] Add relative positioning to .mwe-popups-container

https://gerrit.wikimedia.org/r/701508

Change 701509 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/extensions/Popups@master] [Storybook] Remove unused Less file in Storybook folder.

https://gerrit.wikimedia.org/r/701509

Change 701510 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/extensions/Popups@master] [Storybook] Removing custom CSS grid and knobs addon from Storybook

https://gerrit.wikimedia.org/r/701510

Change 702359 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/extensions/Popups@master] [Storybook] Adding missing images

https://gerrit.wikimedia.org/r/702359

Change 702363 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/extensions/Popups@master] [Storybook] Upgrade Storybook to v6.2.9

https://gerrit.wikimedia.org/r/702363

Jdrewniak removed Jdrewniak as the assignee of this task.Jun 30 2021, 1:18 PM

Jdrewniak moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

LGoto assigned this task to bwang.Jun 30 2021, 4:47 PM

Change 701508 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Add relative positioning to .mwe-popups-container

https://gerrit.wikimedia.org/r/701508

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.14; 2021-07-12).Jul 2 2021, 5:00 PM

Change 701509 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] [Storybook] Remove unused Less file in Storybook folder.

https://gerrit.wikimedia.org/r/701509

bwang removed bwang as the assignee of this task.Jul 13 2021, 4:26 PM

bwang moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

bwang subscribed.

Jdlrobson moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jul 13 2021, 5:08 PM

LGoto assigned this task to Jdrewniak.Jul 13 2021, 5:08 PM

Jdlrobson reassigned this task from Jdrewniak to bwang.Jul 13 2021, 5:08 PM

Jdlrobson updated Other Assignee, added: Jdrewniak.

Change 701510 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] [Storybook] Removing custom CSS grid and addons from Storybook

https://gerrit.wikimedia.org/r/701510

Change 702359 merged by Jdrewniak:

[mediawiki/extensions/Popups@master] [Storybook] Fixing missing images

https://gerrit.wikimedia.org/r/702359

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.15; 2021-07-19); removed MW-1.37-notes (1.37.0-wmf.14; 2021-07-12).Jul 14 2021, 5:00 PM

Change 702363 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] [Storybook] Upgrade Storybook to v6.2.9

https://gerrit.wikimedia.org/r/702363

bwang removed bwang as the assignee of this task.Jul 16 2021, 4:14 PM

bwang moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Change 705007 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/extensions/Popups@master] Use relative positioning with zero top,left,bottom,right properties in storybook

https://gerrit.wikimedia.org/r/705007

Moving this back to code review per the above patch ^^

Jdlrobson moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jul 16 2021, 7:04 PM

Change 705007 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Use relative positioning with zero top,left,bottom,right properties in storybook

https://gerrit.wikimedia.org/r/705007

LGoto assigned this task to cjming.Jul 19 2021, 5:31 PM

Storybook previews are looking good -- there are some fixes in flight to adjust some styles but all in all they're much better than they were. Clicked around and all links are working.

Screen Shot 2021-07-26 at 7.34.13 PM.png (756×1 px, 711 KB)

Screen Shot 2021-07-26 at 7.33.51 PM.png (718×1 px, 396 KB)

Screen Shot 2021-07-26 at 7.33.38 PM.png (721×1 px, 285 KB)

cjming closed this task as Resolved.Jul 27 2021, 1:39 AM

	F34566584: Screen Shot 2021-07-26 at 7.33.51 PM.png
	Jul 27 2021, 1:38 AM

	F34566583: Screen Shot 2021-07-26 at 7.33.38 PM.png
	Jul 27 2021, 1:38 AM

	F34566585: Screen Shot 2021-07-26 at 7.34.13 PM.png
	Jul 27 2021, 1:38 AM

	F33990641: page_previews_storybook_3.png
	Jan 11 2021, 11:18 PM

	F33990623: page_previews_storybook_1.png
	Jan 11 2021, 11:18 PM

	F33990632: page_previews_storybook_2.png
	Jan 11 2021, 11:18 PM

Give Popups storybook instance some loveClosed, ResolvedPublic3 Estimated Story PointsActions