Put line numbers in left side also in RTL wikis
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ebrahim
	Jan 12 2021, 10:29 AM

Description

Recently line numbers are enabled for displaying site wide .css and .js files, a nice tweak, but even the fact the line numbers feature was developed over the years now that it is enabled for broader use the fact the actual numbers in RTL wikis are in right side feels very unnatural as having line numbers on right makes tracking of actual lines to line numbers difficult. If we consider the line numbers a part of user interface not content (which I think they are in gray zone) we should turn the numeral they use from 123456789 to ۱۲۳۴۵۶۷۸۹ for Persian wiki for example which I believe is in a wrong direction.

Example link:
https://fa.wikipedia.org/wiki/مدیاویکی:Common.js?uselang=fa

Screenshot trying to explain the line to line number tracking issue, that isn't an issue in LTR that there is no wide blank space between the code and line numbers.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Line numbers use mw-content-ltr/rtl direction	mediawiki/extensions/SyntaxHighlight_GeSHi	master	+45 -8

Customize query in gerrit

Related Objects

Mentioned In: rESHGe5238a17a848: Line numbers use mw-content-ltr/rtl direction

Event Timeline

Ebrahim created this task.Jan 12 2021, 10:29 AM

Restricted Application added a project: I18n. · View Herald TranscriptJan 12 2021, 10:29 AM

Restricted Application added subscribers: Huji, Aklapper. · View Herald Transcript

Change 655629 had a related patch set uploaded (by Ebrahim; owner: Ebrahim):
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] i18n: put line numbers on the left side also in RTL

https://gerrit.wikimedia.org/r/655629

gerritbot added a project: Patch-For-Review.Jan 12 2021, 10:30 AM

Ebrahim updated the task description. (Show Details)Jan 12 2021, 10:57 AM

Line numbers are in the left side while editing CSS/JS codes, I think a consistent behavior is expected here.

IKhitron subscribed.Jan 12 2021, 1:06 PM

Thanks for this. The extension is actually supposed to support <syntaxhighlight dir=rtl>.... In this case the line numbers would be on the right, so I've amended your patch to position line numbers based on code block directionality (which defaults to LTR on all wikis).

Esanders added a project: SyntaxHighlight.Jan 15 2021, 5:38 PM

Change 655629 merged by jenkins-bot:
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Line numbers use mw-content-ltr/rtl direction

https://gerrit.wikimedia.org/r/655629

Jdforrester-WMF closed this task as Resolved.Jan 15 2021, 9:41 PM

Jdforrester-WMF assigned this task to Ebrahim.

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.27; 2021-01-19).Jan 15 2021, 10:00 PM

Esanders mentioned this in rESHGe5238a17a848: Line numbers use mw-content-ltr/rtl direction.Jan 15 2021, 10:08 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 15 2021, 10:10 PM

Verified on beta cluster: https://he.wikipedia.beta.wmflabs.org/wiki/%D7%9E%D7%93%D7%99%D7%94_%D7%95%D7%99%D7%A7%D7%99:Common.css