PHP Notice: Undefined offset: 0
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

MediaWiki version: 1.36.0-wmf.26

message

PHP Notice: Undefined offset: 0

Impact

A few of this just happened, on testwiki. From sandbox. I assume this is ultimately caused by client error, but the server code should handle those without causing errors or log messages, I think.

I don't know if this is related to T271804: PHP Notice: Undefined index: Alsjdakjsdh but I would assume not, due to the different error message.

Notes

URL: /w/api.php (POST, so nor URL parameters)
Referrer: https://test.wikipedia.org/wiki/Special:ApiSandbox

Details

Request ID: X-2lUApAMMwAA2jZytgAAAEP
Request URL: https://test.wikipedia.org/w/api.php

Stack Trace

exception.trace

#0 /srv/mediawiki/php-1.36.0-wmf.26/includes/api/ApiQueryInfo.php(530): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.36.0-wmf.26/includes/api/ApiQueryInfo.php(426): ApiQueryInfo->extractPageInfo(integer, Title)
#2 /srv/mediawiki/php-1.36.0-wmf.26/includes/api/ApiQuery.php(269): ApiQueryInfo->execute()
#3 /srv/mediawiki/php-1.36.0-wmf.26/includes/api/ApiMain.php(1612): ApiQuery->execute()
#4 /srv/mediawiki/php-1.36.0-wmf.26/includes/api/ApiMain.php(592): ApiMain->executeAction()
#5 /srv/mediawiki/php-1.36.0-wmf.26/includes/api/ApiMain.php(563): ApiMain->executeActionWithErrorHandling()
#6 /srv/mediawiki/php-1.36.0-wmf.26/api.php(90): ApiMain->execute()
#7 /srv/mediawiki/php-1.36.0-wmf.26/api.php(45): wfApiMain()
#8 /srv/mediawiki/w/api.php(3): require(string)
#9 {main}

	Subject	Repo	Branch	Lines +/-
	Fix undefined index error in ApiQueryInfo	mediawiki/core	wmf/1.36.0-wmf.26	+9 -5
	Fix undefined index error in ApiQueryInfo	mediawiki/core	master	+9 -5

Customize query in gerrit

Related Objects

Mentioned Here: T271804: PHP Notice: Undefined index: Alsjdakjsdh

Event Timeline

• LarsWirzenius created this task.Jan 12 2021, 1:44 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 12 2021, 1:44 PM

Now a total of 8 of these. On testwiki, which is a worrying sign, even if root cause is badly behaving client. Making a train blocker, as a large number of log messages is a problem in and of itself.

• holger.knust edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.Jan 12 2021, 2:04 PM

• holger.knust moved this task from Inbox to Ready (WIP:5) on the Platform Team Workboards (Clinic Duty Team) board.

I can reproduce this on my local wiki, but not on testwiki (I don't know why).

I reproduce by submitting Special:ApiSandbox#action=query&format=json&prop=info&titles=<page>&inprop=notificationtimestamp. For a <page> which you are not currently watching.

I am flagging @MusikAnimal for this and for T271804.

dom_walden added projects: Expiring-Watchlist-Items, MediaWiki-Watchlist, Community-Tech.Jan 12 2021, 2:06 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptJan 12 2021, 2:06 PM

This seems like a simply error to fix. $this->notificationtimestamps should only contain timestamps for a given set of pages, so not something that you'd check with an implicit bool casts. Line 530 should use isset, as that seems to be the original intention.

Change 655665 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Fix undefined index error in ApiQueryInfo

https://gerrit.wikimedia.org/r/655665

gerritbot added a project: Patch-For-Review.Jan 12 2021, 2:19 PM

Triggered by requesting page info of non-existing pages. Should be fixed by the patch I just uploaded.

daniel moved this task from Ready (WIP:5) to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.Jan 12 2021, 2:27 PM

Amorymeltzer subscribed.Jan 12 2021, 3:32 PM

Change 655665 merged by jenkins-bot:
[mediawiki/core@master] Fix undefined index error in ApiQueryInfo

https://gerrit.wikimedia.org/r/655665

Change 655671 had a related patch set uploaded (by ArielGlenn; owner: Daniel Kinzler):
[mediawiki/core@wmf/1.36.0-wmf.26] Fix undefined index error in ApiQueryInfo

https://gerrit.wikimedia.org/r/655671

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.27; 2021-01-19).Jan 12 2021, 5:00 PM

Change 655671 merged by jenkins-bot:
[mediawiki/core@wmf/1.36.0-wmf.26] Fix undefined index error in ApiQueryInfo

https://gerrit.wikimedia.org/r/655671

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.26; 2021-01-12); removed MW-1.36-notes (1.36.0-wmf.27; 2021-01-19).Jan 12 2021, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 12 2021, 6:10 PM

Mentioned in SAL (#wikimedia-operations) [2021-01-12T19:01:35Z] <ariel@deploy1001> Synchronized php-1.36.0-wmf.26/includes/api/ApiQueryInfo.php: Backport: (gerrit 655671) Fix undefined index error in ApiQueryInfo (T271815) (duration: 01m 06s)

Seems like it works to me. Would the reporter like to verify?

Being bold and closing.

Krinkle moved this task from Untriaged to Jan 2021 on the Wikimedia-production-error board.Jan 27 2021, 8:37 PM

PHP Notice: Undefined offset: 0Closed, ResolvedPublicPRODUCTION ERRORActions