Page MenuHomePhabricator
Create Task
Maniphest T271898

Add combobox to VE to display suggested values
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To
Andrew-WMDE
Authored By
ECohen_WMDE
Jan 13 2021, 10:28 AM
Tags
Referenced Files
F33997626: Screen Shot 2021-01-13 at 11.22.06.png
Jan 13 2021, 10:28 AM
Subscribers
Aklapper
Andrew-WMDE
awight
ECohen_WMDE
Lena_WMDE
WMDE-Fisch

Description

Requirements

  • Implement behind feature flag
  • If parameter has the property of 'Suggested values' in TemplateData, the values are displayed using the OOUI widget: ComboBoxInputWidget (filtering on input)
    • Only have this visible for the following parameter types: Content, Line, String, Unknown, Number, Unbalanced wikitext. Otherwise, hide suggested values.
  • Users can add a value not included in suggested values. If a user does this, display the following message after clicking out of the widget: "This is not one of the suggested values and may not work with the template." This is displayed using OOUI widget: FieldLayout with notice message
  • Ensure the above requirements work on mobile
  • Ensure the above requirements work on RTL

Mocks

Screen Shot 2021-01-13 at 11.22.06.png (196×481 px, 24 KB)

Related tickets

Relevant prototype commits:

Details

SubjectRepoBranchLines +/-
Add filtering for the suggested values combo boxmediawiki/extensions/VisualEditorwmf/1.37.0-wmf.1+1 -0
Add filtering for the suggested values combo boxmediawiki/extensions/VisualEditormaster+1 -0
Add a combo box for suggested values in the transclusion dialogmediawiki/extensions/VisualEditormaster+84 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

ECohen_WMDE created this task.Jan 13 2021, 10:28 AM
ECohen_WMDE added a parent task: T271897: Add suggested values parameter property to TemplateData and to TemplateData editor.
ECohen_WMDE moved this task from Backlog to In preparation on the WMDE-Templates-FocusArea board.Jan 13 2021, 10:31 AM
ECohen_WMDE edited projects, added VisualEditor-MediaWiki-Templates; removed Epic.
Restricted Application added a project: VisualEditor. · View Herald TranscriptJan 13 2021, 10:31 AM
Lena_WMDE removed a parent task: T271897: Add suggested values parameter property to TemplateData and to TemplateData editor.Jan 13 2021, 12:21 PM
Lena_WMDE added a subtask: T271897: Add suggested values parameter property to TemplateData and to TemplateData editor.
ECohen_WMDE updated the task description. (Show Details)Jan 13 2021, 4:15 PM
Esanders moved this task from To Triage to Triaged on the VisualEditor board.Jan 20 2021, 1:08 PM
Lena_WMDE renamed this task from DRAFT: Add combobox to VE to display suggested values to Add combobox to VE to display suggested values.Jan 27 2021, 2:13 PM
Lena_WMDE updated the task description. (Show Details)Jan 27 2021, 2:18 PM
Lena_WMDE set the point value for this task to 5.Jan 27 2021, 2:26 PM
matmarex added a project: Editing-team (Tracking).Jan 28 2021, 4:35 PM
Lena_WMDE moved this task from In preparation to Ready for pickup on the WMDE-Templates-FocusArea board.Jan 29 2021, 10:48 AM
Lena_WMDE added a project: WMDE-TechWish (Sprint-2021-02-03).Feb 4 2021, 10:08 AM
ECohen_WMDE moved this task from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.Feb 9 2021, 4:12 PM
thiemowmde updated the task description. (Show Details)Feb 11 2021, 12:00 PM
Lena_WMDE moved this task from In sprint to Ready for pickup on the WMDE-Templates-FocusArea board.Feb 16 2021, 9:02 AM
Lena_WMDE removed a project: WMDE-TechWish (Sprint-2021-02-03).
Lena_WMDE added a project: WMDE-TechWish-Sprint-2021-03-03.Mar 9 2021, 8:39 AM
Tobi_WMDE_SW added a project: Unplanned-Sprint-Work.Mar 10 2021, 1:46 PM
Andrew-WMDE claimed this task.Mar 11 2021, 8:29 AM
Andrew-WMDE moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2021-03-03 board.
gerritbot added a comment.Mar 11 2021, 4:19 PM

Change 670856 had a related patch set uploaded (by Andrew-WMDE; owner: Andrew-WMDE):
[mediawiki/extensions/VisualEditor@master] [WIP] Add a combo box for suggested values in the transclusion dialog

https://gerrit.wikimedia.org/r/670856

gerritbot added a project: Patch-For-Review.Mar 11 2021, 4:19 PM
Lena_WMDE moved this task from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.Mar 11 2021, 4:50 PM
ECohen_WMDE updated the task description. (Show Details)Mar 12 2021, 9:31 AM
Andrew-WMDE moved this task from Doing to Review on the WMDE-TechWish-Sprint-2021-03-03 board.Mar 12 2021, 10:04 AM
Lena_WMDE added a project: WMDE-TechWish-Sprint-2021-03-31.Mar 31 2021, 8:22 AM
Andrew-WMDE changed the point value for this task from 5 to 1.Mar 31 2021, 8:30 AM
Andrew-WMDE moved this task from Sprint Backlog to Review on the WMDE-TechWish-Sprint-2021-03-31 board.
awight removed Andrew-WMDE as the assignee of this task.Apr 8 2021, 8:25 AM
awight moved this task from Review to Sprint Backlog on the WMDE-TechWish-Sprint-2021-03-31 board.
awight added subscribers: Andrew-WMDE, awight.

Changes to implement after team discussion:

  • Only show suggested values combo for these types: Content, Line, String, Unknown, Number, unbalanced wikitext
  • For all other parameter types, even if the TemplateData API returns suggestedvalues, ignore these and do not show the combo box in the UI.
  • Re-add the feature flag from earlier patchsets, to control whether the suggested values element is shown at all. Default to false.
Andrew-WMDE claimed this task.Apr 8 2021, 12:23 PM
Andrew-WMDE moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2021-03-31 board.
Andrew-WMDE moved this task from Doing to Review on the WMDE-TechWish-Sprint-2021-03-31 board.Apr 8 2021, 2:36 PM
awight moved this task from Review to Demo on the WMDE-TechWish-Sprint-2021-03-31 board.Apr 9 2021, 10:14 AM
gerritbot added a comment.Apr 9 2021, 10:40 AM

Change 670856 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Add a combo box for suggested values in the transclusion dialog

https://gerrit.wikimedia.org/r/670856

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.1; 2021-04-13).Apr 9 2021, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 9 2021, 11:11 AM
awight added a comment.Apr 13 2021, 8:25 AM

Need to use the combo box component, so that typing auto-selected matching options.

awight closed subtask T271897: Add suggested values parameter property to TemplateData and to TemplateData editor as Resolved.Apr 13 2021, 8:29 AM
awight moved this task from Demo to Sprint Backlog on the WMDE-TechWish-Sprint-2021-03-31 board.
Lena_WMDE updated the task description. (Show Details)Apr 13 2021, 8:55 AM
Andrew-WMDE moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2021-03-31 board.Apr 14 2021, 8:33 AM
Lena_WMDE added a project: WMDE-TechWish-Sprint-2021-04-14.Apr 14 2021, 11:11 AM
Andrew-WMDE moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2021-04-14 board.Apr 14 2021, 11:12 AM
gerritbot added a comment.Apr 14 2021, 11:41 AM

Change 679316 had a related patch set uploaded (by Andrew-WMDE; author: Andrew-WMDE):

[mediawiki/extensions/VisualEditor@master] Add filtering for the suggested values combo box

https://gerrit.wikimedia.org/r/679316

gerritbot added a project: Patch-For-Review.Apr 14 2021, 11:41 AM
gerritbot added a comment.Apr 14 2021, 1:04 PM

Change 679316 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Add filtering for the suggested values combo box

https://gerrit.wikimedia.org/r/679316

Andrew-WMDE moved this task from Doing to Review on the WMDE-TechWish-Sprint-2021-04-14 board.Apr 14 2021, 1:47 PM
ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.3; 2021-04-27); removed MW-1.37-notes (1.37.0-wmf.1; 2021-04-13).Apr 14 2021, 2:00 PM
WMDE-Fisch removed projects: Patch-For-Review, Unplanned-Sprint-Work.Apr 15 2021, 7:23 AM
WMDE-Fisch moved this task from Review to Demo on the WMDE-TechWish-Sprint-2021-04-14 board.
gerritbot added a comment.Apr 15 2021, 12:02 PM

Change 679462 had a related patch set uploaded (by WMDE-Fisch; author: Andrew-WMDE):

[mediawiki/extensions/VisualEditor@wmf/1.37.0-wmf.1] Add filtering for the suggested values combo box

https://gerrit.wikimedia.org/r/679462

gerritbot added a project: Patch-For-Review.Apr 15 2021, 12:02 PM
WMDE-Fisch subscribed.Apr 15 2021, 12:09 PM

Backport scheduled for Monday 1pm https://wikitech.wikimedia.org/w/index.php?title=Deployments&type=revision&diff=1908197&oldid=1908185

gerritbot added a comment.Apr 20 2021, 11:34 AM

Change 679462 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.37.0-wmf.1] Add filtering for the suggested values combo box

https://gerrit.wikimedia.org/r/679462

Stashbot added a comment.Apr 20 2021, 11:38 AM

Mentioned in SAL (#wikimedia-operations) [2021-04-20T11:38:25Z] <wmde-fisch@deploy1002> Synchronized php-1.37.0-wmf.1/extensions/VisualEditor/modules/ve-mw/ui/pages/ve.ui.MWParameterPage.js: Backport: [[gerrit:679462|Add filtering for the suggested values combo box (T271898)]] (duration: 00m 58s)

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.1; 2021-04-13); removed MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 20 2021, 12:00 PM
Lena_WMDE moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-04-14 board.Apr 27 2021, 8:38 AM
Lena_WMDE closed this task as Resolved.Apr 27 2021, 8:40 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL