Page MenuHomePhabricator

Request a performance review
Closed, ResolvedPublic

Description

Since this extension affects potentially every logged-in page load, we should request a performance review prior to deployment. We expect to deploy in Q4 and performance reviews must be filed at least 21 days before the start of the quarter. This gives us until early March to make the request.

Filing a performance review requires filling out a form. The form requests a way to test the extension without further edits being required. Since the testers might not meet the edit count threshold, how can we allow them to receive it without additional work?

The form also has the following questions:

  • What work has been done to ensure the best possible performance of the feature?
  • What are likely to be the weak areas (e.g. bottlenecks) of the code in terms of performance?
  • Are there potential optimisations that haven't been performed yet?
  • Please list which performance measurements are in place for the feature and/or what you've measured ad-hoc so far. If you are unsure what to measure, ask the Performance Team for advice: performance-team@wikimedia.org.

Filed at T275774.

Event Timeline

This doesn't need to happen until early March, probably after we've done the other work.

Samwalton9-WMF raised the priority of this task from Low to High.Feb 23 2021, 4:02 PM

This needs to happen before the end of next week (March 5th) to qualify for Q4. Unfortunately we might not have all of our work done by that point (or potentially even the start of the quarter), but we should get this filed provisionally anyway and just be clear about that. That way we can ensure it's on the team's radar for the quarter.

@jsn.sherman I think we're ready to move forward with requesting that performance review. I'm reopening this and moving it back to ready to remind us to update the ticket.

Updated the app with current information (still marked as placeholder) and reached out to the performance team. Got followup info on the task, which I'm currently reading through.

Okay, I've posted up followup questions on that task