Page MenuHomePhabricator

PHP Fatal Error: Cannot redeclare Wikibase\MediaInfo\Search\closureToAnonymousClass() (previously declared in /srv/mediawiki/php-1.36.0-wmf.26/extensions/WikibaseMediaInfo/src/Search/MediaSearchProfiles.php:24)
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error

MediaWiki version: 1.36.0-wmf.26

message
PHP Fatal Error: Cannot redeclare Wikibase\MediaInfo\Search\closureToAnonymousClass() (previously declared in /srv/mediawiki/php-1.36.0-wmf.26/extensions/WikibaseMediaInfo/src/Search/MediaSearchProfiles.php:24)

Impact

Notes

A couple of these happened after I promoted train to group1. Sounds like a programming error to me, and so I'm treating this as a train blocker. If I'm wrong about that, please tell me or lower priority.

Details

Request ID
X-7-dApAAD8AAHac5ioAAABU
Request URL
https://commons.wikimedia.org/w/index.php?search=spl%C3%BCia+ticino+houses&title=Special%3ASearch&profile=advanced&fulltext=1&advancedSearch-current=%7B%7D&ns0=1
Stack Trace
exception.trace
#0 /srv/mediawiki/php-1.36.0-wmf.26/extensions/CirrusSearch/includes/Profile/ArrayProfileRepository.php(63): require()
#1 [internal function]: CirrusSearch\Profile\ArrayProfileRepository::CirrusSearch\Profile\{closure}()
#2 /srv/mediawiki/php-1.36.0-wmf.26/extensions/CirrusSearch/includes/Profile/ArrayProfileRepository.php(128): call_user_func()
#3 /srv/mediawiki/php-1.36.0-wmf.26/extensions/CirrusSearch/includes/Profile/ArrayProfileRepository.php(116): CirrusSearch\Profile\ArrayProfileRepository->getProfiles()
#4 /srv/mediawiki/php-1.36.0-wmf.26/extensions/CirrusSearch/includes/Profile/SearchProfileService.php(188): CirrusSearch\Profile\ArrayProfileRepository->hasProfile()
#5 /srv/mediawiki/php-1.36.0-wmf.26/extensions/CirrusSearch/includes/Profile/SearchProfileService.php(265): CirrusSearch\Profile\SearchProfileService->hasProfile()
#6 /srv/mediawiki/php-1.36.0-wmf.26/extensions/CirrusSearch/includes/Search/SearchContext.php(717): CirrusSearch\Profile\SearchProfileService->getProfileName()
#7 /srv/mediawiki/php-1.36.0-wmf.26/extensions/CirrusSearch/includes/Searcher.php(304): CirrusSearch\Search\SearchContext->getFulltextQueryBuilderProfile()
#8 /srv/mediawiki/php-1.36.0-wmf.26/extensions/CirrusSearch/includes/Searcher.php(321): CirrusSearch\Searcher->buildFullTextSearch()
#9 /srv/mediawiki/php-1.36.0-wmf.26/extensions/CirrusSearch/includes/Searcher.php(214): CirrusSearch\Searcher->searchTextInternal()
#10 /srv/mediawiki/php-1.36.0-wmf.26/extensions/CirrusSearch/includes/Fallbacks/FallbackMethodTrait.php(107): CirrusSearch\Searcher->search()
#11 /srv/mediawiki/php-1.36.0-wmf.26/extensions/CirrusSearch/includes/Fallbacks/PhraseSuggestFallbackMethod.php(128): CirrusSearch\Fallbacks\PhraseSuggestFallbackMethod->maybeSearchAndRewrite()
#12 /srv/mediawiki/php-1.36.0-wmf.26/extensions/CirrusSearch/includes/Fallbacks/FallbackRunner.php(214): CirrusSearch\Fallbacks\PhraseSuggestFallbackMethod->rewrite()
#13 /srv/mediawiki/php-1.36.0-wmf.26/extensions/CirrusSearch/includes/Fallbacks/FallbackRunner.php(157): CirrusSearch\Fallbacks\FallbackRunner->execute()
#14 /srv/mediawiki/php-1.36.0-wmf.26/extensions/CirrusSearch/includes/Searcher.php(381): CirrusSearch\Fallbacks\FallbackRunner->run()
#15 /srv/mediawiki/php-1.36.0-wmf.26/extensions/CirrusSearch/includes/Searcher.php(214): CirrusSearch\Searcher->searchTextInternal()
#16 /srv/mediawiki/php-1.36.0-wmf.26/extensions/CirrusSearch/includes/CirrusSearch.php(295): CirrusSearch\Searcher->search()
#17 /srv/mediawiki/php-1.36.0-wmf.26/extensions/CirrusSearch/includes/CirrusSearch.php(268): CirrusSearch\CirrusSearch->searchTextReal()
#18 /srv/mediawiki/php-1.36.0-wmf.26/includes/search/SearchEngine.php(95): CirrusSearch\CirrusSearch->doSearchText()
#19 /srv/mediawiki/php-1.36.0-wmf.26/includes/search/SearchEngine.php(187): SearchEngine->{closure}()
#20 /srv/mediawiki/php-1.36.0-wmf.26/includes/search/SearchEngine.php(96): SearchEngine->maybePaginate()
#21 /srv/mediawiki/php-1.36.0-wmf.26/includes/specials/SpecialSearch.php(452): SearchEngine->searchText()
#22 /srv/mediawiki/php-1.36.0-wmf.26/includes/specials/SpecialSearch.php(236): SpecialSearch->showResults()
#23 /srv/mediawiki/php-1.36.0-wmf.26/includes/specialpage/SpecialPage.php(645): SpecialSearch->execute()
#24 /srv/mediawiki/php-1.36.0-wmf.26/includes/specialpage/SpecialPageFactory.php(1405): SpecialPage->run()
#25 /srv/mediawiki/php-1.36.0-wmf.26/includes/MediaWiki.php(310): MediaWiki\SpecialPage\SpecialPageFactory->executePath()
#26 /srv/mediawiki/php-1.36.0-wmf.26/includes/MediaWiki.php(944): MediaWiki->performRequest()
#27 /srv/mediawiki/php-1.36.0-wmf.26/includes/MediaWiki.php(548): MediaWiki->main()
#28 /srv/mediawiki/php-1.36.0-wmf.26/index.php(53): MediaWiki->run()
#29 /srv/mediawiki/php-1.36.0-wmf.26/index.php(46): wfIndexMain()
#30 /srv/mediawiki/w/index.php(3): require()

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Jan 13, 2:16 PM
LarsWirzenius triaged this task as Unbreak Now! priority.Wed, Jan 13, 2:16 PM
LarsWirzenius updated the task description. (Show Details)

Added WMDE tag, in the hope of getting attention to this train blocker.

greg added a subscriber: greg.

Adding some tags to get WMDE attention. Help please :)

Restricted Application added a project: Wikidata. · View Herald TranscriptWed, Jan 13, 4:36 PM

Looking ...

Change 655917 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/WikibaseMediaInfo@master] Guard against this file being included twice

https://gerrit.wikimedia.org/r/655917

Change 655926 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.36.0-wmf.26] Guard against this file being included twice

https://gerrit.wikimedia.org/r/655926

Change 655926 abandoned by Cparle:
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.36.0-wmf.26] Guard against this file being included twice

Reason:

https://gerrit.wikimedia.org/r/655926

Change 655926 restored by Cparle:
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.36.0-wmf.26] Guard against this file being included twice

https://gerrit.wikimedia.org/r/655926

Change 655919 had a related patch set uploaded (by Matthias Mullie; owner: Cparle):
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.36.0-wmf.26] Guard against this file being included twice

https://gerrit.wikimedia.org/r/655919

Change 655927 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.35.0-wmf.26] Guard against this file being included twice

https://gerrit.wikimedia.org/r/655927

Change 655926 abandoned by Cparle:
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.36.0-wmf.26] Guard against this file being included twice

Reason:

https://gerrit.wikimedia.org/r/655926

Change 655917 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Guard against this file being included twice

https://gerrit.wikimedia.org/r/655917

Change 655919 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.36.0-wmf.26] Guard against this file being included twice

https://gerrit.wikimedia.org/r/655919

@hashar patch merged to the branch that we think will fix it

I guess this needs someone to backport it for the current train?

patch merged to the branch that we think will fix it

For future reference, patches must not be merged in wmf unless they are currently being deployed by the person merging it. The branch is meant to reflect current production. To schedule or propose a patch for deployment, creating the cherry pick suffices, possibly using backport windows on the Deployment calendar to request someone else to deploy it (if not yourself).

Mentioned in SAL (#wikimedia-operations) [2021-01-13T19:42:11Z] <thcipriani@deploy1001> Synchronized php-1.36.0-wmf.26/extensions/WikibaseMediaInfo/src/Search/MediaSearchProfiles.php: [[gerrit:655919|Guard against this file being included twice]] T271933 (duration: 01m 04s)

Mentioned in SAL (#wikimedia-operations) [2021-01-13T19:47:46Z] <thcipriani@deploy1001> Synchronized php-1.36.0-wmf.26/extensions/WikibaseMediaInfo/src/Search/MediaSearchProfiles.php: [[gerrit:655919|Guard against this file being included twice]] T271933 (for real -- forgot to submodule update) (duration: 01m 04s)

patch merged to the branch that we think will fix it

For future reference, patches must not be merged in wmf unless they are currently being deployed by the person merging it. The branch is meant to reflect current production. To schedule or propose a patch for deployment, creating the cherry pick suffices, possibly using backport windows on the Deployment calendar to request someone else to deploy it (if not yourself).

Aha ok, got it, thanks @Krinkle Hope I haven't screwed anything up

Since @thcipriani pushed this to production yesterday, I'm closing the task.

LarsWirzenius closed this task as Resolved.Thu, Jan 14, 12:32 PM
LarsWirzenius claimed this task.

To boldly close what no one has closed before.

Change 655927 abandoned by Matthias Mullie:
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.35.0-wmf.26] Guard against this file being included twice

Reason:
IIRC, this is the invalid cherry-pick, and we landed I5b7cdcfbf40a569691663c5a4c08de50cf1def0d instead.

https://gerrit.wikimedia.org/r/655927