Page MenuHomePhabricator

(MS 3) Use the DS NumberInput component and add validation to the Limit component
Open, LowPublic

Description

The current TextInput comonent for the number of results in the Limit component allows any text to be entered. That is obviously not ideal and it should only allow numbers.

Such a NumberInput (T275010) will be developed in the Design System. When that component is available in the Design System, evaluate whether it is suitable for the Limit component and use it if it is. That will also be the right moment to add a proper validation and error messages.

acceptance criteria:

  • Evaluate if the Design System NumberInput is suitable for the Limit component
    • use it if it is
    • figure out something else if it isn't
  • add validation to the Limit in Query-Builder (details TBD when we know more about the capabilities of the NumberInput)

Event Timeline

amy_rc renamed this task from Use the DS NumberInput component and add validation to the Limit component to (MS 3) Use the DS NumberInput component and add validation to the Limit component.Jan 18 2021, 2:38 PM
amy_rc triaged this task as High priority.
Lydia_Pintscher lowered the priority of this task from High to Low.Feb 16 2021, 9:19 AM

Change 673549 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[wikidata/query-builder@master] feat: add validation to Limit component

https://gerrit.wikimedia.org/r/673549

Change 673549 merged by jenkins-bot:
[wikidata/query-builder@master] feat: add validation to Limit component

https://gerrit.wikimedia.org/r/673549