Page MenuHomePhabricator
Create Task
Maniphest T271956

De-emphasise line numbers when showing code
Closed, ResolvedPublic
Actions

Description

Raised in T32773#6740887.

As used when editing (CodeEditor) and viewing (SyntaxHighlight) js/css pages.

Line numbers are currently ~Base10, the same as the base colour use for the code. They should be a more muted Base30 to make them more visually distinct from the code.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
De-emphasise line numbersmediawiki/extensions/CodeEditormaster+9 -0
De-emphasise line numbersmediawiki/extensions/SyntaxHighlight_GeSHimaster+4 -3
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Jan 13 2021, 4:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 13 2021, 4:48 PM
Esanders mentioned this in T32773: Enable line numbers for pages handled by SyntaxHighlight.Jan 13 2021, 4:53 PM
gerritbot added a comment.Jan 13 2021, 4:55 PM

Change 655918 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] De-emphasise line numbers

https://gerrit.wikimedia.org/r/655918

gerritbot added a project: Patch-For-Review.Jan 13 2021, 4:55 PM
gerritbot added a comment.Jan 13 2021, 5:07 PM

Change 655921 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/CodeEditor@master] De-emphasise line numbers

https://gerrit.wikimedia.org/r/655921

Od1n awarded a token.Jan 13 2021, 5:48 PM
Esanders updated the task description. (Show Details)Jan 14 2021, 12:06 PM
Esanders added a subscriber: ECohen_WMDE.
Esanders renamed this task from De-emphasise line numbers when printing code to De-emphasise line numbers when showing code.Jan 14 2021, 12:11 PM
Esanders updated the task description. (Show Details)
gerritbot added a comment.Jan 14 2021, 5:40 PM

Change 655918 merged by jenkins-bot:
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] De-emphasise line numbers

https://gerrit.wikimedia.org/r/655918

gerritbot added a comment.Jan 14 2021, 5:44 PM

Change 655921 merged by jenkins-bot:
[mediawiki/extensions/CodeEditor@master] De-emphasise line numbers

https://gerrit.wikimedia.org/r/655921

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.27; 2021-01-19).Jan 14 2021, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 14 2021, 6:10 PM
Esanders mentioned this in rESHG8d645a385c5e: De-emphasise line numbers.Jan 14 2021, 6:23 PM
Od1n subscribed.Jan 23 2021, 7:43 PM

Thanks, though I think it's still a bit too emphasized. How about the Base50 #a2a9b1, or at very least Base40 #8a9097?

ECohen_WMDE mentioned this in T267911: Add line numbering to syntax highlighting (CodeMirror extension).Feb 18 2021, 8:45 AM
TheDJ closed this task as Resolved.Aug 11 2025, 11:16 AM
TheDJ assigned this task to Esanders.
TheDJ subscribed.

This was clearly done, although possibly not to everyone's satisfaction. But I've not heard many complaints since the change, so calling this done, and new tickets can be filed separately.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits