Maniphest T271975

Convert EditPage to Authority
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Pchelolo
	Jan 13 2021, 7:48 PM

Tags

Referenced Files

None

Subscribers

Description

EditPage should use authority provided by context instead of User and PermissionManager.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	editpage: Refactor user right, rate limit and block checks to use Authority	mediawiki/core	master	+292 -602
	WIP: Convert EditPage to Authority	mediawiki/core	master	+107 -45

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T218674 User::getRights() applies session rights restrictions to non-session users
		Resolved		None	T180888 All permission checks should be able to return a custom error message
		Open		None	T231930 Introduce Authority objects to represent the user performing a given action
		Resolved		matmarex	T271975 Convert EditPage to Authority
		Resolved		None	T271977 Convert EditConstraint system to use Authority

Event Timeline

• Pchelolo created this task.Jan 13 2021, 7:48 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 13 2021, 7:48 PM

• Pchelolo moved this task from Unsorted pile to Authority pile on the Platform Team Workboards (MW Expedition) board.Jan 13 2021, 7:51 PM

Change 655967 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] WIP: Convert EditPage to Authority

https://gerrit.wikimedia.org/r/655967

gerritbot added a project: Patch-For-Review.Jan 13 2021, 7:53 PM

• Pchelolo claimed this task.Jan 15 2021, 4:00 PM

• Pchelolo merged a task: T271465: Use Authority in EditPage.

• Pchelolo moved this task from Authority pile to Blocked on the Platform Team Workboards (MW Expedition) board.

• Pchelolo triaged this task as Low priority.Jan 19 2021, 6:26 PM

• Pchelolo moved this task from Blocked to Authority pile on the Platform Team Workboards (MW Expedition) board.Feb 3 2021, 6:15 PM

• Pchelolo closed subtask T271977: Convert EditConstraint system to use Authority as Resolved.Mar 22 2021, 10:57 PM

Change 655967 abandoned by Ppchelko:

[mediawiki/core@master] WIP: Convert EditPage to Authority

Reason:

too much have changed since this experiment

https://gerrit.wikimedia.org/r/655967

Maintenance_bot removed a project: Patch-For-Review.Jul 19 2021, 11:10 PM

Removing inactive assignee (Platform Engineering: Please unassign tasks of previous team members.)

Aklapper added a project: MediaWiki-Page-editing.Oct 9 2023, 5:45 PM

Change #1121716 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] editpage: Refactor user right, rate limit and block checks to use Authority

https://gerrit.wikimedia.org/r/1121716

gerritbot added a project: Patch-For-Review.Feb 21 2025, 11:46 PM

matmarex claimed this task.Feb 27 2025, 10:22 PM

Change #1121716 merged by jenkins-bot:

[mediawiki/core@master] editpage: Refactor user right, rate limit and block checks to use Authority

https://gerrit.wikimedia.org/r/1121716

Maintenance_bot removed a project: Patch-For-Review.Apr 6 2025, 8:30 PM

There are some bits and bobs still using PermissionManager, but this is basically done.