If a constraint has PermissionManager injected, instead we need to change it to accept Authority instead of User and remove PermissionManager dependency.
Calls to PermissionManager should be changed to corresponding calls to Authority.
Tests should be updated - no longer need to mock PermissionManager, but instead SimpleAuthority (with real UserIdentityValue, no need to mock it) with appropriate permissions should be passed.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Update creation of edit constraints following switch to Authority | mediawiki/core | master | +12 -87 | |
| Convert EditConstraints to Authority | mediawiki/core | master | +171 -308 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T218674 User::getRights() applies session rights restrictions to non-session users | |||
| Open | None | T180888 All permission checks should be able to return a custom error message | |||
| Open | None | T231930 Introduce Authority objects to represent the user performing a given action | |||
| Open | None | T271975 Convert EditPage to Authority | |||
| Resolved | None | T271977 Convert EditConstraint system to use Authority |
Can I suggest waiting to do this until after https://gerrit.wikimedia.org/r/c/mediawiki/core/+/649916 is merged?
It's not urgent in any way. Should be trivial and quite independent though, so not necessary to block too much.
Change 667952 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] Convert EditConstraints to Authority
Change 667952 merged by jenkins-bot:
[mediawiki/core@master] Convert EditConstraints to Authority
Change 674116 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Update creation of edit constraints following switch to Authority
Change 674116 merged by jenkins-bot:
[mediawiki/core@master] Update creation of edit constraints following switch to Authority