Page MenuHomePhabricator
Create Task
Maniphest T271978

PHP Notice: Undefined index: edit (CologneBlueHooks.php)
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error message
[X-8w1wpAAEUAACjBV1AAAACP] /wiki/Special:NewFiles   ErrorException from line 147 of /srv/mediawiki/php-1.36.0-wmf.26/skins/CologneBlue/includes/CologneBlueHooks.php: PHP Notice: Undefined index: edit

/srv/mediawiki/php-1.36.0-wmf.26/skins/CologneBlue/includes/CologneBlueHooks.php:147
Stack Trace
#0 /srv/mediawiki/php-1.36.0-wmf.26/skins/CologneBlue/includes/CologneBlueHooks.php(147): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.36.0-wmf.26/includes/HookContainer/HookContainer.php(333): CologneBlueHooks::onSkinTemplateNavigationUniversal(SkinCologneBlue, array)
#2 /srv/mediawiki/php-1.36.0-wmf.26/includes/HookContainer/HookContainer.php(140): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#3 /srv/mediawiki/php-1.36.0-wmf.26/includes/HookContainer/HookRunner.php(3590): MediaWiki\HookContainer\HookContainer->run(string, array, array)
#4 /srv/mediawiki/php-1.36.0-wmf.26/includes/skins/SkinTemplate.php(1130): MediaWiki\HookContainer\HookRunner->onSkinTemplateNavigation__Universal(SkinCologneBlue, array)
#5 /srv/mediawiki/php-1.36.0-wmf.26/includes/skins/SkinMustache.php(198): SkinTemplate->buildContentNavigationUrls()
#6 /srv/mediawiki/php-1.36.0-wmf.26/includes/skins/SkinMustache.php(190): SkinMustache->getPortletsTemplateData()
#7 /srv/mediawiki/php-1.36.0-wmf.26/skins/CologneBlue/includes/SkinCologneBlue.php(60): SkinMustache->getTemplateData()
#8 /srv/mediawiki/php-1.36.0-wmf.26/includes/skins/SkinMustache.php(128): SkinCologneBlue->getTemplateData()
#9 /srv/mediawiki/php-1.36.0-wmf.26/includes/skins/SkinTemplate.php(146): SkinMustache->generateHTML()
#10 /srv/mediawiki/php-1.36.0-wmf.26/includes/OutputPage.php(2626): SkinTemplate->outputPage()
#11 /srv/mediawiki/php-1.36.0-wmf.26/includes/MediaWiki.php(951): OutputPage->output(boolean)
#12 /srv/mediawiki/php-1.36.0-wmf.26/includes/MediaWiki.php(964): MediaWiki->{closure}()
#13 /srv/mediawiki/php-1.36.0-wmf.26/includes/MediaWiki.php(548): MediaWiki->main()
#14 /srv/mediawiki/php-1.36.0-wmf.26/index.php(53): MediaWiki->run()
#15 /srv/mediawiki/php-1.36.0-wmf.26/index.php(46): wfIndexMain()
#16 /srv/mediawiki/w/index.php(3): require(string)
#17 {main}
Impact
  1. Notes

Details

Request ID
X-8w1wpAAEUAACjBV1AAAACP
Request URL
/wiki/Special:NewFiles
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Hide empty portlets and apply standard portlet classes to portletsmediawiki/skins/CologneBluemaster+14 -6
Edit link may not be present, avoid undefined index noticemediawiki/skins/CologneBluewmf/1.36.0-wmf.26+9 -3
Edit link may not be present, avoid undefined index noticemediawiki/skins/CologneBluemaster+9 -3
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedRelease• LarsWirzeniusT267419 1.36.0-wmf.26 deployment blockers
 ResolvedPRODUCTION ERRORJdlrobsonT271978 PHP Notice: Undefined index: edit (CologneBlueHooks.php)

Event Timeline

• holger.knust created this task.Jan 13 2021, 7:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 13 2021, 7:54 PM
Krinkle renamed this task from PHP Notice: Undefined index: edit to PHP Notice: Undefined index: edit (CologneBlueHooks.php).Jan 13 2021, 7:54 PM
Krinkle added projects: Web-Team-Backlog-Archived, CologneBlue.
Krinkle added a parent task: T267419: 1.36.0-wmf.26 deployment blockers.
Krinkle added subscribers: Jdlrobson, Krinkle.

Regression, most likely caused by one of these two recent commits:

Krinkle moved this task from Untriaged to Jan 2021 on the Wikimedia-production-error board.Jan 13 2021, 7:58 PM
gerritbot added a comment.Jan 13 2021, 8:12 PM

Change 655971 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/CologneBlue@master] Edit link may not be present, avoid undefined index notice

https://gerrit.wikimedia.org/r/655971

gerritbot added a project: Patch-For-Review.Jan 13 2021, 8:12 PM
Jdlrobson claimed this task.Jan 13 2021, 8:12 PM
gerritbot added a comment.Jan 13 2021, 9:02 PM

Change 655971 merged by jenkins-bot:
[mediawiki/skins/CologneBlue@master] Edit link may not be present, avoid undefined index notice

https://gerrit.wikimedia.org/r/655971

matmarex subscribed.Jan 13 2021, 9:08 PM

This causes a visual bug in the interface too – there's a non-functional "Edit this page" text in the sidebar on special pages, e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Special:NewFiles?useskin=cologneblue.

image.png (2×3 px, 1 MB)

It should disappear when the patch is deployed.

Maintenance_bot removed a project: Patch-For-Review.Jan 13 2021, 9:10 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.27; 2021-01-19).Jan 13 2021, 10:00 PM
gerritbot added a comment.Jan 13 2021, 10:45 PM

Change 655932 had a related patch set uploaded (by Krinkle; owner: Jdlrobson):
[mediawiki/skins/CologneBlue@wmf/1.36.0-wmf.26] Edit link may not be present, avoid undefined index notice

https://gerrit.wikimedia.org/r/655932

gerritbot added a project: Patch-For-Review.Jan 13 2021, 10:45 PM
• LarsWirzenius subscribed.Jan 14 2021, 12:33 PM

These changes haven't been pushed to production, have they?

hashar subscribed.Jan 14 2021, 1:20 PM

<rant>I am surprised we still maintain CologneBlue, at one point for sure we would have to phase it out entirely.</rant>

Regardless, in agreement with Lars, I am handling the deployment of this. Given the fix is straightforward and there is an easy way to validate the fix, I feel confident deploying/verifying it by myself.

gerritbot added a comment.Jan 14 2021, 1:22 PM

Change 655932 merged by jenkins-bot:
[mediawiki/skins/CologneBlue@wmf/1.36.0-wmf.26] Edit link may not be present, avoid undefined index notice

https://gerrit.wikimedia.org/r/655932

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.26; 2021-01-12); removed MW-1.36-notes (1.36.0-wmf.27; 2021-01-19).Jan 14 2021, 2:00 PM
Stashbot added a comment.Jan 14 2021, 2:06 PM

Mentioned in SAL (#wikimedia-operations) [2021-01-14T14:06:04Z] <hashar@deploy1001> Synchronized php-1.36.0-wmf.26/skins/CologneBlue/includes/CologneBlueHooks.php: Edit link may not be present, avoid undefined index notice T271978 (duration: 01m 07s)

hashar added a comment.Jan 14 2021, 2:06 PM
In T271978#6745912, @matmarex wrote:

This causes a visual bug in the interface too – there's a non-functional "Edit this page" text in the sidebar on special pages, e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Special:NewFiles?useskin=cologneblue.

image.png (2×3 px, 1 MB)

It should disappear when the patch is deployed.

I could not reproduce that on production targeting en.wikipedia.org either before or after applying the patch. It is a mystery to me.

I have deployed the change everywhere. Should be good now.

phuedx moved this task from Incoming to Tracking on the Web-Team-Backlog-Archived board.Jan 14 2021, 2:10 PM
phuedx edited projects, added Web-Team-Backlog-Archived (Tracking); removed Web-Team-Backlog-Archived.
Maintenance_bot removed a project: Patch-For-Review.Jan 14 2021, 2:10 PM
• LarsWirzenius closed this task as Resolved.Jan 14 2021, 2:14 PM

Thank you @hashar. Closing task.

hashar reopened this task as Open.Jan 14 2021, 2:27 PM

And trying again on https://en.wikipedia.org/wiki/Special:NewFiles?useskin=cologneblue , there is indeed an Edit this page link in the toolbar with the tooltip stating: This is a special page which you cannot edit.

edit special page.png (263×165 px, 16 KB)

I guess Special:NewFiles output or the toolbar is cached somehow and when I tried via mwdebug it was serving the cached page regardless of the CologneBlue patch. Bah.

Reopen for the glitch.

RhinosF1 subscribed.Jan 14 2021, 3:29 PM

Should this be UBN as train blocking?

Jdlrobson added a comment.EditedJan 14 2021, 3:31 PM

No. It's cologne blue so no ubn.

I can take a look at the glitch. I've been trying to simplify the code in that repo.

Note: we don't show Cologne Blue in preferences and are slowly in the phase of phasing it out https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-rendering so CologneBlue bugs should only block deploys if they throw production errors.

gerritbot added a comment.Jan 14 2021, 6:23 PM

Change 656235 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/CologneBlue@master] Hide empty portlets

https://gerrit.wikimedia.org/r/656235

gerritbot added a project: Patch-For-Review.Jan 14 2021, 6:23 PM
Jdlrobson closed this task as Resolved.Jan 14 2021, 6:29 PM
Jdlrobson mentioned this in T272064: Empty portlets should be hidden on Cologneblue.

I'm closing this as the new issue reported has nothing to do with this one. See T272064

gerritbot added a comment.Jan 14 2021, 6:41 PM

Change 656235 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/CologneBlue@master] Hide empty portlets and apply standard portlet classes to portlets

https://gerrit.wikimedia.org/r/656235

gerritbot added a comment.Jan 15 2021, 6:45 AM

Change 656235 merged by jenkins-bot:
[mediawiki/skins/CologneBlue@master] Hide empty portlets and apply standard portlet classes to portlets

https://gerrit.wikimedia.org/r/656235

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.27; 2021-01-19); removed MW-1.36-notes (1.36.0-wmf.26; 2021-01-12).Jan 15 2021, 7:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits