Page MenuHomePhabricator

Move LazyVariableComputer::getLastPageAuthors to MW core
Open, Needs TriagePublic


It should probably belong to RevisionStore, and I'd say certainly not to AbuseFilter. RevisionStore::getAuthorsBetween already exists, but cannot be adapted to our use case without creating potentially-destructive queries. Also, getLastPageAuthors is not guaranteed to return the last 10 authors, but just "at most 10", even if more than 10 authors exist; in particular, it returns the last 10 authors (at most) from the last 100 revisions. All of this should be taken into account when moving the method to MW core. The past DBA analysis done in T116557 should also be accounted for. Note that the situation might have changed today (with the revision/actor table schema change), and is likely to change again (when revision_actor_temp is merged into revision).