Maniphest T272053

(MS 2) Make the last condition removable as well
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Charlie_WMDE
	Jan 14 2021, 5:09 PM

Description

As a query builder I want to be able to remove the remaining query in order to quickly start over

Problem:
Currently, when only one condition is remaining, the delete button gets disabled which is inconsistent with the previous behavior. This can be confusing and also a hindrance when trying to remove a prior query.

Example:

mockups

BDD
GIVEN a visual query with only one condition
WHEN clicking the trash can icon
THEN the condition is removed
AND the space of the condition is replaced with a place holder text

Acceptance criteria:

remove the disabled state of the trashcan (last condition can be deleted as well)
when no condition remains, a placeholder text becomes visible (see figma specs)

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Michael	T268982 (MS 2) remove a query block/condition
		Resolved		Ladsgroup	T272053 (MS 2) Make the last condition removable as well

Event Timeline

Charlie_WMDE created this task.Jan 14 2021, 5:09 PM

Restricted Application added a project: Wikidata. · View Herald TranscriptJan 14 2021, 5:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Charlie_WMDE renamed this task from Make the last condition removable as well to (MS 2) Make the last condition removable as well.Jan 14 2021, 5:10 PM

Charlie_WMDE mentioned this in T268982: (MS 2) remove a query block/condition.

Charlie_WMDE added a parent task: T268982: (MS 2) remove a query block/condition.

Charlie_WMDE moved this task from Incoming to Backlog on the Wikidata Query Builder board.

Lydia_Pintscher updated the task description. (Show Details)Jan 18 2021, 11:26 AM

Michael moved this task from Backlog to Ready to pick up on the Wikidata Query Builder board.Jan 18 2021, 2:13 PM

Devouring the cookie: https://github.com/wmde/query-builder/pull/161

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJan 18 2021, 10:39 PM

Ladsgroup moved this task from To Do to Peer Review on the Wikidata Query Builder (Wikidata Query Builder - sprint 6) board.Jan 18 2021, 10:40 PM

guergana.tzatchkova moved this task from Peer Review to Test (Verification) on the Wikidata Query Builder (Wikidata Query Builder - sprint 6) board.Jan 19 2021, 11:03 AM

Lydia_Pintscher moved this task from Wikidata Query Builder - sprint 6 to Test (Verification) on the Wikidata Query Builder board.Jan 21 2021, 8:32 AM

Lydia_Pintscher edited projects, added Wikidata Query Builder; removed Wikidata Query Builder (Wikidata Query Builder - sprint 6).

\o/
@Charlie_WMDE Please close if it's also good from your side.

@Ladsgroup looks good but all the spacing is 14px instead of 16px(dimension-layout-xsmall) for some reason. is that some firefox issue?

The style is:

.querybuilder__condition-placeholder {
	margin-block: $dimension-layout-xsmall;
	padding-block: $dimension-layout-xsmall;
}

Which in turn becomes 1em in the output. Normally it's 16px but I assume given that the font-size is .875em, the computed em value also changes to 14px. (16*.875=14)

I'm not good at frontend stuff but this from https://www.w3.org/Style/Examples/007/units.en.html so I might be wrong:

The em and ex units depend on the font and may be different for each element in the document. The em is simply the font size.

okay, that makes sense! thanks for looking into it. closing this ticket now \o/

Maintenance_bot moved this task from Incoming to Done on the User-Ladsgroup board.Jan 21 2021, 1:15 PM

• amy_rc moved this task to Done on the Wikidata Query Builder board.Feb 17 2021, 9:02 AM

(MS 2) Make the last condition removable as wellClosed, ResolvedPublicActions

Description

Related ObjectsSearch...

Event Timeline

(MS 2) Make the last condition removable as well
Closed, ResolvedPublic
Actions

Related Objects
Search...