Page MenuHomePhabricator

Update wgSFSIPListLocation and wgSFSIPListLocationMD5 defaults within StopForumSpam's extension.json
Closed, ResolvedPublic

Description

Largely to make the extension easier to configure out of the box and to use with little friction within various test environments, such as patchdemo.

Event Timeline

sbassett renamed this task from Add global variable defaults within StopForumSpam's extension.json to Add additional global variable defaults within StopForumSpam's extension.json.Jan 14 2021, 5:48 PM
sbassett triaged this task as Low priority.
sbassett moved this task from Backlog to In Progress on the MediaWiki-extensions-StopForumSpam board.
sbassett moved this task from Backlog to In Progress on the user-sbassett board.
sbassett renamed this task from Add additional global variable defaults within StopForumSpam's extension.json to Update certain global variable defaults within StopForumSpam's extension.json.Jan 14 2021, 5:51 PM

Change 656224 had a related patch set uploaded (by SBassett; owner: SBassett):
[mediawiki/extensions/StopForumSpam@master] Update wgSFSIPListLocation and wgSFSIPListLocationMD5 defaults

https://gerrit.wikimedia.org/r/656224

sbassett renamed this task from Update certain global variable defaults within StopForumSpam's extension.json to Update wgSFSIPListLocation and wgSFSIPListLocationMD5 defaults within StopForumSpam's extension.json.Jan 14 2021, 6:09 PM

Some potential issues:

  1. These defaults are very Wikimedia-production-specific, whereas many other wikis likely use a manually-donwloaded, local SFS file. Though I don't know this for sure, I'm just assuming based upon how the extension historically managed the SFS files. 76 or so wikis use the extension according to WikiApiary.
  2. Maybe it's not great to have defaults that imply the immediate download of an external resource by an extension?
  3. Currently blowing up the tests as it looks like setMwGlobals() isn't overriding these updated values.

Change 656224 merged by jenkins-bot:
[mediawiki/extensions/StopForumSpam@master] Update wgSFSIPListLocation and wgSFSIPListLocationMD5 defaults

https://gerrit.wikimedia.org/r/656224

sbassett moved this task from In Progress to Done on the MediaWiki-extensions-StopForumSpam board.
sbassett added a subscriber: Reedy.

Resolving for now. The current fix (tx @Reedy) will likely need some adjustment if/when this repo migrates to Gitlab.