Maniphest T272089

Safari sets ominous margin on search (icon/button) even though user agent styles don't
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Volker_E
	Jan 14 2021, 9:00 PM

Description

No JS

Production

QA Results - Prod

AC	Status	Details
1	✅	T272089#6773326
2	✅	T272089#6773326

Details

	Subject	Repo	Branch	Lines +/-
	[styles] Ensuring correct rendering height of search button in Safari	mediawiki/skins/Vector	master	+2 -0

Customize query in gerrit

Related Objects

Mentioned In: T272139: Normalize button margin across browsers in MW

Event Timeline

Volker_E created this task.Jan 14 2021, 9:00 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 14 2021, 9:00 PM

Change 656258 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/Vector@master] [styles] Ensuring correct rendering height of search button in Safari

https://gerrit.wikimedia.org/r/656258

gerritbot added a project: Patch-For-Review.Jan 14 2021, 9:33 PM

Should this be in normalize in core?

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jan 14 2021, 10:00 PM

Change 656258 merged by jenkins-bot:
[mediawiki/skins/Vector@master] [styles] Ensuring correct rendering height of search button in Safari

https://gerrit.wikimedia.org/r/656258

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.27; 2021-01-19).Jan 14 2021, 11:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 14 2021, 11:10 PM

Jdlrobson moved this task from Upcoming to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jan 15 2021, 12:08 AM

@Jdlrobson It truly should, but we would have to take care about breakages across the board (probably limited as every feature team wrote their own normalization here.

Volker_E mentioned this in T272139: Normalize button margin across browsers in MW.Jan 15 2021, 11:29 AM

Jdlrobson moved this task from Needs More Work to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jan 15 2021, 9:38 PM

ovasileva moved this task from Ready for Signoff to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jan 18 2021, 4:43 PM

ovasileva triaged this task as Medium priority.Jan 18 2021, 6:10 PM

@Edtadros: This can be tested on any of the group0 wikis (e.g. testwiki) tomorrow (2021-01-19).

ovasileva assigned this task to Edtadros.Jan 20 2021, 6:06 PM

Test Result - Prod

Status: ✅ PASS
Environment: testwiki/enwiki
OS: macOS Big Sur
Browser: Safari/Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: No ominous margin with JS disabled

✅ AC2: No ominous margin with JS enabled

Edtadros updated the task description. (Show Details)Jan 25 2021, 1:58 PM

ovasileva closed this task as Resolved.Jan 25 2021, 4:23 PM

	F34022303: Screen Shot 2021-01-25 at 5.52.50 AM.png
	Jan 25 2021, 1:57 PM

	F34022305: Screen Shot 2021-01-25 at 5.53.56 AM.png
	Jan 25 2021, 1:57 PM

Safari sets ominous margin on search (icon/button) even though user agent styles don'tClosed, ResolvedPublicActions