Maniphest T272090

"Uncaught TypeError: Cannot read property 'split' of null" when trying to reply to some comments wrapped in <span style="font-size: smaller;"> tags
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Jan 14 2021, 9:07 PM

Description

"Uncaught TypeError: Cannot read property 'split' of null" when trying to reply to some comments wrapped in <span style="font-size: smaller;"> tags.

Reported here: https://www.mediawiki.org/wiki/Topic:W1gtzhlippvg6izz

Uncaught TypeError: Cannot read property 'split' of null
    at Object.isRenderingTransparentNode (...)
    at Object.addListItem (...)
    at CommentController.js.CommentController.setup (...)
    at CommentController.js.CommentController.onReplyLinkClick (...)
    at HTMLAnchorElement.dispatch (...)
    at HTMLAnchorElement.elemData.handle (...)

Test page: https://cs.wikipedia.org/wiki/Diskuse_s_wikipedistou:Patriccck/Test

Details

	Subject	Repo	Branch	Lines +/-
	Fix exception when trying to use non-existent 'typeof' attribute	mediawiki/extensions/DiscussionTools	master	+2 -2

Customize query in gerrit

Event Timeline

matmarex created this task.Jan 14 2021, 9:07 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 14 2021, 9:07 PM

Change 656257 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Fix exception when trying to use non-existent 'typeof' attribute

https://gerrit.wikimedia.org/r/656257

gerritbot added a project: Patch-For-Review.Jan 14 2021, 9:11 PM

matmarex claimed this task.Jan 14 2021, 9:11 PM

matmarex added a project: Editing-team (Kanban Board).

matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.

matmarex renamed this task from "Uncaught TypeError: Cannot read property 'split' of null" when trying to reply to some comments wrapped in <small> tags to "Uncaught TypeError: Cannot read property 'split' of null" when trying to reply to some comments wrapped in <span style="font-size: smaller;"> tags.Jan 15 2021, 1:15 PM

matmarex updated the task description. (Show Details)

Change 656257 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Fix exception when trying to use non-existent 'typeof' attribute

https://gerrit.wikimedia.org/r/656257

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.27; 2021-01-19).Jan 18 2021, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 18 2021, 7:10 PM

matmarex added a project: Editing QA.Jan 18 2021, 7:19 PM

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.

matmarex updated the task description. (Show Details)Jan 18 2021, 7:41 PM

Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Jan 22 2021, 3:01 AM

Ryasmeen edited projects, added Verified; removed Editing QA.

• ppelberg closed this task as Resolved.Jan 23 2021, 2:44 AM