Wikisource Extension: Some sidebar link text incorrectly encoded
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Jan 15 2021, 2:00 PM

Description

What is the problem?

When translations for the sidebar link text include ' it gets shown as '. See screenshot.

Examples:

In Turkish: PDF'yi indir
In Italian: tooltip: Scarica una versione ePub di quest'opera

Steps to reproduce problem

While logged out, go to https://tr.wikisource.org/wiki/Yeni_Ahit/Resullerin_%C4%B0%C5%9Fleri
Go to a book and look at the sidebar links

Expected behavior: Link text is PDF'yi indir
Observed behavior: Link text is PDF'yi indir

Environment

Wiki(s): Wikisource – (0c0e97a) 07:36, 11 January 2021.

Screenshots (if applicable):

Details

	Subject	Repo	Branch	Lines +/-
	Unescape tooltip text	mediawiki/extensions/Wikisource	master	+4 -4
	Use shorter list item parameter for sidebar links	mediawiki/extensions/Wikisource	master	+4 -4

Customize query in gerrit

Related Objects

Mentioned In: T256392: Wikisource Export: Migrate WSExport Gadget to Wikisource Extension
Mentioned Here: rEWSO5c2b92bb6309: Localisation updates from https://translatewiki.net.
rEWSO0c0e97a44123: Localisation updates from https://translatewiki.net.

Event Timeline

dom_walden created this task.Jan 15 2021, 2:00 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 15 2021, 2:00 PM

dom_walden mentioned this in T256392: Wikisource Export: Migrate WSExport Gadget to Wikisource Extension.Jan 15 2021, 4:09 PM

ifried moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.Jan 15 2021, 9:40 PM

Change 656653 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/extensions/Wikisource@master] Use shorter list item parameter for sidebar links

https://gerrit.wikimedia.org/r/656653

gerritbot added a project: Patch-For-Review.Jan 18 2021, 7:02 AM

Samwilson claimed this task.Jan 18 2021, 7:02 AM

Samwilson edited projects, added Community-Tech (Kanban-2020-21-Q3); removed Community-Tech.

Samwilson set the point value for this task to 1.

Samwilson moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (Kanban-2020-21-Q3) board.

Change 656653 merged by jenkins-bot:
[mediawiki/extensions/Wikisource@master] Use shorter list item parameter for sidebar links

https://gerrit.wikimedia.org/r/656653

Samwilson moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (Kanban-2020-21-Q3) board.Jan 18 2021, 7:45 AM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.27; 2021-01-19).Jan 18 2021, 8:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jan 18 2021, 8:10 AM

@Samwilson Should the same change be made for title as well? This bug also affects tooltips. Sorry I didn't make that very clear in the bug description.

Change 656984 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/extensions/Wikisource@master] Unescape tooltip text

https://gerrit.wikimedia.org/r/656984

gerritbot added a project: Patch-For-Review.Jan 19 2021, 1:07 AM

Oops, I totally should've checked that. Sorry. Done now; patch ready for review.

Change 656984 merged by jenkins-bot:
[mediawiki/extensions/Wikisource@master] Unescape tooltip text

https://gerrit.wikimedia.org/r/656984

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.28; 2021-01-26); removed MW-1.36-notes (1.36.0-wmf.27; 2021-01-19).Jan 19 2021, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 19 2021, 5:10 PM

HMonroy moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (Kanban-2020-21-Q3) board.Jan 19 2021, 5:19 PM

' now gets displayed correctly.

For example:

Test Environment: https://en.wikisource.beta.wmflabs.org Wikisource – (5c2b92b) 07:31, 22 January 2021.

This is now working as expected on production., I tested the tooltip for the EPUB sidebar link on https://it.wikisource.org/wiki/La_scienza_nuova_-_Volume_I/Occasione_di_meditarsi and I was seeing the ' as expected. For this reason, I'm marking this as Done.

	F34006530: it_tooltip.png
	Jan 18 2021, 12:48 PM

Wikisource Extension: Some sidebar link text incorrectly encodedClosed, ResolvedPublic1 Estimated Story PointsBUG REPORTActions