Page MenuHomePhabricator
Create Task
Maniphest T272186

Update extensions to handle the new media structure
Closed, ResolvedPublic
Actions

Description

  • Extension:TimedMediaHandler sets widths to 100%
  • Extension:TimedMediaHandler css reflow for videos
  • Extension:ImageMap appears to do regexp post-processing of image media HTML, probably needs an update
  • Gallery extension JS needs updating for the new structure (in resources/src/mediawiki.page.gallery.js, also look at less)

Should be gated on the flag from T266148

Details

SubjectRepoBranchLines +/-
Call linkWrap from MP3OutputRenderer::toHtmlmediawiki/extensions/MP3MediaHandlermaster+2 -2
Call linkWrap from TimedMediaTransformOutput::toHtmlmediawiki/extensions/TimedMediaHandlermaster+13 -5
Bump parsoid to 0.14.0-a16mediawiki/vendormaster+9 K -8 K
Update ImageMap for new media structuremediawiki/extensions/ImageMapmaster+127 -21
Add noresize class on imagemapsmediawiki/services/parsoidmaster+7 -4
Don't select on a.imagemediawiki/coremaster+1 -1
Revert most of the changes from 16b76a4mediawiki/coremaster+41 -13
Customize query in gerrit

Related Objects
Search...

Event Timeline

Arlolra created this task.Jan 15 2021, 10:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 15 2021, 10:33 PM
Arlolra triaged this task as Medium priority.Jan 15 2021, 10:34 PM
Arlolra moved this task from Needs Triage to Media Structure on the Parsoid board.
Arlolra mentioned this in T266149: Run another round of visual diff testing after tweaking core patches that change media output to <figure>, etc..
gerritbot added a comment.Jan 21 2021, 11:36 PM

Change 657703 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/core@master] Revert most of the changes from 16b76a4

https://gerrit.wikimedia.org/r/657703

gerritbot added a project: Patch-For-Review.Jan 21 2021, 11:36 PM
gerritbot added a comment.Jan 22 2021, 8:08 PM

Change 657703 merged by jenkins-bot:
[mediawiki/core@master] Revert most of the changes from 16b76a4

https://gerrit.wikimedia.org/r/657703

Maintenance_bot removed a project: Patch-For-Review.Jan 22 2021, 8:10 PM
Arlolra updated the task description. (Show Details)Jan 28 2021, 5:13 PM
Arlolra updated the task description. (Show Details)
gerritbot added a comment.Feb 2 2021, 6:39 PM

Change 661169 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/core@master] Don't select on a.image

https://gerrit.wikimedia.org/r/661169

gerritbot added a project: Patch-For-Review.Feb 2 2021, 6:39 PM
gerritbot added a comment.Feb 2 2021, 10:01 PM

Change 661169 merged by jenkins-bot:
[mediawiki/core@master] Don't select on a.image

https://gerrit.wikimedia.org/r/661169

Maintenance_bot removed a project: Patch-For-Review.Feb 2 2021, 10:10 PM
Arlolra added a comment.Feb 3 2021, 3:03 PM

Another one for ImageMap, https://mw-expt-tests.wmflabs.org/diff/hewiki/%D7%9E%D7%A1%D7%99%D7%9C%D7%AA_%D7%A2%D7%99%D7%A8%D7%95%D7%9F

It inserts a noresize div,

<span typeof="mw:Image"><div class="noresize"><a href="/wiki/%D7%95%D7%99%D7%A7%D7%99%D7%A4%D7%93%D7%99%D7%94:%D7%A4%D7%95%D7%A8%D7%98%D7%9C" title="&#x5d5;&#x5d9;&#x5e7;&#x5d9;&#x5e4;&#x5d3;&#x5d9;&#x5d4;:&#x5e4;&#x5d5;&#x5e8;&#x5d8;&#x5dc;"><img alt="&#x5e4;&#x5d5;&#x5e8;&#x5d8;&#x5dc;" src="https://upload.wikimedia.org/wikipedia/commons/thumb/d/d6/P_Rakevet.png/50px-P_Rakevet.png" decoding="async" width="50" height="46" srcset="https://upload.wikimedia.org/wikipedia/commons/thumb/d/d6/P_Rakevet.png/75px-P_Rakevet.png 1.5x, https://upload.wikimedia.org/wikipedia/commons/thumb/d/d6/P_Rakevet.png/100px-P_Rakevet.png 2x" /></a></div></span>
Arlolra added a comment.Feb 3 2021, 7:01 PM

https://mw-expt-tests.wmflabs.org/diff/dewiki/Gr%C3%B6nland has an ImageMap causing a diff

Arlolra added a comment.Feb 3 2021, 8:25 PM

TimedMediaTransformOutput doesn't call linkWrap in toHtml, so the wrapping span isn't present

Arlolra added a comment.Feb 3 2021, 8:38 PM
This comment was removed by Arlolra.
Arlolra edited projects, added Parsoid-Media-Structure; removed Parsoid.Jul 13 2021, 5:14 PM
gerritbot added a comment.Jul 15 2021, 11:36 PM

Change 704878 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/ImageMap@master] [WIP] Update ImageMap for new media structure

https://gerrit.wikimedia.org/r/704878

gerritbot added a project: Patch-For-Review.Jul 15 2021, 11:36 PM
Arlolra added a subscriber: TheDJ.Aug 3 2021, 3:19 PM
In T51097#7255628, @TheDJ wrote:

And I see a CSS reflow for videos on test.wikipedia.org. This is specifically with the videojs player, which is active on test.wp.org, not sure about the old Kaltura player.
https://test.wikipedia.org/wiki/User:TheDJ/sandbox

Arlolra updated the task description. (Show Details)Aug 3 2021, 3:19 PM
Arlolra mentioned this in T268947: Gallery rendering difference on eswiki.Aug 11 2021, 7:15 PM
gerritbot added a comment.Aug 12 2021, 9:35 PM

Change 712627 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Add noresize class on imagemaps

https://gerrit.wikimedia.org/r/712627

gerritbot added a comment.Aug 12 2021, 10:04 PM

Change 712627 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Add noresize class on imagemaps

https://gerrit.wikimedia.org/r/712627

gerritbot added a comment.Aug 20 2021, 7:54 PM

Change 704878 merged by jenkins-bot:

[mediawiki/extensions/ImageMap@master] Update ImageMap for new media structure

https://gerrit.wikimedia.org/r/704878

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.20; 2021-08-23).Aug 20 2021, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 20 2021, 8:11 PM
gerritbot added a comment.Aug 23 2021, 9:55 PM

Change 714425 had a related patch set uploaded (by Sbailey; author: Sbailey):

[mediawiki/vendor@master] Bump parsoid to 0.14.0-a16

https://gerrit.wikimedia.org/r/714425

gerritbot added a project: Patch-For-Review.Aug 23 2021, 9:55 PM
gerritbot added a comment.Aug 23 2021, 11:00 PM

Change 714425 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.14.0-a16

https://gerrit.wikimedia.org/r/714425

Maintenance_bot removed a project: Patch-For-Review.Aug 23 2021, 11:11 PM
Arlolra added a comment.Sep 3 2021, 7:12 PM

Gallery extension JS needs updating for the new structure (in resources/src/mediawiki.page.gallery.js, also look at less)

This is more likely because of the hook, mw.hook( 'wikipage.content' ), not being called when doing the visual diff,
https://github.com/wikimedia/mediawiki/blob/master/resources/src/mediawiki.page.gallery.js#L259

And probably got fixed with https://github.com/wikimedia/integration-visualdiff/commit/d341430bc42fa6f021f63b851274c93a245ad454

Arlolra mentioned this in T288588: Gallery output dimension diffs between Parsoid & core gallery output.Sep 3 2021, 7:14 PM
MBinder_WMF added a project: Parsoid-Read-Views-Deprecated-Project (Phase 0 - Parsoid-Media-Structure).Sep 3 2021, 9:30 PM
MBinder_WMF edited projects, added Parsoid; removed Parsoid-Read-Views-Deprecated-Project (Phase 0 - Parsoid-Media-Structure).Sep 3 2021, 9:37 PM
MBinder_WMF added a project: Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure).Sep 3 2021, 9:58 PM
gerritbot added a comment.Sep 3 2021, 9:59 PM

Change 717646 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/TimedMediaHandler@master] Call linkWrap from TimedMediaTransformOutput::toHtml

https://gerrit.wikimedia.org/r/717646

gerritbot added a project: Patch-For-Review.Sep 3 2021, 10:00 PM
Arlolra updated the task description. (Show Details)Sep 3 2021, 10:00 PM
gerritbot added a comment.Sep 3 2021, 10:42 PM

Change 717646 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Call linkWrap from TimedMediaTransformOutput::toHtml

https://gerrit.wikimedia.org/r/717646

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.23; 2021-09-13); removed MW-1.37-notes (1.37.0-wmf.20; 2021-08-23).Sep 3 2021, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 3 2021, 11:10 PM
Arlolra closed this task as Resolved.Sep 9 2021, 12:52 AM
Arlolra claimed this task.
Arlolra updated the task description. (Show Details)
Arlolra mentioned this in T294467: Error: Call to a member function insertBefore() on null in ImageMap class.Nov 22 2021, 8:18 PM
Arlolra moved this task from Backlog to To Verify on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.Jun 15 2022, 3:32 PM
Arlolra mentioned this in T271114: Update site specific js/css for new media structure.Sep 20 2022, 2:01 AM
Arlolra mentioned this in T318433: Templates (and extensions) that mimic parser media output need migration to new structure.Sep 23 2022, 5:17 PM
gerritbot added a comment.Apr 13 2023, 5:31 PM

Change 908603 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/MP3MediaHandler@master] Call linkWrap from MP3OutputRenderer::toHtml

https://gerrit.wikimedia.org/r/908603

gerritbot added a project: Patch-For-Review.Apr 13 2023, 5:31 PM
gerritbot added a comment.Apr 13 2023, 6:38 PM

Change 908603 merged by jenkins-bot:

[mediawiki/extensions/MP3MediaHandler@master] Call linkWrap from MP3OutputRenderer::toHtml

https://gerrit.wikimedia.org/r/908603

Maintenance_bot removed a project: Patch-For-Review.Apr 13 2023, 7:10 PM
Arlolra mentioned this in rEMMHf1bcfbd193c6: Call linkWrap from MP3OutputRenderer::toHtml.Apr 13 2023, 7:48 PM
Lucas_Werkmeister_WMDE added a subtask: T354750: Update Wikidata Bridge for new media DOM structure.Jan 10 2024, 12:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits