Page MenuHomePhabricator

Update extensions to handle the new media structure
Open, MediumPublic

Description

  • Extension:TimedMediaHandler sets widths to 100%
  • Extension:ImageMap appears to do regexp post-processing of image media HTML, probably needs an update
  • Gallery extension JS needs updating for the new structure (in resources/src/mediawiki.page.gallery.js, also look at less)

Should be gated on the flag from T266148

Event Timeline

Change 657703 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/core@master] Revert most of the changes from 16b76a4

https://gerrit.wikimedia.org/r/657703

Change 657703 merged by jenkins-bot:
[mediawiki/core@master] Revert most of the changes from 16b76a4

https://gerrit.wikimedia.org/r/657703

Arlolra updated the task description. (Show Details)

Change 661169 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/core@master] Don't select on a.image

https://gerrit.wikimedia.org/r/661169

Change 661169 merged by jenkins-bot:
[mediawiki/core@master] Don't select on a.image

https://gerrit.wikimedia.org/r/661169

Another one for ImageMap, https://mw-expt-tests.wmflabs.org/diff/hewiki/%D7%9E%D7%A1%D7%99%D7%9C%D7%AA_%D7%A2%D7%99%D7%A8%D7%95%D7%9F

It inserts a noresize div,

<span typeof="mw:Image"><div class="noresize"><a href="/wiki/%D7%95%D7%99%D7%A7%D7%99%D7%A4%D7%93%D7%99%D7%94:%D7%A4%D7%95%D7%A8%D7%98%D7%9C" title="&#x5d5;&#x5d9;&#x5e7;&#x5d9;&#x5e4;&#x5d3;&#x5d9;&#x5d4;:&#x5e4;&#x5d5;&#x5e8;&#x5d8;&#x5dc;"><img alt="&#x5e4;&#x5d5;&#x5e8;&#x5d8;&#x5dc;" src="https://upload.wikimedia.org/wikipedia/commons/thumb/d/d6/P_Rakevet.png/50px-P_Rakevet.png" decoding="async" width="50" height="46" srcset="https://upload.wikimedia.org/wikipedia/commons/thumb/d/d6/P_Rakevet.png/75px-P_Rakevet.png 1.5x, https://upload.wikimedia.org/wikipedia/commons/thumb/d/d6/P_Rakevet.png/100px-P_Rakevet.png 2x" /></a></div></span>

TimedMediaTransformOutput doesn't call linkWrap in toHtml, so the wrapping span isn't present

This comment was removed by Arlolra.