Page MenuHomePhabricator

Proofreaf page 'visual mode' does not update if "Number" option used for setting page number.
Closed, ResolvedPublic

Description

Steps to reproduce:

https://en.wikisource.org/w/index.php?title=Index:International_Library_of_Technology_-_Volume_1B.djvu&action=edit

Enable "experimental" visual mode

Select scan 19 (indicated as 13 currently)

Select "Page Number Type:" Number
Select "Page numbering starts from:" 1

Click "Update pagelist" and then "Insert Changes"

Expected result :
Insertion of 19="1"' into <pages> tag, at the appropriate location.

Actual result:
No change to pagelist or <pages> tag

(Aside: It would be nice if the visual mode when inserting changes 'sorted' the entries in the pages tag so that they run in consecutive ascending order.)

Event Timeline

Change 656947 had a related patch set uploaded (by Sohom Datta; owner: Sohom Datta):
[mediawiki/extensions/ProofreadPage@master] Corrected check for builtin ranges in PagelistWidget

https://gerrit.wikimedia.org/r/656947

Made the changes, the bug appears to have been caused by some corner-cases that I failed to check in fc745f5dfb483766e12cf4123ef08cc1427d37a4.

Change 656947 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Corrected check for builtin ranges in PagelistWidget

https://gerrit.wikimedia.org/r/656947

Confirming solved as of 2021-01-21 . Bug can be closed if this checks out.

Yup, it does work now on all Wikisources :)