Right now, Mirage bundles and includes wikimedia-ui-base.less in both the variables less file and the mediawiki.skin.variables.less import. This unnecessarily duplicates the file that is provided by MediaWiki itself and runs the risk of getting out of date, as well as the issue with accidental import overwrites that was fixed with rSMIR7b097efd190837e1e31d47c8478b71048efbd306, but shouldn't have happened to begin with.
Description
Description
Details
Details
- Other Assignee
- Volker_E
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Use Codex design tokens instead of bundling 'wikimedia-ui-base.less' | mediawiki/skins/Mirage | master | +231 -503 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Mainframe98 | T272217 Stop bundling wikimedia-ui-base.less | |||
| Resolved | Catrope | T325237 Enable and document use of Codex design tokens within MediaWiki | |||
| Resolved | Volker_E | T326591 Temporarily change or remove two tokens that can't be parsed by MediaWiki Less compiler | |||
| Resolved | Catrope | T330694 tokens: Split out deprecated tokens into separate file |
Event Timeline
Comment Actions
Until this is realized, wikimedia-ui-base.less should be managed as a foreign resource through https://gerrit.wikimedia.org/r/c/mediawiki/core/+/756631. I'm extending this task to include doing that too.
Nevermind, patch was abandoned.
Comment Actions
See T330427 and associated tasks. Re-extending the scope of this task to add this dependency.
Comment Actions
@Mainframe98 With T325237: Enable and document use of Codex design tokens within MediaWiki accomplished, it's now recommended to rely on MediaWiki skin variables via @import 'mediawiki.skin.variables.less';. For Vector and MinervaNeue Codex “WikimediaUI theme” design tokens are imported by default.
I'd suggest to copy one of the other skin's variables file and amend the values to Mirage's needs.
Comment Actions
Change 909743 had a related patch set uploaded (by Mainframe98; author: Mainframe98):
[mediawiki/skins/Mirage@master] Use codex tokes instead of bundling wikimedia-ui-base.less
Comment Actions
In case you don't get Gerrit pings, I'd like to repeat here that I've updated your patch to make it valid. There's just a minuscule question left in my opinion. Would be great to resolve this in order to sunset WikimediaUI Base for Codex.
Comment Actions
Change 909743 merged by jenkins-bot:
[mediawiki/skins/Mirage@master] Use Codex design tokens instead of bundling 'wikimedia-ui-base.less'