Right now, Mirage bundles and includes wikimedia-ui-base.less in both the variables less file and the mediawiki.skin.variables.less import. This unnecessarily duplicates the file that is provided by MediaWiki itself and runs the risk of getting out of date, as well as the issue with accidental import overwrites that was fixed with rSMIR7b097efd190837e1e31d47c8478b71048efbd306, but shouldn't have happened to begin with.
- Other Assignee
|Use Codex design tokens instead of bundling 'wikimedia-ui-base.less'||mediawiki/skins/Mirage||master||+231 -503|
|Resolved||Mainframe98||T272217 Stop bundling wikimedia-ui-base.less|
|Resolved||Catrope||T325237 Enable and document use of Codex design tokens within MediaWiki|
|Resolved||Volker_E||T326591 Temporarily change or remove two tokens that can't be parsed by MediaWiki Less compiler|
|Resolved||Catrope||T330694 tokens: Split out deprecated tokens into separate file|
- Mentioned In
- T334934: [EPIC] Replace WikimediaUI Base variables with Codex design tokens (mediawiki.skin.variables)
- Mentioned Here
- T325237: Enable and document use of Codex design tokens within MediaWiki
T330427: Add a way for skins and extensions to feed into "Installed client-side libraries" on Special:Version
rSMIR7b097efd1908: Fix broken variable importing
Until this is realized, wikimedia-ui-base.less should be managed as a foreign resource through https://gerrit.wikimedia.org/r/c/mediawiki/core/+/756631. I'm extending this task to include doing that too.
Nevermind, patch was abandoned.
@Mainframe98 With T325237: Enable and document use of Codex design tokens within MediaWiki accomplished, it's now recommended to rely on MediaWiki skin variables via @import 'mediawiki.skin.variables.less';. For Vector and MinervaNeue Codex “WikimediaUI theme” design tokens are imported by default.
I'd suggest to copy one of the other skin's variables file and amend the values to Mirage's needs.
In case you don't get Gerrit pings, I'd like to repeat here that I've updated your patch to make it valid. There's just a minuscule question left in my opinion. Would be great to resolve this in order to sunset WikimediaUI Base for Codex.