Page MenuHomePhabricator
Create Task
Maniphest T272237

input_list_choice fails with ValueError if choice is given as list entry instead of sequence index
Closed, ResolvedPublic
Actions

Description

input_list_choice choice may be given either as sequence index or as the entry itself. When giving a wrong choice an "Error: Invalid Response" is printed. But in case of giving a wrong entry this fails and a ValueError is raised instead. The reason is a wrong fetched exception. Sequence.index does not raise an IndexError but a ValueError

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
[bugfix] Improvements for input_list_choice()Xqtpywikibot/coremaster+39 -28
Customize query in gerrit

Related Objects

Event Timeline

Xqt created this task.Jan 17 2021, 10:25 AM
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptJan 17 2021, 10:25 AM
Xqt triaged this task as Medium priority.Jan 17 2021, 10:25 AM
gerritbot added a comment.Jan 17 2021, 12:11 PM

Change 656608 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] Improvements for input_list_choice()

https://gerrit.wikimedia.org/r/656608

gerritbot added a project: Patch-For-Review.Jan 17 2021, 12:11 PM
gerritbot added a comment.Jan 18 2021, 7:36 AM

Change 656608 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] Improvements for input_list_choice()

https://gerrit.wikimedia.org/r/656608

JJMC89 closed this task as Resolved.Jan 18 2021, 7:43 AM
JJMC89 removed a project: Patch-For-Review.
Xqt mentioned this in rPWBCf4f52ab762d1: [bugfix] Improvements for input_list_choice().Jan 18 2021, 7:50 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits