Page MenuHomePhabricator

AbuseFilter-triggered API errors on Beta Commons: FilterRunner::checkFilter() must be an instance of ExistingFilter, instance of Filter given
Closed, ResolvedPublic

Description

Trying to create User:Lucas Werkmeister/sandbox yields the following error:

[YAS7hawQBHcAAGsf4QYAAAAN] /w/index.php?title=User:Lucas_Werkmeister/sandbox&action=submit TypeError: Argument 1 passed to MediaWiki\Extension\AbuseFilter\FilterRunner::checkFilter() must be an instance of MediaWiki\Extension\AbuseFilter\Filter\ExistingFilter, instance of MediaWiki\Extension\AbuseFilter\Filter\Filter given, called in /srv/mediawiki/php-master/extensions/AbuseFilter/includes/FilterRunner.php on line 436

Backtrace:

from /srv/mediawiki/php-master/extensions/AbuseFilter/includes/FilterRunner.php(454)
#0 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/FilterRunner.php(436): MediaWiki\Extension\AbuseFilter\FilterRunner->checkFilter(MediaWiki\Extension\AbuseFilter\Filter\Filter, boolean)
#1 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/FilterRunner.php(249): MediaWiki\Extension\AbuseFilter\FilterRunner->checkAllFilters(boolean)
#2 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/AbuseFilterHooks.php(232): MediaWiki\Extension\AbuseFilter\FilterRunner->run()
#3 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/AbuseFilterHooks.php(176): MediaWiki\Extension\AbuseFilter\AbuseFilterHooks::filterEdit(DerivativeContext, User, WikitextContent, string, string)
#4 /srv/mediawiki/php-master/includes/HookContainer/HookContainer.php(333): MediaWiki\Extension\AbuseFilter\AbuseFilterHooks::onEditFilterMergedContent(DerivativeContext, WikitextContent, Status, string, User, boolean)
#5 /srv/mediawiki/php-master/includes/HookContainer/HookContainer.php(140): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#6 /srv/mediawiki/php-master/includes/HookContainer/HookRunner.php(1552): MediaWiki\HookContainer\HookContainer->run(string, array)
#7 /srv/mediawiki/php-master/includes/editpage/Constraint/EditFilterMergedContentHookConstraint.php(90): MediaWiki\HookContainer\HookRunner->onEditFilterMergedContent(DerivativeContext, WikitextContent, Status, string, User, boolean)
#8 /srv/mediawiki/php-master/includes/editpage/Constraint/EditConstraintRunner.php(88): MediaWiki\EditPage\Constraint\EditFilterMergedContentHookConstraint->checkConstraint()
#9 /srv/mediawiki/php-master/includes/EditPage.php(2084): MediaWiki\EditPage\Constraint\EditConstraintRunner->checkConstraints()
#10 /srv/mediawiki/php-master/includes/EditPage.php(1687): EditPage->internalAttemptSave(NULL, boolean)
#11 /srv/mediawiki/php-master/includes/EditPage.php(662): EditPage->attemptSave(NULL)
#12 /srv/mediawiki/php-master/includes/actions/EditAction.php(71): EditPage->edit()
#13 /srv/mediawiki/php-master/includes/actions/SubmitAction.php(38): EditAction->show()
#14 /srv/mediawiki/php-master/includes/MediaWiki.php(532): SubmitAction->show()
#15 /srv/mediawiki/php-master/includes/MediaWiki.php(316): MediaWiki->performAction(Article, Title)
#16 /srv/mediawiki/php-master/includes/MediaWiki.php(944): MediaWiki->performRequest()
#17 /srv/mediawiki/php-master/includes/MediaWiki.php(548): MediaWiki->main()
#18 /srv/mediawiki/php-master/index.php(53): MediaWiki->run()
#19 /srv/mediawiki/php-master/index.php(46): wfIndexMain()
#20 /srv/mediawiki/w/index.php(3): require(string)
#21 {main}

API requests to edit structured data likewise fail. They still worked yesterday (more specifically on this test run).

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 17 2021, 10:37 PM
Daimona claimed this task.Jan 17 2021, 10:53 PM
Daimona triaged this task as Unbreak Now! priority.

Definitely a blocker, fix coming now.

Change 656642 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Bump cache key version of FilterLookup::getAllActiveFiltersInGroup

https://gerrit.wikimedia.org/r/656642

Change 656642 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Bump cache key version of FilterLookup::getAllActiveFiltersInGroup

https://gerrit.wikimedia.org/r/656642

Daimona closed this task as Resolved.Jan 17 2021, 11:58 PM
Daimona removed a project: Patch-For-Review.

Resolved. Updating cache versions is so easy to forget :-/

Yup, AC/DC CI is also back up. Thanks @Daimona!