Page MenuHomePhabricator
Create Task
Maniphest T272250

CookieTest::testValidateCookieDomain fails on PHP 8.0
Closed, ResolvedPublic
Actions

Description

00:03:03.731 1) CookieTest::testValidateCookieDomain with data set #5 (false, '.co.uk')
00:03:03.731 .co.uk
00:03:03.731 Failed asserting that true matches expected false.
00:03:03.731 
00:03:03.731 /workspace/src/tests/phpunit/unit/includes/libs/CookieTest.php:20

Details

SubjectRepoBranchLines +/-
Don't rely on implicit string->int cast in comparisonmediawiki/coreREL1_35+1 -1
Don't rely on implicit string->int cast in comparisonmediawiki/coremaster+1 -1
Customize query in gerrit

Event Timeline

Jdforrester-WMF created this task.Jan 18 2021, 12:18 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 18 2021, 12:18 AM
Jdforrester-WMF moved this task from Backlog to MediaWiki core on the PHP 8.0 support board.Jan 18 2021, 12:18 AM
gerritbot added a comment.Jan 18 2021, 7:10 AM

Change 656654 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Don't rely on implicit string->int cast in comparison

https://gerrit.wikimedia.org/r/656654

gerritbot added a project: Patch-For-Review.Jan 18 2021, 7:10 AM
gerritbot added a comment.Jan 18 2021, 9:57 AM

Change 656654 merged by jenkins-bot:
[mediawiki/core@master] Don't rely on implicit string->int cast in comparison

https://gerrit.wikimedia.org/r/656654

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.27; 2021-01-19).Jan 18 2021, 10:00 AM
Ammarpad closed this task as Resolved.Jan 18 2021, 10:07 AM
Ammarpad claimed this task.
Maintenance_bot removed a project: Patch-For-Review.Jan 18 2021, 10:10 AM
gerritbot added a comment.Jan 18 2021, 11:44 PM

Change 656914 had a related patch set uploaded (by Jforrester; owner: Ammarpad):
[mediawiki/core@REL1_35] Don't rely on implicit string->int cast in comparison

https://gerrit.wikimedia.org/r/656914

gerritbot added a project: Patch-For-Review.Jan 18 2021, 11:44 PM
gerritbot added a comment.Jan 19 2021, 12:03 AM

Change 656914 merged by jenkins-bot:
[mediawiki/core@REL1_35] Don't rely on implicit string->int cast in comparison

https://gerrit.wikimedia.org/r/656914

ReleaseTaggerBot added a project: MW-1.35-notes.Jan 19 2021, 1:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL