Page MenuHomePhabricator
Create Task
Maniphest T272315

Sidebar items are shown in wrong order in visual diffs
Closed, ResolvedPublic
Actions

Assigned To
• ppelberg
Authored By
matmarex
Jan 18 2021, 5:58 PM
Tags
Referenced Files
F34055946: Screen Shot 2021-01-28 at 2.12.47 PM.png
Jan 28 2021, 10:16 PM
F34009742: en.wikipedia.org_w_index.php_title=Eight_Legged_Freaks&curid=956388&diff=1000619828&oldid=1000322446&diffmode=visual&debug=1.png
Jan 20 2021, 6:54 PM
F34007270: en.wikipedia.org_w_index.php_title=Eight_Legged_Freaks&curid=956388&diff=1000619828&oldid=1000322446&diffmode=visual.png
Jan 18 2021, 5:58 PM
Subscribers
Aklapper
matmarex
Ryasmeen

Description

Sidebar items are shown in wrong order in visual diffs.

https://en.wikipedia.org/w/index.php?title=Eight_Legged_Freaks&curid=956388&diff=1000619828&oldid=1000322446&diffmode=visual

en.wikipedia.org_w_index.php_title=Eight_Legged_Freaks&curid=956388&diff=1000619828&oldid=1000322446&diffmode=visual.png (3×2 px, 790 KB)

The first item shown in the sidebar is "Template parameters changed: accessdate unset …" about a reference template.

The third item, underneath, is "Template parameters changed: budget changed …" about the infobox. This item should appear next to the infobox, not all the way down here.

There are similar problems with several more of the items. Also, the localisation messages for ⧼visualeditor-diff-moved-down⧽ are missing.

(This diff also suffers from T272314.)

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (36e21385b)mediawiki/extensions/VisualEditormaster+1 -1
Create a separate descriptionItemsStack for each reflistVisualEditor/VisualEditormaster+13 -5
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Jan 18 2021, 5:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 18 2021, 5:58 PM
matmarex added a project: VisualEditor.Jan 18 2021, 5:59 PM
matmarex updated the task description. (Show Details)
matmarex mentioned this in T272314: "References" section always has a grey background for some reason in visual diffs.
matmarex mentioned this in T268950: Include section name in the revision history visual diff.
gerritbot added a comment.Jan 19 2021, 11:29 PM

Change 657212 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Create a separate descriptionItemsStack for each reflist

https://gerrit.wikimedia.org/r/657212

gerritbot added a project: Patch-For-Review.Jan 19 2021, 11:29 PM
Esanders moved this task from To Triage to Triaged on the VisualEditor board.Jan 20 2021, 1:07 PM
matmarex added a comment.Jan 20 2021, 6:43 PM

Also, the localisation messages for ⧼visualeditor-diff-moved-down⧽ are missing.

Fixed in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/657205

gerritbot added a comment.Jan 20 2021, 6:52 PM

Change 657212 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Create a separate descriptionItemsStack for each reflist

https://gerrit.wikimedia.org/r/657212

matmarex added a comment.Jan 20 2021, 6:54 PM

With the patch applied:

en.wikipedia.org_w_index.php_title=Eight_Legged_Freaks&curid=956388&diff=1000619828&oldid=1000322446&diffmode=visual&debug=1.png (3×2 px, 824 KB)

gerritbot added a comment.Jan 20 2021, 6:56 PM

Change 657393 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (36e21385b)

https://gerrit.wikimedia.org/r/657393

gerritbot added a comment.Jan 20 2021, 8:26 PM

Change 657393 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (36e21385b)

https://gerrit.wikimedia.org/r/657393

matmarex added a project: Editing-team (Kanban Board).Jan 20 2021, 8:32 PM
matmarex moved this task from Incoming to QA on the Editing-team (Kanban Board) board.
matmarex edited projects, added Editing QA; removed Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.28; 2021-01-26).Jan 20 2021, 9:00 PM
Ryasmeen removed a project: Editing QA.Jan 28 2021, 10:03 PM
Ryasmeen subscribed.Jan 28 2021, 10:16 PM
In T272315#6762999, @matmarex wrote:

With the patch applied:

en.wikipedia.org_w_index.php_title=Eight_Legged_Freaks&curid=956388&diff=1000619828&oldid=1000322446&diffmode=visual&debug=1.png (3×2 px, 824 KB)

@matmarex: I am seeing a slightly different behavior on production. For the first change on visual diff only <ref name="budget" /> is highlighted which seems different from your screenshot. Is this still correct?

Screen Shot 2021-01-28 at 2.12.47 PM.png (1×1 px, 851 KB)

Ryasmeen moved this task from QA to Blocked / Needs More Work on the Editing-team (Kanban Board) board.Jan 28 2021, 10:17 PM
matmarex added a comment.Jan 29 2021, 8:33 PM

Thanks for checking! Yes, it's correct, that's a result of the changes from T272603 (which were not made yet when I was working on this one).

matmarex moved this task from Blocked / Needs More Work to Ready for Sign Off on the Editing-team (Kanban Board) board.Jan 29 2021, 8:33 PM
Ryasmeen added a comment.Jan 29 2021, 9:10 PM
In T272315#6788132, @matmarex wrote:

Thanks for checking! Yes, it's correct, that's a result of the changes from T272603 (which were not made yet when I was working on this one).

Understood, thanks @matmarex .

Ryasmeen added a project: Verified.Jan 29 2021, 9:10 PM
• ppelberg closed this task as Resolved.Jan 30 2021, 3:02 AM
• ppelberg claimed this task.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJan 30 2021, 3:02 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL