Page MenuHomePhabricator

Sidebar items are shown in wrong order in visual diffs
Closed, ResolvedPublic

Description

Sidebar items are shown in wrong order in visual diffs.

https://en.wikipedia.org/w/index.php?title=Eight_Legged_Freaks&curid=956388&diff=1000619828&oldid=1000322446&diffmode=visual

The first item shown in the sidebar is "Template parameters changed: accessdate unset …" about a reference template.

The third item, underneath, is "Template parameters changed: budget changed …" about the infobox. This item should appear next to the infobox, not all the way down here.

There are similar problems with several more of the items. Also, the localisation messages for ⧼visualeditor-diff-moved-down⧽ are missing.

(This diff also suffers from T272314.)

Event Timeline

Change 657212 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Create a separate descriptionItemsStack for each reflist

https://gerrit.wikimedia.org/r/657212

Also, the localisation messages for ⧼visualeditor-diff-moved-down⧽ are missing.

Fixed in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/657205

Change 657212 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Create a separate descriptionItemsStack for each reflist

https://gerrit.wikimedia.org/r/657212

Change 657393 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (36e21385b)

https://gerrit.wikimedia.org/r/657393

Change 657393 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (36e21385b)

https://gerrit.wikimedia.org/r/657393

With the patch applied:

@matmarex: I am seeing a slightly different behavior on production. For the first change on visual diff only <ref name="budget" /> is highlighted which seems different from your screenshot. Is this still correct?

Thanks for checking! Yes, it's correct, that's a result of the changes from T272603 (which were not made yet when I was working on this one).

Thanks for checking! Yes, it's correct, that's a result of the changes from T272603 (which were not made yet when I was working on this one).

Understood, thanks @matmarex .

ppelberg claimed this task.