Page MenuHomePhabricator

EntitySchema tests are failing on master
Closed, ResolvedPublic

Description

EntitySchema tests are failing on master.

This patch should not be failing the tests: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/EntitySchema/+/644617

(Apparently the Shape Expressions project has an alias #entityschema, I hope that's the right project)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Ladsgroup added a subscriber: Ladsgroup.

Yes, it's correct. I'm incident manager for wikidata team this week. I see how this can be moved forward.

The tests for diff renderer is really fragile. it'll break with basically every change in diff renderer (it also breaks with change of wiki's language). It needs a rework...

I don't think that's needed right now, I would just update the tests if that's the only thing that's required to make them stop failing.

There are also some Selenium test failures which look more "interesting".

Change 657344 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/EntitySchema@master] Fix EntitySchemaSlotDiffRendererTest for diff marker change

https://gerrit.wikimedia.org/r/657344

Change 657344 merged by jenkins-bot:
[mediawiki/extensions/EntitySchema@master] Fix EntitySchemaSlotDiffRendererTest for diff marker change

https://gerrit.wikimedia.org/r/657344

Change 657352 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/EntitySchema@master] [DNM] Test jenkins on master

https://gerrit.wikimedia.org/r/657352

Change 657352 abandoned by Ladsgroup:
[mediawiki/extensions/EntitySchema@master] [DNM] Test jenkins on master

Reason:

https://gerrit.wikimedia.org/r/657352

The browser test is unrelated and it's caused by the patch itself. A noop change on master passes ^. I call this done.