SecurePoll: Custom column labels do not appear (or do not appear correctly) [8h]
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Jan 19 2021, 2:27 PM

Description

What is the problem?

When selecting "Use custom messages for column labels" for a question, the custom labels either do not appear or only some of them appear.

They only appear correctly after you have attempted to submit the form (and got a validation error).

Steps to reproduce problem

Go to Special:SecurePoll/create
Under "Poll type", choose Range voting (histogram range)
Scroll down to the first question, enter values for "Minimum", "Maximum" and "Default Score"
Click Use custom messages for column labels

Expected behavior: You see three inputs appear corresponding to the three columns from step 3
Observed behavior: Nothing appears (or less than 3 inputs appear)

Environment

Browser: Firefox 78 and Chromium 83
Wiki(s): local vagrant 1.36.0-alpha (36e9014), SecurePoll 2.0.0 (d9d75af).

Screenshots (if applicable):

Before submit:

After submit:

Details

	Subject	Repo	Branch	Lines +/-
	Fix change handlers for custom columns in range voting	mediawiki/extensions/SecurePoll	master	+15 -9

Customize query in gerrit

Related Objects

Mentioned In: T272433: Fix issue with Support label being arbitrarily removed in SecurePoll poll creation page [8h]
T273043: Update custom column label inputs to use OOUI widgets
T271149: Convert SecurePoll CreatePage to use OOUI
Mentioned Here: rESPO353434732cfa: Localisation updates from https://translatewiki.net.
T273043: Update custom column label inputs to use OOUI widgets
T272433: Fix issue with Support label being arbitrarily removed in SecurePoll poll creation page [8h]
rESPOd9d75afe1f23: Merge "GpgCrypt: Handle deleting directories within the home directory"
rMW36e90148079c: Merge "Localisation updates from https://translatewiki.net."

Event Timeline

dom_walden created this task.Jan 19 2021, 2:27 PM

Restricted Application added a project: Platform Engineering. · View Herald TranscriptJan 19 2021, 2:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• AMooney removed a project: Platform Engineering.Jan 19 2021, 2:29 PM

• Niharika triaged this task as Medium priority.Jan 19 2021, 5:17 PM

• Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.

ARamirez_WMF renamed this task from SecurePoll: Custom column labels do not appear (or do not appear correctly) to SecurePoll: Custom column labels do not appear (or do not appear correctly) [8h].Jan 20 2021, 6:24 PM

ARamirez_WMF moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.

ARamirez_WMF moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.Jan 20 2021, 6:52 PM

ARamirez_WMF edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.

dom_walden mentioned this in T271149: Convert SecurePoll CreatePage to use OOUI.Jan 21 2021, 3:34 PM

Taking this alongside T272433: Fix issue with Support label being arbitrarily removed in SecurePoll poll creation page [8h] because I stumbled upon this while doing that investigation and can't investigate farther until this is resolved 😂 😭

The issue comes from the additional JS being called from ./modules/ext.securepoll.htmlform.js (which has a very misleading comment!) that has become invalid now that we use OOUI. Pre-OOUI (you can checkout this state via git checkout 616ad5c), this js watches for changes in the min/max values and generates enough labels for the entire range dynamically:

(incidentally, this means that there appears to be no no-js support for this 👇 )

@Tchanders should we split this up into 2 tickets? One for js support (ie. update this JS to recognize the changing input and use OOUI widgets) and one for no-js support? I'm not sure how no-js support would look yet since the number of column labels depends on the user's inputed range.

STran moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.Jan 26 2021, 3:37 AM

STran moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Jan 27 2021, 10:42 AM

Fixed up the columns appearing for this ticket but left the inputs as-is for work in another ticket (T273043: Update custom column label inputs to use OOUI widgets)

Change 658950 had a related patch set uploaded (by STran; owner: STran):
[mediawiki/extensions/SecurePoll@master] Fix change handlers for custom columns in range voting

https://gerrit.wikimedia.org/r/658950

gerritbot added a project: Patch-For-Review.Jan 27 2021, 11:29 AM

Change 658950 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Fix change handlers for custom columns in range voting

https://gerrit.wikimedia.org/r/658950

Maintenance_bot removed a project: Patch-For-Review.Jan 28 2021, 8:11 PM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.29; 2021-02-02).Jan 28 2021, 9:00 PM

STran moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Jan 29 2021, 6:39 AM

STran mentioned this in T272433: Fix issue with Support label being arbitrarily removed in SecurePoll poll creation page [8h].Jan 29 2021, 12:21 PM