Page MenuHomePhabricator

Update IP addresses of Cloud VPS instances to mark internal traffic on refinery code
Closed, ResolvedPublic

Description

Before we deploy the changes for T209011: Change routing to ensure that traffic originating from Cloud VPS is seen as non-private IPs by Wikimedia wikis, update the ranges treated as Cloud VPS origin in org.wikimedia.analytics.refinery.core.IpUtil to include the Cloud VPS public ranges.

See T212862: Update IP addresses of cloud labs to mark internal traffic on refinery code and https://gerrit.wikimedia.org/r/c/analytics/refinery/source/+/481225 for a similar change that was made when we renumbered to 172.16/20 private addresses.

If we do not make this change and wait for it to be deployed prior to the actual networking switch, https://wmcs-edits.wmflabs.org/#wmcs-edits will not be accurate.

Event Timeline

I think the config should end up having all of the public and private ranges that Cloud VPS "owns" in it so that the classification works regardless of the routing that is in use at any given time. Also we should probably document this entanglement somewhere on wikitech.

Change 657329 had a related patch set uploaded (by Arturo Borrero Gonzalez; owner: Arturo Borrero Gonzalez):
[analytics/refinery/source@master] refinery-core: iputils: refresh cloud addresses

https://gerrit.wikimedia.org/r/657329

aborrero triaged this task as Medium priority.
aborrero moved this task from Inbox to Doing on the cloud-services-team (Kanban) board.

Change 657329 merged by jenkins-bot:
[analytics/refinery/source@master] refinery-core: iputils: refresh cloud addresses

https://gerrit.wikimedia.org/r/657329

Change 657383 had a related patch set uploaded (by Joal; owner: Joal):
[analytics/refinery@master] Update geoeditors monthly jar version for wmcs IPs

https://gerrit.wikimedia.org/r/657383

Change 657383 merged by Milimetric:
[analytics/refinery@master] Update geoeditors monthly jar version for wmcs IPs

https://gerrit.wikimedia.org/r/657383

Thanks you all! I'm closing this task now, feel free to reopen if there is more to do.