Page MenuHomePhabricator

Make WikiPage a ProperPageIdentity
Open, MediumPublic

Description

Before WikiPage can be made compatible with PageRecord, we first have to make sure WikiPage alwas represents a page that can exist on the wiki. A WikiPage should never be a SpecialPage, a section link, and interwiki link, etc.

  • deprecate construction of WikiPage with a Title that does not represent a proper page

Once we are sure that the deprecation warning isn't triggered by anything that WMF uses:

  • make WikiPage implement PageIdentity, make some methods throw when called on an instance that does not represent a proper page.
  • make WikiPage implement ProperPageIdentity, make the constructor throw when given a PageIdentity that isn't proper.

We may even wait until 1.36 is branched.

Related Objects

StatusSubtypeAssignedTask
Declineddchen
OpenNone
OpenNone
DuplicateNone
OpenNone
OpenNone
OpenNone
StalledNone
DuplicateNone
OpenNone
ResolvedNone
OpenNone
OpenNone
OpenNone
OpenNone
Resolvedppelberg
ResolvedKrinkle
OpenNone
ResolvedNone
ResolvedNone
StalledNone
OpenNone
OpenNone
Opendaniel
OpenNone
OpenNone
OpenNone
OpenNone
Opendaniel
Opendaniel
Resolveddaniel
ResolvedJdforrester-WMF
OpenPRODUCTION ERRORNone
Resolveddaniel
Resolveddaniel
Resolveddaniel

Event Timeline

daniel created this task.Jan 19 2021, 9:29 PM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptJan 19 2021, 9:29 PM

Change 657173 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] WikiPage: deprecated construction on bad titles

https://gerrit.wikimedia.org/r/657173

Change 657134 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Make WikiPage a (non-proper) PageIdentity

https://gerrit.wikimedia.org/r/657134

Change 656906 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Make WikiPage a ProperPageIdentity

https://gerrit.wikimedia.org/r/656906

Change 656944 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/FlaggedRevs@master] Use FlaggableWikiPage only for real pages

https://gerrit.wikimedia.org/r/656944

daniel claimed this task.Jan 19 2021, 9:38 PM
daniel triaged this task as Medium priority.
daniel raised the priority of this task from Medium to High.Jan 19 2021, 9:40 PM
daniel lowered the priority of this task from High to Medium.
daniel moved this task from Doing to Blocked on the Platform Team Workboards (MW Expedition) board.

Change 656944 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Use FlaggableWikiPage only for real pages

https://gerrit.wikimedia.org/r/656944

Change 657173 merged by jenkins-bot:
[mediawiki/core@master] WikiPage: deprecated construction on bad titles

https://gerrit.wikimedia.org/r/657173

Change 657134 merged by jenkins-bot:
[mediawiki/core@master] Make WikiPage a (non-proper) PageIdentity

https://gerrit.wikimedia.org/r/657134