Make WikiPage a ProperPageIdentity
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	daniel
	Jan 19 2021, 9:29 PM

Description

Before WikiPage can be made compatible with PageRecord, we first have to make sure WikiPage alwas represents a page that can exist on the wiki. A WikiPage should never be a SpecialPage, a section link, and interwiki link, etc.

deprecate construction of WikiPage with a Title that does not represent a proper page

Once we are sure that the deprecation warning isn't triggered by anything that WMF uses:

make WikiPage implement PageIdentity, make the constructor trigger a deprecation warning when given a PageIdentity that isn't proper.
make WikiPage implement ProperPageIdentity (i.e. make PageRecord extend ProeprPageIdentity), make the constructor throw when given a PageIdentity that isn't proper.

We may even wait until 1.36 is branched.

Details

Project	Branch	Lines +/-	Subject
mediawiki/core	master	+13 -87	Make WikiPage a ProperPageIdentity
mediawiki/core	master	+7 -48	Make WikiPage a ProperPageIdentity
mediawiki/core	master	+168 -24	Make WikiPage a (non-proper) PageIdentity
mediawiki/core	master	+90 -16	WikiPage: deprecated construction on bad titles
mediawiki/extensions/FlaggedRevs	master	+6 -5	Use FlaggableWikiPage only for real pages

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Declined		dchen	T118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
Open		None	T115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
Open		None	T115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
Duplicate		None	T115864 Figure out if the description of the image can be used as the caption on-wiki
Open	Feature	None	T53032 When inserting an image, set its caption by default to be the Commons image description
Open	BUG REPORT	None	T12863 Links on commons upload summaries do not link to commons
Open		None	T5498 Image history is confusing
Stalled		None	T96384 Integrate file revisions with description page history
Open	Feature	None	T39534 Wikimedia Commons should support searching by color
Duplicate		None	T39535 Wikimedia Commons should support filtering by color
Resolved		None	T19503 Provide metadata support on Wikimedia Commons
Open		None	T122038 Moving/Deleting a video file does not move/delete subtitles files, nor does it inform the file mover of their existence
Open		None	T135221 Make TimedText content an integral part of the File page
Open	Feature	None	T2167 Use a dedicated interface for adding meta-data like interwiki links, rather than wikitext
Open		None	T132072 Integrate page meta-data as a new content model revision slot for consistency and atomicity
Resolved		None	T51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
Resolved		None	T68108 [Epic] Store media information for files on Wikimedia Commons as structured data
Open	Feature	None	T14963 allow per-page exceptions to spam blacklist
Open		None	T203157 Make the spam whitelist its own slot
Open	Feature	None	T56140 Move TemplateData to its own JSON-content namespace and associate with Template-namespace, or to its own TemplateData content model and revision slot
Stalled		None	T174043 Deploy Multi-Content Revisions
Open		None	T174022 Implement multi-content revisions
Open		daniel	T196087 Refactored implementation of MCR page update interface
Open		None	T302623 FY2022-2023: Improve Backend Pageview Timing
Resolved		None	T206498 MediaWiki needlessly queries page data twice on page views
Open		None	T273514 MW expedition work [high effort]
Open		None	T273542 Migrate ZObjectStore from WikiPage to PageStore when it exists
Resolved		None	T195069 Factor PageStore and PageRecord out of WikiPage
Resolved		daniel	T272421 Make WikiPage a PageRecord
Resolved		daniel	T272424 Make WikiPage a ProperPageIdentity
Resolved		daniel	T272518 Watch for extensions broken by WikiPage now deprecating construction on bad titles
Resolved		Jdforrester-WMF	T272170 "FlaggablePageTest::testPageDataFromTitle" erroring on patches in it and its many dependent repos
Resolved	PRODUCTION ERROR	Umherirrender	T273506 [M] Sporadic “TypeError: Return value of EntityContentFactory::getTitleForId() must be an instance of Title, null returned” for Special:EntityData on Commons
Resolved		daniel	T274274 FileImporter constructs EditPage for a special page
Resolved		daniel	T274276 LiquidThreads constructs Article on special page
Resolved		daniel	T274317 CirrusSearch: access to WikiPage that not represents a page

Event Timeline

daniel created this task.Jan 19 2021, 9:29 PM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptJan 19 2021, 9:29 PM

Change 657173 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] WikiPage: deprecated construction on bad titles

https://gerrit.wikimedia.org/r/657173

Change 657134 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Make WikiPage a (non-proper) PageIdentity

https://gerrit.wikimedia.org/r/657134

Change 656906 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Make WikiPage a ProperPageIdentity

https://gerrit.wikimedia.org/r/656906

Change 656944 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/FlaggedRevs@master] Use FlaggableWikiPage only for real pages

https://gerrit.wikimedia.org/r/656944

daniel claimed this task.Jan 19 2021, 9:38 PM

daniel triaged this task as Medium priority.

daniel moved this task from Unsorted pile to Doing on the Platform Team Workboards (MW Expedition) board.

daniel raised the priority of this task from Medium to High.Jan 19 2021, 9:40 PM

daniel lowered the priority of this task from High to Medium.

daniel moved this task from Doing to Blocked on the Platform Team Workboards (MW Expedition) board.

daniel moved this task from Blocked to Waiting for Review on the Platform Team Workboards (MW Expedition) board.

Change 656944 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Use FlaggableWikiPage only for real pages

https://gerrit.wikimedia.org/r/656944

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.28; 2021-01-26).Jan 20 2021, 12:00 AM

Change 657173 merged by jenkins-bot:
[mediawiki/core@master] WikiPage: deprecated construction on bad titles

https://gerrit.wikimedia.org/r/657173

daniel changed the status of subtask T272518: Watch for extensions broken by WikiPage now deprecating construction on bad titles from Open to Stalled.Jan 20 2021, 6:12 PM

daniel updated the task description. (Show Details)Jan 21 2021, 4:50 PM

daniel moved this task from Waiting for Review to Blocked on the Platform Team Workboards (MW Expedition) board.

DannyS712 changed the status of subtask T272518: Watch for extensions broken by WikiPage now deprecating construction on bad titles from Stalled to Open.Jan 30 2021, 5:34 AM

• Pchelolo moved this task from Blocked to PageStore pile on the Platform Team Workboards (MW Expedition) board.Feb 3 2021, 6:13 PM

daniel moved this task from PageStore pile to Blocked on the Platform Team Workboards (MW Expedition) board.Feb 3 2021, 10:28 PM

Change 657134 merged by jenkins-bot:
[mediawiki/core@master] Make WikiPage a (non-proper) PageIdentity

https://gerrit.wikimedia.org/r/657134

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.32; 2021-02-23); removed MW-1.36-notes (1.36.0-wmf.28; 2021-01-26).Feb 16 2021, 4:00 PM

• Pchelolo moved this task from Blocked to Waiting for Review on the Platform Team Workboards (MW Expedition) board.Feb 23 2021, 5:45 PM

• Pchelolo moved this task from Waiting for Review to Waiting for release on the Platform Team Workboards (MW Expedition) board.

• Pchelolo closed subtask T272518: Watch for extensions broken by WikiPage now deprecating construction on bad titles as Resolved.Feb 23 2021, 9:02 PM

Daimona added a subscriber: Daimona.Aug 28 2021, 4:23 PM

Is this task still blocked?

daniel updated the task description. (Show Details)Aug 30 2021, 7:59 AM

daniel updated the task description. (Show Details)

In T272424#7317272, @Daimona wrote:

Is this task still blocked?

No, this is good to go now!

daniel moved this task from Waiting for release to PageStore pile on the Platform Team Workboards (MW Expedition) board.Aug 30 2021, 8:02 AM

Change 656906 abandoned by Daniel Kinzler:

[mediawiki/core@master] Make WikiPage a ProperPageIdentity

Reason:

stale

https://gerrit.wikimedia.org/r/656906

In T272424#7317783, @daniel wrote:

In T272424#7317272, @Daimona wrote:

Is this task still blocked?

No, this is good to go now!

Thank you! I'm going to send a commit then. I'd love to be able to typehint against ProperPageIdentity as a replacement of WikiPage, rather than using PageIdentity and then having to change it later on.

Change 715494 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] Make WikiPage a ProperPageIdentity

https://gerrit.wikimedia.org/r/715494

Change 715494 merged by jenkins-bot:

[mediawiki/core@master] Make WikiPage a ProperPageIdentity

https://gerrit.wikimedia.org/r/715494

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.23; 2021-09-13).Sep 7 2021, 8:00 PM

Daimona closed this task as Resolved.Sep 7 2021, 8:05 PM

Daimona updated the task description. (Show Details)

Daimona removed a project: Patch-For-Review.

Krinkle mentioned this in T301487: InvalidArgumentException: WikiPage constructed on a Title that cannot exist as a page: commons:File:The whole map of Sanmon-Santō Sakamoto Sōezu (1st volume).png.Feb 13 2022, 2:35 PM