Make RevisionRecord::getId() take a wiki ID
Closed, ResolvedPublic
Actions

Description

Context:
When creating PageIdentity (T208776) we decided that the getId() method should require a wiki ID to be passed in if the page belongs to a wiki other than the local site. This prevents data corruption due to using an ID that belongs to one wiki in the context of another.

PageRecord will inherit this pattern from PageIdentity. RevisionRecord should use it as well.

Note that the change to the method signature is not a breaking one, since the parameter would be optional. However, it's a breaking change in behavior: code that loads a RevisionRecord from another wiki and then calls getId() on it will need to be updated. So this change needs to go through the deprecation process.

make RevisionRecord::getId() trigger a deprecation warning when called without parameters, if it doesn't belong to the local wiki ($this->mWiki is not false).
make RevisionRecord::getId() throw an exception if the $wikiId parameter does not match the $this->mWiki field. Compare PageIdentityValue::getId().

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+93 -37	RevisionRecord: make RevisionRecord::getId() take a wiki ID

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Declined	dchen	T118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
Open	None	T115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
Open	None	T115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
Duplicate	None	T115864 Figure out if the description of the image can be used as the caption on-wiki
Open	None	T53032 When inserting an image, set its caption by default to be the Commons image description
Open	None	T12863 Links on commons upload summaries do not link to commons
Open	None	T5498 Image history is confusing
Stalled	None	T96384 Integrate file revisions with description page history
Open	None	T39534 Wikimedia Commons should support searching by color
Duplicate	None	T39535 Wikimedia Commons should support filtering by color
Resolved	None	T19503 Provide metadata support on Wikimedia Commons
Open	None	T122038 Moving/Deleting a video file does not move/delete subtitles files, nor does it inform the file mover of their existence
Open	None	T135221 Make TimedText content an integral part of the File page
Open	None	T2167 Use a dedicated interface for adding meta-data like interwiki links, rather than wikitext
Open	None	T132072 Integrate page meta-data as a new content model revision slot for consistency and atomicity
Resolved	None	T51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
Resolved	None	T68108 [Epic] Store media information for files on Wikimedia Commons as structured data
Open	None	T56140 Move TemplateData to its own JSON-content namespace and associate with Template-namespace, or to its own TemplateData content model and revision slot
Stalled	None	T174043 Deploy Multi-Content Revisions
Open	None	T203157 Make the spam whitelist its own slot
Open	None	T174022 Implement multi-content revisions
Open	daniel	T196087 Refactored implementation of MCR page update interface
Open	None	T206498 MediaWiki needlessly queries page data twice on page views
Open	None	T273514 MW expedition work [high effort]
Open	None	T273542 Migrate ZObjectStore from WikiPage to PageStore when it exists
Open	None	T195069 Factor PageStore and PageRecord out of WikiPage
Resolved	Peter.ovchyn	T272485 Make RevisionRecord::getId() take a wiki ID

Event Timeline

daniel created this task.Jan 20 2021, 1:41 PM

daniel triaged this task as Medium priority.Jan 20 2021, 6:04 PM

daniel moved this task from Unsorted pile to PageStore pile on the Platform Team Workboards (MW Expedition) board.

Peter.ovchyn claimed this task.Jan 21 2021, 6:34 PM

Peter.ovchyn moved this task from PageStore pile to Doing on the Platform Team Workboards (MW Expedition) board.

Change 658312 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/core@master] RevisionRecord: make RevisionRecord::getId() take a wiki ID

https://gerrit.wikimedia.org/r/658312

gerritbot added a project: Patch-For-Review.Jan 25 2021, 2:23 PM

Pchelolo mentioned this in T272901: Standardize RevisionRecord/Store use of wikiID vs dbDomain.Jan 25 2021, 6:58 PM

Change 658312 merged by jenkins-bot:
[mediawiki/core@master] RevisionRecord: make RevisionRecord::getId() take a wiki ID

https://gerrit.wikimedia.org/r/658312

Now we need to watch for wfDeprecated in production or any extension tests failures, and fix those.

Maintenance_bot removed a project: Patch-For-Review.Jan 29 2021, 2:10 PM

daniel updated the task description. (Show Details)Jan 29 2021, 2:11 PM

daniel mentioned this in T273284: Make RevisionRecord::getPageId() take a wiki ID.Jan 29 2021, 2:14 PM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.29; 2021-02-02).Jan 29 2021, 3:00 PM

Pchelolo closed this task as Resolved.Feb 1 2021, 6:37 PM

toan added a subscriber: toan.Feb 2 2021, 9:41 AM

Change 661114 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] In T272485 the signature of RevisionRecord::getId changed to take a wiki parameter that is used asserting that the correct wiki is being used.

https://gerrit.wikimedia.org/r/661114

gerritbot added a project: Patch-For-Review.Feb 2 2021, 12:34 PM

toan removed a project: Patch-For-Review.Feb 2 2021, 1:29 PM

toan mentioned this in T273622: Deprecation warning: Expected RevisionRecord to belong to ....Feb 2 2021, 1:41 PM

daniel mentioned this in T273667: Survey extensions for cross-wiki RevisionStore usage.Feb 2 2021, 8:07 PM