When creating PageIdentity (T208776) we decided that the getId() method should require a wiki ID to be passed in if the page belongs to a wiki other than the local site. This prevents data corruption due to using an ID that belongs to one wiki in the context of another.
PageRecord will inherit this pattern from PageIdentity. RevisionRecord should use it as well.
Note that the change to the method signature is not a breaking one, since the parameter would be optional. However, it's a breaking change in behavior: code that loads a RevisionRecord from another wiki and then calls getId() on it will need to be updated. So this change needs to go through the deprecation process.
- make RevisionRecord::getId() trigger a deprecation warning when called without parameters, if it doesn't belong to the local wiki ($this->mWiki is not false).
- make RevisionRecord::getId() throw an exception if the $wikiId parameter does not match the $this->mWiki field. Compare PageIdentityValue::getId().